Commit 712c48b
committed
Fix early return bug and improve test quality per maintainer feedback
- Remove early return in hydrateProperties() that was skipping text content validation
- Convert all React.createElement() to JSX syntax for better readability
- Replace eventLog arrays with jest.fn() mocks for proper testing
- Use querySelector() instead of firstChild for robust element selection
- Remove hydration warning suppression to catch regressions
- Fix hasAttribute/getAttribute assertion pattern
- Rename ce-not-registered to ce-registered-after-hydration for clarity
- Improve act() usage pattern with hydrateRoot
All 9 tests passing.1 parent b783d2a commit 712c48b
2 files changed
Lines changed: 146 additions & 222 deletions
File tree
- packages
- react-dom-bindings/src/client
- react-dom/src/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3231 | 3231 | | |
3232 | 3232 | | |
3233 | 3233 | | |
3234 | | - | |
| 3234 | + | |
3235 | 3235 | | |
3236 | 3236 | | |
3237 | 3237 | | |
| |||
0 commit comments