Skip to content

Commit 712c48b

Browse files
committed
Fix early return bug and improve test quality per maintainer feedback
- Remove early return in hydrateProperties() that was skipping text content validation - Convert all React.createElement() to JSX syntax for better readability - Replace eventLog arrays with jest.fn() mocks for proper testing - Use querySelector() instead of firstChild for robust element selection - Remove hydration warning suppression to catch regressions - Fix hasAttribute/getAttribute assertion pattern - Rename ce-not-registered to ce-registered-after-hydration for clarity - Improve act() usage pattern with hydrateRoot All 9 tests passing.
1 parent b783d2a commit 712c48b

2 files changed

Lines changed: 146 additions & 222 deletions

File tree

packages/react-dom-bindings/src/client/ReactDOMComponent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3231,7 +3231,7 @@ export function hydrateProperties(
32313231
undefined,
32323232
);
32333233
}
3234-
return true;
3234+
// Don't return early - let it continue to text content validation below
32353235
}
32363236

32373237
const children = props.children;

0 commit comments

Comments
 (0)