From 421894ea25ef0df812c4eac7659c5e8c15a3d18f Mon Sep 17 00:00:00 2001 From: Fabrizio Duroni Date: Wed, 25 Feb 2026 22:22:24 +0100 Subject: [PATCH] fix: migrate LogBoxData-test to jest modern timers --- .../LogBox/Data/__tests__/LogBoxData-test.js | 24 +++++++++++++------ 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxData-test.js b/packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxData-test.js index 15d955b20947..48bae2a748fa 100644 --- a/packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxData-test.js +++ b/packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxData-test.js @@ -10,9 +10,6 @@ 'use strict'; -// TODO(legacy-fake-timers): Fix these tests to work with modern timers. -jest.useFakeTimers({legacyFakeTimers: true}); - jest.mock('../../../Core/Devtools/parseErrorStack', () => { return {__esModule: true, default: jest.fn(() => [])}; }); @@ -144,16 +141,17 @@ const addSyntaxError = (options: $FlowFixMe) => { ); }; -beforeEach(() => { - jest.resetModules(); -}); - const flushToObservers = () => { // Observer updates are debounced and need to advance timers to flush. jest.runOnlyPendingTimers(); }; describe('LogBoxData', () => { + beforeEach(() => { + jest.useFakeTimers(); + jest.resetModules(); + }); + it('adds and dismisses logs', () => { addLogs(['A']); addSoftErrors(['B']); @@ -590,9 +588,13 @@ describe('LogBoxData', () => { expect(observer.mock.calls.length).toBe(1); addLogs(['A']); + flushToObservers(); addSoftErrors(['B']); + flushToObservers(); addFatalErrors(['C']); + flushToObservers(); addSyntaxError(); + flushToObservers(); expect(observer.mock.calls.length).toBe(5); LogBoxData.clearWarnings(); @@ -610,9 +612,13 @@ describe('LogBoxData', () => { expect(observer.mock.calls.length).toBe(1); addLogs(['A']); + flushToObservers(); addSoftErrors(['B']); + flushToObservers(); addFatalErrors(['C']); + flushToObservers(); addSyntaxError(); + flushToObservers(); expect(observer.mock.calls.length).toBe(5); LogBoxData.clearErrors(); @@ -854,4 +860,8 @@ describe('LogBoxData', () => { expect(Array.from(observerAfter.mock.calls[0][0].logs).length).toBe(0); }); }); + + afterEach(() => { + jest.useRealTimers(); + }); });