Commit 007475b
Phase 4: Multi-tool suppression parsing
Summary:
Phase 4 of the typestats migration plan (D96957977).
**What changed:**
- Replaced the hardcoded regex-based suppression parser (which only matched
`# pyrefly: ignore[…]`) with the multi-tool parser from
`pyrefly_python::ignore::Ignore`.
- The report now recognises suppression comments from seven tools:
`# type: ignore`, `# pyrefly: ignore`, `# pyright: ignore`,
`# mypy: type: ignore`, `# pyre-fixme`, `# ty: ignore`, and
`# zuban: ignore`.
- Renamed the struct from `Suppression` to `ReportSuppression` for clarity.
- The `kind` field now contains the originating tool name (e.g. `"pyrefly"`,
`"type"`, `"mypy"`) instead of the previous hardcoded `"ignore"`.
- Removed the `regex` crate dependency from this module.
**Files changed:**
- `report.rs`: rewrote `parse_suppressions`, renamed struct, updated imports.
- `suppressions.expected.json`: updated `kind` from `"ignore"` to `"pyrefly"`.
Reviewed By: yangdanny97
Differential Revision: D98536947
fbshipit-source-id: 91b6af70394608a646d47a854a47594ccb21de5b1 parent 234dc5d commit 007475b
2 files changed
Lines changed: 33 additions & 37 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
26 | | - | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
73 | | - | |
| 74 | + | |
74 | 75 | | |
75 | | - | |
76 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
| |||
122 | 124 | | |
123 | 125 | | |
124 | 126 | | |
125 | | - | |
| 127 | + | |
126 | 128 | | |
127 | 129 | | |
128 | 130 | | |
| |||
212 | 214 | | |
213 | 215 | | |
214 | 216 | | |
215 | | - | |
216 | | - | |
217 | | - | |
| 217 | + | |
| 218 | + | |
218 | 219 | | |
| 220 | + | |
| 221 | + | |
219 | 222 | | |
220 | 223 | | |
221 | 224 | | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
249 | 245 | | |
250 | 246 | | |
251 | 247 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
0 commit comments