Skip to content

Commit 2177788

Browse files
committed
[TASK] Add PHP 8.5 support
Relates: #284
1 parent 1af4ef4 commit 2177788

8 files changed

Lines changed: 38 additions & 41 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
- 8.2
1919
- 8.3
2020
- 8.4
21+
- 8.5
2122
steps:
2223
- name: Checkout
2324
uses: actions/checkout@v4
@@ -75,6 +76,8 @@ jobs:
7576
typo3-version: '^13.4'
7677
- php-version: '8.4'
7778
typo3-version: '^13.4'
79+
- php-version: '8.5'
80+
typo3-version: '^13.4'
7881
steps:
7982
- uses: actions/checkout@v4
8083

@@ -115,6 +118,9 @@ jobs:
115118
- name: Run Unit Tests PHP8.4
116119
run: nix-shell --arg phpVersion \"php84\" --pure --run project-test-unit
117120

121+
- name: Run Unit Tests PHP8.5
122+
run: nix-shell --arg phpVersion \"php85\" --pure --run project-test-unit
123+
118124
- name: Run Functional Tests PHP8.2
119125
run: nix-shell --arg phpVersion \"php82\" --pure --run project-test-functional
120126

@@ -124,6 +130,9 @@ jobs:
124130
- name: Run Functional Tests PHP8.4
125131
run: nix-shell --arg phpVersion \"php84\" --pure --run project-test-functional
126132

133+
- name: Run Functional Tests PHP8.5
134+
run: nix-shell --arg phpVersion \"php85\" --pure --run project-test-functional
135+
127136
test-acceptance:
128137
runs-on: ubuntu-latest
129138
needs:
@@ -143,3 +152,6 @@ jobs:
143152

144153
- name: Run Acceptance Tests PHP8.4
145154
run: nix-shell --arg phpVersion \"php84\" --pure --run project-test-acceptance
155+
156+
- name: Run Acceptance Tests PHP8.5
157+
run: nix-shell --arg phpVersion \"php85\" --pure --run project-test-acceptance

Build/UnitTests.xml

Lines changed: 0 additions & 30 deletions
This file was deleted.
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="true" bootstrap="../vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTestsBootstrap.php" colors="true" stopOnError="false" stopOnFailure="false" stopOnIncomplete="false" stopOnSkipped="false" beStrictAboutTestsThatDoNotTestAnything="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd" cacheDirectory=".phpunit.cache" requireCoverageMetadata="false">
33
<coverage/>
44
<testsuites>
5-
<testsuite name="Cart Products Extension">
5+
<testsuite name="functional">
66
<directory>../Tests/Functional/</directory>
77
</testsuite>
8+
<testsuite name="unit">
9+
<directory>../Tests/Unit/</directory>
10+
</testsuite>
811
</testsuites>
912
<source>
1013
<include>

Documentation/guides.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
interlink-shortcode="extcode/cart_products"
1212
/>
1313
<project title="Cart Products"
14-
release="7.2.0"
15-
version="7.2"
14+
release="7.3.0"
15+
version="7.3"
1616
copyright="2018 - 2025"
1717
/>
1818
<inventory id="t3tsref" url="https://docs.typo3.org/typo3cms/TyposcriptReference/"/>

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Sometimes minor versions also result in minor adjustments to own templates or co
3636

3737
| Cart Products | TYPO3 | PHP | Support/Development |
3838
|---------------|------------|-----------|--------------------------------------|
39-
| 7.x.x | 13.2 | 8.2 - 8.4 | Features, Bugfixes, Security Updates |
39+
| 7.x.x | 13.2 | 8.2 - 8.5 | Features, Bugfixes, Security Updates |
4040
| 6.x.x | 12.4 | 8.1+ | Bugfixes, Security Updates |
4141
| 5.x.x | 12.4 | 8.1+ | Security Updates |
4242
| 4.x.x | 10.4, 11.5 | 7.2+ | Security Updates |

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
}
4747
},
4848
"require": {
49-
"php": "~8.2.0 || ~8.3.0 || ~8.4.0",
49+
"php": "~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0",
5050
"ext-pdo": "*",
5151
"extcode/cart": "^11.0",
5252
"typo3/cms-core": "^13.4",
@@ -79,10 +79,10 @@
7979
"find *.php Classes Configuration Tests -name '*.php' -print0 | xargs -0 -n 1 -P 4 php -l"
8080
],
8181
"test:php:unit": [
82-
"vendor/bin/phpunit -c Build/UnitTests.xml"
82+
"vendor/bin/phpunit -c Build/phpunit.xml.dist --testsuite unit --display-warnings --display-deprecations --display-errors"
8383
],
8484
"test:php:functional": [
85-
"typo3DatabaseDriver=\"pdo_sqlite\" vendor/bin/phpunit -c Build/FunctionalTests.xml"
85+
"typo3DatabaseDriver=\"pdo_sqlite\" vendor/bin/phpunit -c Build/phpunit.xml.dist --testsuite functional --display-warnings --display-deprecations --display-errors"
8686
],
8787
"test:phpstan:analyse": [
8888
"vendor/bin/phpstan analyse -c Build/phpstan.neon --memory-limit 256M"

ext_emconf.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
'title' => 'Cart - Products',
55
'description' => 'Shopping Cart(s) for TYPO3 - Products',
66
'category' => 'plugin',
7-
'version' => '7.2.0',
7+
'version' => '7.3.0',
88
'state' => 'stable',
99
'author' => 'Daniel Gohlke',
1010
'author_email' => 'ext@extco.de',

shell.nix

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ let
8484
];
8585
text = ''
8686
project-install
87-
./vendor/bin/phpunit -c Build/UnitTests.xml --display-deprecations --display-warnings
87+
./vendor/bin/phpunit -c Build/phpunit.xml.dist --testsuite unit --display-warnings --display-deprecations --display-errors
8888
'';
8989
};
9090

@@ -96,7 +96,19 @@ let
9696
];
9797
text = ''
9898
project-install
99-
./vendor/bin/phpunit -c Build/FunctionalTests.xml --display-deprecations --display-warnings
99+
./vendor/bin/phpunit -c Build/phpunit.xml.dist --testsuite functional --display-warnings --display-deprecations --display-errors
100+
'';
101+
};
102+
103+
projectTestWithCoverage = pkgs.writeShellApplication {
104+
name = "project-test-with-coverage";
105+
runtimeInputs = [
106+
php
107+
projectInstall
108+
];
109+
text = ''
110+
project-install
111+
XDEBUG_MODE=coverage ./vendor/bin/phpunit -c Build/phpunit.xml.dist --coverage-html=coverage_result
100112
'';
101113
};
102114

@@ -133,13 +145,13 @@ in pkgs.mkShellNoCC {
133145
php
134146
composer
135147
projectInstall
136-
projectPhpstan
137148
projectCgl
138149
projectCglFix
139150
projectLint
140151
projectPhpstan
141152
projectTestUnit
142153
projectTestFunctional
154+
projectTestWithCoverage
143155
projectTestAcceptance
144156
];
145157

0 commit comments

Comments
 (0)