chore: improve error handling

Author: julienrbrt

types/serialization.go

@@ -182,6 +182,15 @@ func (sh *SignedHeader) FromDAEnvelopeProto(envelope *pb.DAHeaderEnvelope) error
 	if envelope.Header == nil {
 		return errors.New("da header envelope's Header is nil")
 	}
+	if envelope.Header.Height == 0 {
+		return errors.New("da header envelope's Header height cannot be 0")
+	}
+	if envelope.Header.ChainId == "" {
+		return errors.New("da header envelope's Header chain_id cannot be empty")
+	}
+	if envelope.Header.Time == 0 {
+		return errors.New("da header envelope's Header time cannot be 0")
+	}
 	if err := sh.Header.FromProto(envelope.Header); err != nil {
 		return err
 	}

types/serialization_test.go

@@ -473,5 +473,83 @@ func TestHeaderSerializationSize(t *testing.T) {
 	require.NoError(err)
 
 	assert.Equal(t, len(blob), 175, "Serialized header size has changed")
+}
+
+// TestFromDAEnvelopeProto_InvalidHeaders checks that FromDAEnvelopeProto returns errors for headers with missing required fields.
+func TestFromDAEnvelopeProto_InvalidHeaders(t *testing.T) {
+	cases := []struct {
+		name     string
+		envelope *pb.DAHeaderEnvelope
+		wantErr  string
+	}{
+		{
+			name:     "nil header",
+			envelope: &pb.DAHeaderEnvelope{Header: nil},
+			wantErr:  "da header envelope's Header is nil",
+		},
+		{
+			name: "zero height",
+			envelope: &pb.DAHeaderEnvelope{
+				Header: &pb.Header{
+					Height:  0,
+					ChainId: "testchain",
+					Time:    123456789,
+				},
+			},
+			wantErr: "da header envelope's Header height cannot be 0",
+		},
+		{
+			name: "empty chain_id",
+			envelope: &pb.DAHeaderEnvelope{
+				Header: &pb.Header{
+					Height:  1,
+					ChainId: "",
+					Time:    123456789,
+				},
+			},
+			wantErr: "da header envelope's Header chain_id cannot be empty",
+		},
+		{
+			name: "zero time",
+			envelope: &pb.DAHeaderEnvelope{
+				Header: &pb.Header{
+					Height:  1,
+					ChainId: "testchain",
+					Time:    0,
+				},
+			},
+			wantErr: "da header envelope's Header time cannot be 0",
+		},
+	}
 
+	for _, c := range cases {
+		t.Run(c.name, func(t *testing.T) {
+			sh := &SignedHeader{}
+			err := sh.FromDAEnvelopeProto(c.envelope)
+			assert.Error(t, err)
+			assert.Contains(t, err.Error(), c.wantErr)
+		})
+	}
+}
+
+// TestFromDAEnvelopeProto_ValidHeader checks that FromDAEnvelopeProto succeeds with valid header.
+func TestFromDAEnvelopeProto_ValidHeader(t *testing.T) {
+	envelope := &pb.DAHeaderEnvelope{
+		Header: &pb.Header{
+			Height:          1,
+			ChainId:         "testchain",
+			Time:            123456789,
+			ProposerAddress: []byte{1, 2, 3, 4},
+		},
+		Signature: []byte{5, 6, 7, 8},
+	}
+
+	sh := &SignedHeader{}
+	err := sh.FromDAEnvelopeProto(envelope)
+	assert.NoError(t, err)
+	assert.Equal(t, uint64(1), sh.Header.Height())
+	assert.Equal(t, "testchain", sh.Header.ChainID())
+	assert.Equal(t, uint64(123456789), sh.Header.BaseHeader.Time)
+	assert.Equal(t, []byte{1, 2, 3, 4}, sh.Header.ProposerAddress)
+	assert.Equal(t, Signature{5, 6, 7, 8}, sh.Signature)
 }