Skip to content

Commit 65fda97

Browse files
etrclaude
andcommitted
TASK-061: record TASK-024 comment relocation in spec
Add the 5th action item and two acceptance criteria that were captured during planning but never made it into the task's spec file. The work itself shipped in 06ad399 (mechanical cleanup sweep): the orphaned TASK-024 head was removed from webserver_setup.cpp above block_ip, and the full prologue was installed above webserver::unregister_impl_ in webserver_register.cpp — verified by grep guards (no copies in setup/webserver, one canonical copy in register at line 247). Status remains Done; this is a spec/docs sync only. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 948052a commit 65fda97

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

specs/tasks/M7-v2-cleanup/TASK-061.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Clear the mechanical leftovers flagged in the audit's "Proposed disposition (nex
1010
**Action Items:**
1111
- [x] Finish the truncated comment at `src/detail/webserver_register.cpp:344-349`. The TASK-029 block comment ends mid-sentence (`"…keeps working at the daemon level, but"` then closing brace). Either complete the sentence with the original intent (reconstruct from git history or surrounding code) or rewrite the comment to stand on its own.
1212
- [x] Remove the two orphan comment fragments at `src/webserver.cpp:503-504` (leftover from removed logic).
13+
- [x] Move the orphaned/truncated TASK-024 comment head from `src/detail/webserver_setup.cpp:441-445` (currently sits above the unrelated `block_ip`) to its correct home as a prologue above `webserver::unregister_impl_` in `src/detail/webserver_register.cpp:247`, restoring the full original sentence ending `"…dangling resource pointer after the maps drop their refs."` reconstructed from commit `ec82d90`. (Same split-artifact class as the items above; surfaced during TASK-061 planning, in scope per planning decision.)
1314
- [x] Update the stale `XFAIL_TESTS` comment block at `test/Makefile.am:67-74` to reflect that `header_hygiene` was removed when TASK-020 landed (cross-referenced at lines 532-535 in the same file).
1415
- [x] Drop the stale `RELEASE_NOTES.md) continue ;; # created by TASK-042, not yet present` line at `scripts/check-readme.sh:273` — TASK-042 has shipped.
1516
- [ ] Remove the decade-old `//TODO: personalized messages` at `test/littletest.hpp:21` only if we have a fork policy that lets us; otherwise leave (it's vendored).
@@ -21,6 +22,8 @@ Clear the mechanical leftovers flagged in the audit's "Proposed disposition (nex
2122
**Acceptance Criteria:**
2223
- `git diff master..HEAD -- src/detail/webserver_register.cpp` shows a complete, well-formed comment.
2324
- `src/webserver.cpp:503-504` no longer contains orphan comment fragments.
25+
- `src/detail/webserver_setup.cpp:441-445` no longer carries the TASK-024 comment head above `block_ip`.
26+
- `src/detail/webserver_register.cpp` shows the full TASK-024 prologue (ending `"…dangling resource pointer after the maps drop their refs."`) immediately above `webserver::unregister_impl_`.
2427
- `test/Makefile.am:67-74` no longer claims `header_hygiene` is in `XFAIL_TESTS`.
2528
- `scripts/check-readme.sh:273` no longer carries the "created by TASK-042, not yet present" line.
2629
- `make check` still green.

0 commit comments

Comments
 (0)