You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TASK-077: mark Done in M7 milestone index and persist 27 unworked review findings
Flip TASK-077 status to Done in TASK-077.md and _index.md, check off the
five action items, and log the 27 minor findings (0 critical, 0 major)
surfaced by the validation loop for future cleanup sweeps.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: specs/tasks/M7-v2-cleanup/TASK-077.md
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -14,11 +14,11 @@ Three whole-suite or near-whole-suite skips remove the library's portability cla
14
14
Either land Windows/Darwin variants or document and gate the exclusion behind a CI flag that asserts intent rather than letting silent skips drift.
15
15
16
16
**Action Items:**
17
-
-[] For `threaded.cpp`: write a Windows-shaped variant of the suite (matching the I/O completion port semantics MHD uses on Windows) under `#ifdef _WINDOWS`, or document why no Windows variant is feasible and capture the gap in `test/PORTABILITY.md`.
18
-
-[] For `ws_start_stop.cpp` Windows skip: same — variant suite under `#ifdef _WINDOWS`, or PORTABILITY.md note. Comment must explain *why* MHD's Windows path can't drive this scenario.
19
-
-[] For the postponed digest-auth Windows tests in `ws_start_stop.cpp:176-180` and `authentication.cpp:176-180`: either port them or document the upstream MHD-on-Windows limitation. If coordinated with TASK-062 (Digest RFC-7616), bring up there.
20
-
-[] For `ws_start_stop.cpp:337``custom_socket` Darwin skip: add a comment naming the macOS-specific limitation, or port. Comment must reference the specific Darwin syscall behaviour that fails.
21
-
-[] Add a `scripts/check-skip-rationales.sh` lint that fails CI if a `#ifndef _WINDOWS` or `#ifndef DARWIN` block in `test/integ/` lacks a `// reason:` comment.
17
+
-[x] For `threaded.cpp`: write a Windows-shaped variant of the suite (matching the I/O completion port semantics MHD uses on Windows) under `#ifdef _WINDOWS`, or document why no Windows variant is feasible and capture the gap in `test/PORTABILITY.md`.
18
+
-[x] For `ws_start_stop.cpp` Windows skip: same — variant suite under `#ifdef _WINDOWS`, or PORTABILITY.md note. Comment must explain *why* MHD's Windows path can't drive this scenario.
19
+
-[x] For the postponed digest-auth Windows tests in `ws_start_stop.cpp:176-180` and `authentication.cpp:176-180`: either port them or document the upstream MHD-on-Windows limitation. If coordinated with TASK-062 (Digest RFC-7616), bring up there.
20
+
-[x] For `ws_start_stop.cpp:337``custom_socket` Darwin skip: add a comment naming the macOS-specific limitation, or port. Comment must reference the specific Darwin syscall behaviour that fails.
21
+
-[x] Add a `scripts/check-skip-rationales.sh` lint that fails CI if a `#ifndef _WINDOWS` or `#ifndef DARWIN` block in `test/integ/` lacks a `// reason:` comment.
22
22
23
23
**Dependencies:**
24
24
- Blocked by: None
@@ -34,4 +34,4 @@ Either land Windows/Darwin variants or document and gate the exclusion behind a
0 commit comments