-
Notifications
You must be signed in to change notification settings - Fork 491
Expand file tree
/
Copy pathFeedUIIntegrationTests.swift
More file actions
574 lines (422 loc) · 24.3 KB
/
FeedUIIntegrationTests.swift
File metadata and controls
574 lines (422 loc) · 24.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
//
// Copyright © Essential Developer. All rights reserved.
//
import XCTest
import UIKit
import EssentialApp
import EssentialFeed
import EssentialFeediOS
@MainActor
class FeedUIIntegrationTests: XCTestCase {
func test_feedView_hasTitle() {
let (sut, _) = makeSUT()
sut.simulateAppearance()
XCTAssertEqual(sut.title, feedTitle)
}
func test_imageSelection_notifiesHandler() {
let image0 = makeImage()
let image1 = makeImage()
var selectedImages = [FeedImage]()
let (sut, loader) = makeSUT(selection: { selectedImages.append($0) })
sut.simulateAppearance()
loader.completeFeedLoading(with: [image0, image1], at: 0)
sut.simulateTapOnFeedImage(at: 0)
XCTAssertEqual(selectedImages, [image0])
sut.simulateTapOnFeedImage(at: 1)
XCTAssertEqual(selectedImages, [image0, image1])
}
func test_loadFeedActions_requestFeedFromLoader() {
let (sut, loader) = makeSUT()
XCTAssertEqual(loader.loadFeedCallCount, 0, "Expected no loading requests before view appears")
sut.simulateAppearance()
XCTAssertEqual(loader.loadFeedCallCount, 1, "Expected a loading request once view appears")
sut.simulateUserInitiatedReload()
XCTAssertEqual(loader.loadFeedCallCount, 1, "Expected no request until previous completes")
loader.completeFeedLoading(at: 0)
sut.simulateUserInitiatedReload()
XCTAssertEqual(loader.loadFeedCallCount, 2, "Expected another loading request once user initiates a reload")
loader.completeFeedLoading(at: 1)
sut.simulateUserInitiatedReload()
XCTAssertEqual(loader.loadFeedCallCount, 3, "Expected yet another loading request once user initiates another reload")
}
func test_loadFeedActions_runsAutomaticallyOnlyOnFirstAppearance() {
let (sut, loader) = makeSUT()
XCTAssertEqual(loader.loadFeedCallCount, 0, "Expected no loading requests before view appears")
sut.simulateAppearance()
XCTAssertEqual(loader.loadFeedCallCount, 1, "Expected a loading request once view appears")
sut.simulateAppearance()
XCTAssertEqual(loader.loadFeedCallCount, 1, "Expected no loading request the second time view appears")
}
func test_loadingFeedIndicator_isVisibleWhileLoadingFeed() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
XCTAssertTrue(sut.isShowingLoadingIndicator, "Expected loading indicator once view appears")
loader.completeFeedLoading(at: 0)
XCTAssertFalse(sut.isShowingLoadingIndicator, "Expected no loading indicator once loading completes successfully")
sut.simulateUserInitiatedReload()
XCTAssertTrue(sut.isShowingLoadingIndicator, "Expected loading indicator once user initiates a reload")
loader.completeFeedLoadingWithError(at: 1)
XCTAssertFalse(sut.isShowingLoadingIndicator, "Expected no loading indicator once user initiated loading completes with error")
}
func test_loadFeedCompletion_rendersSuccessfullyLoadedFeed() {
let image0 = makeImage(description: "a description", location: "a location")
let image1 = makeImage(description: nil, location: "another location")
let image2 = makeImage(description: "another description", location: nil)
let image3 = makeImage(description: nil, location: nil)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
assertThat(sut, isRendering: [])
loader.completeFeedLoading(with: [image0, image1], at: 0)
assertThat(sut, isRendering: [image0, image1])
sut.simulateLoadMoreFeedAction()
loader.completeLoadMore(with: [image0, image1, image2, image3], at: 0)
assertThat(sut, isRendering: [image0, image1, image2, image3])
sut.simulateUserInitiatedReload()
loader.completeFeedLoading(with: [image0, image1], at: 1)
assertThat(sut, isRendering: [image0, image1])
}
func test_loadFeedCompletion_rendersSuccessfullyLoadedEmptyFeedAfterNonEmptyFeed() {
let image0 = makeImage()
let image1 = makeImage()
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [image0], at: 0)
assertThat(sut, isRendering: [image0])
sut.simulateLoadMoreFeedAction()
loader.completeLoadMore(with: [image0, image1], at: 0)
assertThat(sut, isRendering: [image0, image1])
sut.simulateUserInitiatedReload()
loader.completeFeedLoading(with: [], at: 1)
assertThat(sut, isRendering: [])
}
func test_loadFeedCompletion_doesNotAlterCurrentRenderingStateOnError() {
let image0 = makeImage()
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [image0], at: 0)
assertThat(sut, isRendering: [image0])
sut.simulateUserInitiatedReload()
loader.completeFeedLoadingWithError(at: 1)
assertThat(sut, isRendering: [image0])
sut.simulateLoadMoreFeedAction()
loader.completeLoadMoreWithError(at: 0)
assertThat(sut, isRendering: [image0])
}
func test_loadFeedCompletion_rendersErrorMessageOnErrorUntilNextReload() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
XCTAssertEqual(sut.errorMessage, nil)
loader.completeFeedLoadingWithError(at: 0)
XCTAssertEqual(sut.errorMessage, loadError)
sut.simulateUserInitiatedReload()
XCTAssertEqual(sut.errorMessage, nil)
}
func test_tapOnErrorView_hidesErrorMessage() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
XCTAssertEqual(sut.errorMessage, nil)
loader.completeFeedLoadingWithError(at: 0)
XCTAssertEqual(sut.errorMessage, loadError)
sut.simulateErrorViewTap()
XCTAssertEqual(sut.errorMessage, nil)
}
// MARK: - Load More Tests
func test_loadMoreActions_requestMoreFromLoader() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage()])
XCTAssertEqual(loader.loadMoreCallCount, 0, "Expected no requests before until load more action")
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(loader.loadMoreCallCount, 1, "Expected load more request")
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(loader.loadMoreCallCount, 1, "Expected no request while loading more")
loader.completeLoadMore(lastPage: false, at: 0)
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(loader.loadMoreCallCount, 2, "Expected request after load more completed with more pages")
loader.completeLoadMoreWithError(at: 1)
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(loader.loadMoreCallCount, 3, "Expected request after load more failure")
loader.completeLoadMore(lastPage: true, at: 2)
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(loader.loadMoreCallCount, 3, "Expected no request after loading all pages")
}
func test_loadingMoreIndicator_isVisibleWhileLoadingMore() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
XCTAssertFalse(sut.isShowingLoadMoreFeedIndicator, "Expected no loading indicator once view appears")
loader.completeFeedLoading(with: [makeImage()], at: 0)
XCTAssertFalse(sut.isShowingLoadMoreFeedIndicator, "Expected no loading indicator once loading completes successfully")
sut.simulateLoadMoreFeedAction()
XCTAssertTrue(sut.isShowingLoadMoreFeedIndicator, "Expected loading indicator on load more action")
loader.completeLoadMore(with: [makeImage()], at: 0)
XCTAssertFalse(sut.isShowingLoadMoreFeedIndicator, "Expected no loading indicator once user initiated loading completes successfully")
sut.simulateLoadMoreFeedAction()
XCTAssertTrue(sut.isShowingLoadMoreFeedIndicator, "Expected loading indicator on second load more action")
loader.completeLoadMoreWithError(at: 1)
XCTAssertFalse(sut.isShowingLoadMoreFeedIndicator, "Expected no loading indicator once user initiated loading completes with error")
}
func test_loadMoreCompletion_rendersErrorMessageOnError() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading()
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(sut.loadMoreFeedErrorMessage, nil)
loader.completeLoadMoreWithError()
XCTAssertEqual(sut.loadMoreFeedErrorMessage, loadError)
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(sut.loadMoreFeedErrorMessage, nil)
}
func test_tapOnLoadMoreErrorView_loadsMore() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading()
sut.simulateLoadMoreFeedAction()
XCTAssertEqual(loader.loadMoreCallCount, 1)
sut.simulateTapOnLoadMoreFeedError()
XCTAssertEqual(loader.loadMoreCallCount, 1)
loader.completeLoadMoreWithError()
sut.simulateTapOnLoadMoreFeedError()
XCTAssertEqual(loader.loadMoreCallCount, 2)
}
// MARK: - Image View Tests
func test_feedImageView_loadsImageURLWhenVisible() {
let image0 = makeImage(url: URL(string: "http://url-0.com")!)
let image1 = makeImage(url: URL(string: "http://url-1.com")!)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
XCTAssertEqual(loader.loadedImageURLs, [], "Expected no image URL requests until views become visible")
loader.completeFeedLoading(with: [image0, image1])
sut.simulateFeedImageViewVisible(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image0.url], "Expected first image URL request once first view becomes visible")
sut.simulateFeedImageViewVisible(at: 1)
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image1.url], "Expected second image URL request once second view also becomes visible")
}
func test_feedImageView_cancelsImageLoadingWhenNotVisibleAnymore() {
let image0 = makeImage(url: URL(string: "http://url-0.com")!)
let image1 = makeImage(url: URL(string: "http://url-1.com")!)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [image0, image1])
XCTAssertEqual(loader.cancelledImageURLs, [], "Expected no cancelled image URL requests until image is not visible")
sut.simulateFeedImageViewNotVisible(at: 0)
XCTAssertEqual(loader.cancelledImageURLs, [image0.url], "Expected one cancelled image URL request once first image is not visible anymore")
sut.simulateFeedImageViewNotVisible(at: 1)
XCTAssertEqual(loader.cancelledImageURLs, [image0.url, image1.url], "Expected two cancelled image URL requests once second image is also not visible anymore")
}
func test_feedImageView_reloadsImageURLWhenBecomingVisibleAgain() {
let image0 = makeImage(url: URL(string: "http://url-0.com")!)
let image1 = makeImage(url: URL(string: "http://url-1.com")!)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [image0, image1])
sut.simulateFeedImageBecomingVisibleAgain(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image0.url], "Expected two image URL request after first view becomes visible again")
sut.simulateFeedImageBecomingVisibleAgain(at: 1)
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image0.url, image1.url, image1.url], "Expected two new image URL request after second view becomes visible again")
}
func test_feedImageViewLoadingIndicator_isVisibleWhileLoadingImage() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage(), makeImage()])
let view0 = sut.simulateFeedImageViewVisible(at: 0)
let view1 = sut.simulateFeedImageViewVisible(at: 1)
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, true, "Expected loading indicator for first view while loading first image")
XCTAssertEqual(view1?.isShowingImageLoadingIndicator, true, "Expected loading indicator for second view while loading second image")
loader.completeImageLoading(at: 0)
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, false, "Expected no loading indicator for first view once first image loading completes successfully")
XCTAssertEqual(view1?.isShowingImageLoadingIndicator, true, "Expected no loading indicator state change for second view once first image loading completes successfully")
loader.completeImageLoadingWithError(at: 1)
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, false, "Expected no loading indicator state change for first view once second image loading completes with error")
XCTAssertEqual(view1?.isShowingImageLoadingIndicator, false, "Expected no loading indicator for second view once second image loading completes with error")
view1?.simulateRetryAction()
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, false, "Expected no loading indicator state change for first view once second image loading completes with error")
XCTAssertEqual(view1?.isShowingImageLoadingIndicator, true, "Expected loading indicator state change for second view on retry action")
}
func test_feedImageView_rendersImageLoadedFromURL() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage(), makeImage()])
let view0 = sut.simulateFeedImageViewVisible(at: 0)
let view1 = sut.simulateFeedImageViewVisible(at: 1)
XCTAssertEqual(view0?.renderedImage, .none, "Expected no image for first view while loading first image")
XCTAssertEqual(view1?.renderedImage, .none, "Expected no image for second view while loading second image")
let imageData0 = UIImage.make(withColor: .red).pngData()!
loader.completeImageLoading(with: imageData0, at: 0)
XCTAssertEqual(view0?.renderedImage, imageData0, "Expected image for first view once first image loading completes successfully")
XCTAssertEqual(view1?.renderedImage, .none, "Expected no image state change for second view once first image loading completes successfully")
let imageData1 = UIImage.make(withColor: .blue).pngData()!
loader.completeImageLoading(with: imageData1, at: 1)
XCTAssertEqual(view0?.renderedImage, imageData0, "Expected no image state change for first view once second image loading completes successfully")
XCTAssertEqual(view1?.renderedImage, imageData1, "Expected image for second view once second image loading completes successfully")
}
func test_feedImageViewRetryButton_isVisibleOnImageURLLoadError() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage(), makeImage()])
let view0 = sut.simulateFeedImageViewVisible(at: 0)
let view1 = sut.simulateFeedImageViewVisible(at: 1)
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry action for first view while loading first image")
XCTAssertEqual(view1?.isShowingRetryAction, false, "Expected no retry action for second view while loading second image")
let imageData = UIImage.make(withColor: .red).pngData()!
loader.completeImageLoading(with: imageData, at: 0)
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry action for first view once first image loading completes successfully")
XCTAssertEqual(view1?.isShowingRetryAction, false, "Expected no retry action state change for second view once first image loading completes successfully")
loader.completeImageLoadingWithError(at: 1)
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry action state change for first view once second image loading completes with error")
XCTAssertEqual(view1?.isShowingRetryAction, true, "Expected retry action for second view once second image loading completes with error")
view1?.simulateRetryAction()
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry action state change for first view on second image retry")
XCTAssertEqual(view1?.isShowingRetryAction, false, "Expected no retry action for second view on retry")
}
func test_feedImageViewRetryButton_isVisibleOnInvalidImageData() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage()])
let view = sut.simulateFeedImageViewVisible(at: 0)
XCTAssertEqual(view?.isShowingRetryAction, false, "Expected no retry action while loading image")
let invalidImageData = Data("invalid image data".utf8)
loader.completeImageLoading(with: invalidImageData, at: 0)
XCTAssertEqual(view?.isShowingRetryAction, true, "Expected retry action once image loading completes with invalid image data")
}
func test_feedImageViewRetryAction_retriesImageLoad() {
let image0 = makeImage(url: URL(string: "http://url-0.com")!)
let image1 = makeImage(url: URL(string: "http://url-1.com")!)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [image0, image1])
let view0 = sut.simulateFeedImageViewVisible(at: 0)
let view1 = sut.simulateFeedImageViewVisible(at: 1)
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image1.url], "Expected two image URL request for the two visible views")
loader.completeImageLoadingWithError(at: 0)
loader.completeImageLoadingWithError(at: 1)
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image1.url], "Expected only two image URL requests before retry action")
view0?.simulateRetryAction()
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image1.url, image0.url], "Expected third imageURL request after first view retry action")
view1?.simulateRetryAction()
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image1.url, image0.url, image1.url], "Expected fourth imageURL request after second view retry action")
}
func test_feedImageView_preloadsImageURLWhenNearVisible() {
let image0 = makeImage(url: URL(string: "http://url-0.com")!)
let image1 = makeImage(url: URL(string: "http://url-1.com")!)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
XCTAssertEqual(loader.loadedImageURLs, [], "Expected no image URL requests until image is near visible")
loader.completeFeedLoading(with: [image0, image1])
sut.simulateFeedImageViewNearVisible(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image0.url], "Expected first image URL request once first image is near visible")
sut.simulateFeedImageViewNearVisible(at: 1)
XCTAssertEqual(loader.loadedImageURLs, [image0.url, image1.url], "Expected second image URL request once second image is near visible")
}
func test_feedImageView_cancelsImageURLPreloadingWhenNotNearVisibleAnymore() {
let image0 = makeImage(url: URL(string: "http://url-0.com")!)
let image1 = makeImage(url: URL(string: "http://url-1.com")!)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [image0, image1])
XCTAssertEqual(loader.cancelledImageURLs, [], "Expected no cancelled image URL requests until image is not near visible")
sut.simulateFeedImageViewNotNearVisible(at: 0)
XCTAssertEqual(loader.cancelledImageURLs, [image0.url], "Expected first cancelled image URL request once first image is not near visible anymore")
sut.simulateFeedImageViewNotNearVisible(at: 1)
XCTAssertEqual(loader.cancelledImageURLs, [image0.url, image1.url], "Expected second cancelled image URL request once second image is not near visible anymore")
}
func test_feedImageView_configuresViewCorrectlyWhenTransitioningFromNearVisibleToVisibleWhileStillPreloadingImage() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage()])
sut.simulateFeedImageViewNearVisible(at: 0)
let view0 = sut.simulateFeedImageViewVisible(at: 0)
XCTAssertEqual(view0?.renderedImage, nil, "Expected no rendered image when view becomes visible while still preloading image")
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry action when view becomes visible while still preloading image")
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, true, "Expected loading indicator when view becomes visible while still preloading image")
let imageData = UIImage.make(withColor: .red).pngData()!
loader.completeImageLoading(with: imageData, at: 0)
XCTAssertEqual(view0?.renderedImage, imageData, "Expected rendered image after image preloads successfully")
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry action after image preloads successfully")
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, false, "Expected no loading indicator after image preloads successfully")
}
func test_feedImageView_configuresViewCorrectlyWhenCellBecomingVisibleAgain() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage()])
let view0 = sut.simulateFeedImageBecomingVisibleAgain(at: 0)
XCTAssertEqual(view0?.renderedImage, nil, "Expected no rendered image when view becomes visible again")
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry action when view becomes visible again")
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, true, "Expected loading indicator when view becomes visible again")
let imageData = UIImage.make(withColor: .red).pngData()!
loader.completeImageLoading(with: imageData, at: 1)
XCTAssertEqual(view0?.renderedImage, imageData, "Expected rendered image when image loads successfully after view becomes visible again")
XCTAssertEqual(view0?.isShowingRetryAction, false, "Expected no retry when image loads successfully after view becomes visible again")
XCTAssertEqual(view0?.isShowingImageLoadingIndicator, false, "Expected no loading indicator when image loads successfully after view becomes visible again")
}
func test_feedImageView_doesNotShowDataFromPreviousRequestWhenCellIsReused() throws {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage(), makeImage()])
let view0 = try XCTUnwrap(sut.simulateFeedImageViewVisible(at: 0))
view0.prepareForReuse()
let imageData0 = UIImage.make(withColor: .red).pngData()!
loader.completeImageLoading(with: imageData0, at: 0)
XCTAssertEqual(view0.renderedImage, .none, "Expected no image state change for reused view once image loading completes successfully")
}
func test_feedImageView_showsDataForNewViewRequestAfterPreviousViewIsReused() throws {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage(), makeImage()])
let previousView = try XCTUnwrap(sut.simulateFeedImageViewNotVisible(at: 0))
let newView = try XCTUnwrap(sut.simulateFeedImageViewVisible(at: 0))
previousView.prepareForReuse()
let imageData = UIImage.make(withColor: .red).pngData()!
loader.completeImageLoading(with: imageData, at: 1)
XCTAssertEqual(newView.renderedImage, imageData)
}
func test_feedImageView_doesNotRenderLoadedImageWhenNotVisibleAnymore() {
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [makeImage()])
let view = sut.simulateFeedImageViewNotVisible(at: 0)
loader.completeImageLoading(with: anyImageData())
XCTAssertNil(view?.renderedImage, "Expected no rendered image when an image load finishes after the view is not visible anymore")
}
func test_feedImageView_doesNotLoadImageAgainUntilPreviousRequestCompletes() {
let image = makeImage(url: URL(string: "http://url-0.com")!)
let (sut, loader) = makeSUT()
sut.simulateAppearance()
loader.completeFeedLoading(with: [image])
sut.simulateFeedImageViewNearVisible(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image.url], "Expected first request when near visible")
sut.simulateFeedImageViewVisible(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image.url], "Expected no request until previous completes")
loader.completeImageLoading(at: 0)
sut.simulateFeedImageViewVisible(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image.url, image.url], "Expected second request when visible after previous complete")
sut.simulateFeedImageViewNotVisible(at: 0)
sut.simulateFeedImageViewVisible(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image.url, image.url, image.url], "Expected third request when visible after canceling previous complete")
sut.simulateLoadMoreFeedAction()
loader.completeLoadMore(with: [image, makeImage()])
sut.simulateFeedImageViewVisible(at: 0)
XCTAssertEqual(loader.loadedImageURLs, [image.url, image.url, image.url], "Expected no request until previous completes")
}
// MARK: - Helpers
private func makeSUT(
selection: @MainActor @escaping (FeedImage) -> Void = { _ in },
file: StaticString = #filePath,
line: UInt = #line
) -> (sut: ListViewController, loader: LoaderSpy) {
let loader = LoaderSpy()
let sut = FeedUIComposer.feedComposedWith(
feedLoader: loader.loadPublisher,
imageLoader: loader.loadImageDataPublisher,
selection: selection
)
trackForMemoryLeaks(loader, file: file, line: line)
trackForMemoryLeaks(sut, file: file, line: line)
return (sut, loader)
}
private func makeImage(description: String? = nil, location: String? = nil, url: URL = URL(string: "http://any-url.com")!) -> FeedImage {
return FeedImage(id: UUID(), description: description, location: location, url: url)
}
private func anyImageData() -> Data {
return UIImage.make(withColor: .red).pngData()!
}
}