Fix enable_internal_pullup to always use pull-ups

Previously, the pull direction was based on btn_pressed_level, which
caused pull-downs to be applied to encoder pins when btn_pressed_level
was 1. Encoder pins always need pull-ups since they are wired with
common to ground. Now always uses pull-ups and documents that the
button pin may need a separate pull-down when btn_pressed_level is 1.

Fixes #12

Author: cleishm

encoder.c

@@ -230,16 +230,8 @@ esp_err_t rotary_encoder_create(const rotary_encoder_config_t *config, rotary_en
     io_conf.mode = GPIO_MODE_INPUT;
     if (config->enable_internal_pullup)
     {
-        if (re->btn_pressed_level == 0)
-        {
-            io_conf.pull_up_en = GPIO_PULLUP_ENABLE;
-            io_conf.pull_down_en = GPIO_PULLDOWN_DISABLE;
-        }
-        else
-        {
-            io_conf.pull_up_en = GPIO_PULLUP_DISABLE;
-            io_conf.pull_down_en = GPIO_PULLDOWN_ENABLE;
-        }
+        io_conf.pull_up_en = GPIO_PULLUP_ENABLE;
+        io_conf.pull_down_en = GPIO_PULLDOWN_DISABLE;
     }
     else
     {

encoder.h

@@ -96,8 +96,17 @@ typedef struct
     gpio_num_t pin_a;                    //!< Encoder pin A
     gpio_num_t pin_b;                    //!< Encoder pin B
     gpio_num_t pin_btn;                  //!< Button pin, or GPIO_NUM_NC if unused
-    uint8_t btn_pressed_level;           //!< GPIO level when button is pressed (0 or 1)
-    bool enable_internal_pullup;         //!< Enable internal pull-up/pull-down resistors on GPIO pins
+    uint8_t btn_pressed_level;           //!< GPIO level when button is pressed (0 or 1).
+                                         //!< When set to 1, the button pin may need a pull-down
+                                         //!< resistor, either external or set via \c gpio_set_pull_mode()
+                                         //!< before creating the encoder, as \c enable_internal_pullup
+                                         //!< only enables pull-ups.
+    bool enable_internal_pullup;         //!< Enable internal pull-up resistors on all encoder and
+                                         //!< button GPIO pins. Pull-ups are always used, which is
+                                         //!< correct for encoders wired with common to ground. When
+                                         //!< \c btn_pressed_level is 1, the button pin may need a
+                                         //!< pull-down instead — use an external resistor or call
+                                         //!< \c gpio_set_pull_mode() before creating the encoder.
     uint32_t btn_dead_time_us;           //!< Button dead time in microseconds
     uint32_t btn_long_press_time_us;     //!< Long press threshold in microseconds
     uint32_t acceleration_threshold_ms;  //!< Acceleration threshold in milliseconds (acceleration starts below this interval)

idf_component.yml

@@ -1,5 +1,5 @@
 ---
-version: 3.0.0
+version: 3.0.1
 description: HW timer-based driver for incremental rotary encoders
 license: BSD-3
 targets: