From 66d0cf89265533fa5f6545a2866b6b45dd1b358b Mon Sep 17 00:00:00 2001
From: Erik Darling <2136037+erikdarlingdata@users.noreply.github.com>
Date: Mon, 23 Mar 2026 19:41:16 -0400
Subject: [PATCH] v2.4.1: Check for Updates button, collector health cleanup,
 pipeline fix

- About window: replaced hyperlink with proper Button for "Check for
  Updates" in both Dashboard and Lite (matches PerformanceStudio)
- Collector health: clear stale entries when a server is removed,
  fixing status bar showing errors for deleted servers
- Pipeline: split Velopack uploads into separate steps so Dashboard
  and Lite don't conflict on release asset names
- Version bump to 2.4.1

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .github/workflows/build.yml                  | 10 ++++++-
 Dashboard/AboutWindow.xaml                   | 11 ++++---
 Dashboard/Dashboard.csproj                   |  8 +++---
 Installer/PerformanceMonitorInstaller.csproj |  8 +++---
 InstallerGui/InstallerGui.csproj             |  8 +++---
 Lite/MainWindow.xaml.cs                      | 13 +++++++++
 Lite/PerformanceMonitorLite.csproj           |  8 +++---
 Lite/Services/RemoteCollectorService.cs      | 30 ++++++++++++++++++++
 Lite/Windows/AboutWindow.xaml                | 11 ++++---
 9 files changed, 78 insertions(+), 29 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 92d06a69..9d7b2173 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -202,7 +202,7 @@ jobs:
         run: |
           gh release upload ${{ github.event.release.tag_name }} releases/*.zip releases/SHA256SUMS.txt --clobber
 
-      - name: Upload Velopack artifacts
+      - name: Upload Dashboard Velopack artifacts
         if: github.event_name == 'release'
         shell: pwsh
         env:
@@ -210,4 +210,12 @@ jobs:
           VERSION: ${{ steps.version.outputs.VERSION }}
         run: |
           vpk upload github --repoUrl https://github.com/${{ github.repository }} --channel dashboard -o releases/velopack-dashboard --releaseName "v$env:VERSION" --tag "v$env:VERSION" --merge --token $env:GH_TOKEN
+
+      - name: Upload Lite Velopack artifacts
+        if: github.event_name == 'release'
+        shell: pwsh
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          VERSION: ${{ steps.version.outputs.VERSION }}
+        run: |
           vpk upload github --repoUrl https://github.com/${{ github.repository }} --channel lite -o releases/velopack-lite --releaseName "v$env:VERSION" --tag "v$env:VERSION" --merge --token $env:GH_TOKEN
diff --git a/Dashboard/AboutWindow.xaml b/Dashboard/AboutWindow.xaml
index 5fa28bcb..6d3d0134 100644
--- a/Dashboard/AboutWindow.xaml
+++ b/Dashboard/AboutWindow.xaml
@@ -38,12 +38,11 @@
                     Report an Issue
                 </Hyperlink>
             </TextBlock>
-            <TextBlock FontSize="12">
-                <Hyperlink x:Name="CheckUpdatesLink" Click="CheckUpdatesLink_Click">
-                    Check for Updates
-                </Hyperlink>
-            </TextBlock>
-            <TextBlock x:Name="UpdateStatusText" FontSize="11" Foreground="{DynamicResource ForegroundMutedBrush}" Margin="0,3,0,0" Visibility="Collapsed"/>
+            <StackPanel Orientation="Horizontal" Margin="0,4,0,0">
+                <Button Content="Check for Updates" Click="CheckUpdatesLink_Click" Padding="10,4" FontSize="12"/>
+                <TextBlock x:Name="UpdateStatusText" FontSize="11" VerticalAlignment="Center" Margin="8,0,0,0"
+                           Foreground="{DynamicResource ForegroundMutedBrush}" Visibility="Collapsed"/>
+            </StackPanel>
         </StackPanel>
 
         <!-- Links -->
diff --git a/Dashboard/Dashboard.csproj b/Dashboard/Dashboard.csproj
index 73b591ef..d9df3e5f 100644
--- a/Dashboard/Dashboard.csproj
+++ b/Dashboard/Dashboard.csproj
@@ -7,10 +7,10 @@
     <StartupObject>PerformanceMonitorDashboard.Program</StartupObject>
     <AssemblyName>PerformanceMonitorDashboard</AssemblyName>
     <Product>SQL Server Performance Monitor Dashboard</Product>
-    <Version>2.4.0</Version>
-    <AssemblyVersion>2.4.0.0</AssemblyVersion>
-    <FileVersion>2.4.0.0</FileVersion>
-    <InformationalVersion>2.4.0</InformationalVersion>
+    <Version>2.4.1</Version>
+    <AssemblyVersion>2.4.1.0</AssemblyVersion>
+    <FileVersion>2.4.1.0</FileVersion>
+    <InformationalVersion>2.4.1</InformationalVersion>
     <Company>Darling Data, LLC</Company>
     <Copyright>Copyright © 2026 Darling Data, LLC</Copyright>
     <ApplicationIcon>EDD.ico</ApplicationIcon>
diff --git a/Installer/PerformanceMonitorInstaller.csproj b/Installer/PerformanceMonitorInstaller.csproj
index f9243d8d..2624bb46 100644
--- a/Installer/PerformanceMonitorInstaller.csproj
+++ b/Installer/PerformanceMonitorInstaller.csproj
@@ -20,10 +20,10 @@
     <!-- Application metadata -->
     <AssemblyName>PerformanceMonitorInstaller</AssemblyName>
     <Product>SQL Server Performance Monitor Installer</Product>
-    <Version>2.4.0</Version>
-    <AssemblyVersion>2.4.0.0</AssemblyVersion>
-    <FileVersion>2.4.0.0</FileVersion>
-    <InformationalVersion>2.4.0</InformationalVersion>
+    <Version>2.4.1</Version>
+    <AssemblyVersion>2.4.1.0</AssemblyVersion>
+    <FileVersion>2.4.1.0</FileVersion>
+    <InformationalVersion>2.4.1</InformationalVersion>
     <Company>Darling Data, LLC</Company>
     <Copyright>Copyright © 2026 Darling Data, LLC</Copyright>
     <Description>Installation utility for SQL Server Performance Monitor - Supports SQL Server 2016-2025</Description>
diff --git a/InstallerGui/InstallerGui.csproj b/InstallerGui/InstallerGui.csproj
index df994fc9..c063f112 100644
--- a/InstallerGui/InstallerGui.csproj
+++ b/InstallerGui/InstallerGui.csproj
@@ -8,10 +8,10 @@
     <AssemblyName>PerformanceMonitorInstallerGui</AssemblyName>
     <RootNamespace>PerformanceMonitorInstallerGui</RootNamespace>
     <Product>SQL Server Performance Monitor Installer</Product>
-    <Version>2.4.0</Version>
-    <AssemblyVersion>2.4.0.0</AssemblyVersion>
-    <FileVersion>2.4.0.0</FileVersion>
-    <InformationalVersion>2.4.0</InformationalVersion>
+    <Version>2.4.1</Version>
+    <AssemblyVersion>2.4.1.0</AssemblyVersion>
+    <FileVersion>2.4.1.0</FileVersion>
+    <InformationalVersion>2.4.1</InformationalVersion>
     <Company>Darling Data, LLC</Company>
     <Copyright>Copyright © 2026 Darling Data, LLC</Copyright>
     <ApplicationIcon>EDD.ico</ApplicationIcon>
diff --git a/Lite/MainWindow.xaml.cs b/Lite/MainWindow.xaml.cs
index 06daed07..f86b1a48 100644
--- a/Lite/MainWindow.xaml.cs
+++ b/Lite/MainWindow.xaml.cs
@@ -832,6 +832,16 @@ private void ManageServersButton_Click(object sender, RoutedEventArgs e)
 
         if (window.ServersChanged)
         {
+            // Purge collector health for servers that were removed
+            if (_collectorService != null)
+            {
+                var currentServerIds = new HashSet<int>(
+                    _serverManager.GetAllServers().Select(s =>
+                        RemoteCollectorService.GetDeterministicHashCode(
+                            RemoteCollectorService.GetServerNameForStorage(s))));
+                _collectorService.ClearHealthExcept(currentServerIds);
+            }
+
             RefreshServerList();
         }
     }
@@ -1087,6 +1097,9 @@ private void ServerContextMenu_Remove_Click(object sender, RoutedEventArgs e)
         if (result == MessageBoxResult.Yes)
         {
             CloseServerTab(server.Id);
+            _collectorService?.ClearHealthForServer(
+                RemoteCollectorService.GetDeterministicHashCode(
+                    RemoteCollectorService.GetServerNameForStorage(server)));
             _serverManager.DeleteServer(server.Id);
             RefreshServerList();
             StatusText.Text = $"Removed server: {server.DisplayNameWithIntent}";
diff --git a/Lite/PerformanceMonitorLite.csproj b/Lite/PerformanceMonitorLite.csproj
index 76c69a5b..aa35371b 100644
--- a/Lite/PerformanceMonitorLite.csproj
+++ b/Lite/PerformanceMonitorLite.csproj
@@ -8,10 +8,10 @@
     <AssemblyName>PerformanceMonitorLite</AssemblyName>
     <RootNamespace>PerformanceMonitorLite</RootNamespace>
     <Product>SQL Server Performance Monitor Lite</Product>
-    <Version>2.4.0</Version>
-    <AssemblyVersion>2.4.0.0</AssemblyVersion>
-    <FileVersion>2.4.0.0</FileVersion>
-    <InformationalVersion>2.4.0</InformationalVersion>
+    <Version>2.4.1</Version>
+    <AssemblyVersion>2.4.1.0</AssemblyVersion>
+    <FileVersion>2.4.1.0</FileVersion>
+    <InformationalVersion>2.4.1</InformationalVersion>
     <Company>Darling Data, LLC</Company>
     <Copyright>Copyright © 2026 Darling Data, LLC</Copyright>
     <Description>Lightweight SQL Server performance monitoring - no installation required on target servers</Description>
diff --git a/Lite/Services/RemoteCollectorService.cs b/Lite/Services/RemoteCollectorService.cs
index bd2f3c95..e8f51c94 100644
--- a/Lite/Services/RemoteCollectorService.cs
+++ b/Lite/Services/RemoteCollectorService.cs
@@ -162,6 +162,36 @@ public CollectorHealthSummary GetHealthSummary(int? serverId = null)
         }
     }
 
+    /// <summary>
+    /// Clears collector health entries for a server that has been removed.
+    /// Prevents stale error counts from showing in the status bar.
+    /// </summary>
+    public void ClearHealthForServer(int serverId)
+    {
+        lock (_healthLock)
+        {
+            var keys = _collectorHealth.Keys.Where(k => k.ServerId == serverId).ToList();
+            foreach (var key in keys)
+                _collectorHealth.Remove(key);
+        }
+    }
+
+    /// <summary>
+    /// Clears collector health entries for all servers NOT in the provided set.
+    /// Used after Manage Servers to purge stale entries for removed servers.
+    /// </summary>
+    public void ClearHealthExcept(HashSet<int> activeServerIds)
+    {
+        lock (_healthLock)
+        {
+            var keys = _collectorHealth.Keys
+                .Where(k => !activeServerIds.Contains(k.ServerId))
+                .ToList();
+            foreach (var key in keys)
+                _collectorHealth.Remove(key);
+        }
+    }
+
     /// <summary>
     /// Records a collector execution result for health tracking.
     /// </summary>
diff --git a/Lite/Windows/AboutWindow.xaml b/Lite/Windows/AboutWindow.xaml
index 8b40f0ba..d8b77ebf 100644
--- a/Lite/Windows/AboutWindow.xaml
+++ b/Lite/Windows/AboutWindow.xaml
@@ -46,12 +46,11 @@
                     Report an Issue
                 </Hyperlink>
             </TextBlock>
-            <TextBlock FontSize="12" Margin="0,0,0,5">
-                <Hyperlink x:Name="CheckUpdatesLink" Click="CheckUpdatesLink_Click">
-                    Check for Updates
-                </Hyperlink>
-            </TextBlock>
-            <TextBlock x:Name="UpdateStatusText" FontSize="11" Foreground="{DynamicResource ForegroundMutedBrush}" Margin="0,0,0,5" Visibility="Collapsed"/>
+            <StackPanel Orientation="Horizontal" Margin="0,4,0,5">
+                <Button Content="Check for Updates" Click="CheckUpdatesLink_Click" Padding="10,4" FontSize="12"/>
+                <TextBlock x:Name="UpdateStatusText" FontSize="11" VerticalAlignment="Center" Margin="8,0,0,0"
+                           Foreground="{DynamicResource ForegroundMutedBrush}" Visibility="Collapsed"/>
+            </StackPanel>
             <TextBlock FontSize="12">
                 <Hyperlink x:Name="DarlingDataLink" Click="DarlingDataLink_Click">
                     www.erikdarling.com