RuboCop: resolve Lint/UselessAssignment

Author: orien

.rubocop_todo.yml

@@ -110,14 +110,6 @@ Lint/UselessAccessModifier:
     - 'lib/stack_master/parameter_loader.rb'
     - 'lib/stack_master/template_compilers/sparkle_formation.rb'
 
-# This cop supports safe autocorrection (--autocorrect).
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/stack_master/cli.rb'
-    - 'lib/stack_master/commands/tidy.rb'
-    - 'lib/stack_master/parameter_resolvers/latest_ami_by_tags.rb'
-    - 'lib/stack_master/template_compiler.rb'
-
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:

lib/stack_master/cli.rb

@@ -263,7 +263,7 @@ def default_config_file
     def load_config(file)
       stack_file = file || default_config_file
       StackMaster::Config.load!(stack_file)
-    rescue Errno::ENOENT => e
+    rescue Errno::ENOENT
       say "Failed to load config file #{stack_file}"
       @kernel.exit false
     end
@@ -301,7 +301,7 @@ def execute_stacks_command(command, args, options)
     end
 
     def show_other_region_candidates(config, stack_name)
-      candidates = config.filter(region = '', stack_name = stack_name)
+      candidates = config.filter('', stack_name = stack_name)
       return if candidates.empty?
 
       StackMaster.stdout.puts "Stack name #{stack_name} exists in regions: #{candidates.map(&:region).join(', ')}"

lib/stack_master/commands/tidy.rb

@@ -5,13 +5,10 @@ class Tidy
       include StackMaster::Commands::TerminalHelper
 
       def perform
-        used_templates = []
-        used_parameter_files = []
-
         templates = Set.new(find_templates)
         parameter_files = Set.new(find_parameter_files)
 
-        status = @config.stacks.each do |stack_definition|
+        @config.stacks.each do |stack_definition|
           parameter_files.subtract(stack_definition.parameter_files_from_globs)
           template = File.absolute_path(stack_definition.template_file_path)
 

lib/stack_master/parameter_resolvers/latest_ami_by_tags.rb

@@ -10,7 +10,7 @@ def initialize(config, stack_definition)
       end
 
       def resolve(value)
-        filters = @ami_finder.build_filters_from_string(value, prefix = 'tag')
+        filters = @ami_finder.build_filters_from_string(value, 'tag')
         @ami_finder.find_latest_ami(filters)&.image_id
       end
     end

lib/stack_master/template_compiler.rb

@@ -10,7 +10,7 @@ def self.compile(config, template_compiler, template_dir, template, compile_time
                  end
       compiler.require_dependencies
       compiler.compile(template_dir, template, compile_time_parameters, compiler_options)
-    rescue StandardError => e
+    rescue StandardError
       raise TemplateCompilationFailed, "Failed to compile #{template}"
     end