Skip to content

Commit f4bb6cf

Browse files
authored
Merge pull request #225 from envato/ci
Run the test suite against Rails 8.1, 8.0, 7.2, and Ruby 4.0, 3.4, 3.3, 3.2
2 parents d160cb1 + ebb9375 commit f4bb6cf

10 files changed

Lines changed: 34 additions & 27 deletions

File tree

.github/workflows/ci-workflow.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,17 @@ jobs:
55
name: 'Test (Ruby: ${{ matrix.ruby }}, Rails: ${{ matrix.rails }}, DB: ${{ matrix.db }})'
66
runs-on: ubuntu-latest
77
strategy:
8+
fail-fast: false
89
matrix:
9-
ruby: ['3.3', '3.2', '3.1', '3.0']
10-
rails: ['7.1', '7.0', '6.1']
10+
ruby: ['4.0', '3.4', '3.3', '3.2']
11+
rails: ['8.1', '8.0', '7.2']
1112
db: [mysql, postgres, sqlite]
1213
env:
1314
BUNDLE_GEMFILE: ${{ github.workspace }}/spec/support/gemfiles/Gemfile.rails-${{ matrix.rails }}.x
1415
DB: ${{ matrix.db }}
1516
services:
1617
mysql:
17-
image: mysql:5.7
18+
image: mysql:8.0
1819
env:
1920
MYSQL_DATABASE: double_entry_test
2021
MYSQL_USER: mysql

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
77

88
## [Unreleased]
99

10+
- Run the test suite against Rails 8.1, 8.0, 7.2, and Ruby 4.0, 3.4, 3.3, 3.2 ([#225]).
11+
1012
[Unreleased]: https://github.com/envato/double_entry/compare/v2.0.1...HEAD
13+
[#225]: https://github.com/envato/double_entry/pull/225
1114

1215
## [2.0.1] - 2023-11-01
1316

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ DoubleEntry uses the [Money gem](https://github.com/RubyMoney/money) to encapsul
2222
DoubleEntry is tested against:
2323

2424
Ruby
25+
* 4.0.x
26+
* 3.4.x
2527
* 3.3.x
2628
* 3.2.x
27-
* 3.1.x
28-
* 3.0.x
2929

3030
Rails
31-
* 7.1.x
32-
* 7.0.x
33-
* 6.1.x
31+
* 8.1.x
32+
* 8.0.x
33+
* 7.2.x
3434

3535
Databases
3636
* MySQL

script/jack_hammer

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
4040
require 'double_entry'
4141
require 'double_entry/line'
4242

43+
Money.default_currency = Money::Currency.new('USD')
44+
4345
def parse_options
4446
$account_count = 5
4547
$process_count = 20

spec/double_entry/validation/line_check_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ module Validation
7676
its(:errors_found) { should be true }
7777

7878
its(:log) { should include <<~LOG }
79-
Error on account \#{Account account: savings scope: currency: USD}: 100.01 (cached balance) != 100.00 (running balance)
79+
Error on account \#{Account account: savings scope: currency: }: 100.01 (cached balance) != 100.00 (running balance)
8080
LOG
8181

8282
it 'should correct the account balance' do

spec/support/gemfiles/Gemfile.rails-7.1.x

Lines changed: 0 additions & 10 deletions
This file was deleted.
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ source 'https://rubygems.org'
22

33
gemspec path: '../../../'
44

5-
gem 'activerecord', '~> 7.0.0'
5+
gem 'activerecord', '~> 7.2.0'
66

77
# Rails imposed database gem constraints
8-
gem 'mysql2', '~> 0.5' # https://github.com/rails/rails/blob/7-0-stable/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb#L6
9-
gem 'pg', '~> 1.1' # https://github.com/rails/rails/blob/7-0-stable/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L3
10-
gem 'sqlite3', '~> 1.4' # https://github.com/rails/rails/blob/7-0-stable/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
8+
gem 'mysql2', '~> 0.5' # https://github.com/rails/rails/blob/7-2-stable/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb#L6
9+
gem 'pg', '~> 1.1' # https://github.com/rails/rails/blob/7-2-stable/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L3
10+
gem 'sqlite3', '~> 1.4' # https://github.com/rails/rails/blob/7-2-stable/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
source 'https://rubygems.org'
2+
3+
gemspec path: '../../../'
4+
5+
gem 'activerecord', '~> 8.0.0'
6+
7+
# Rails imposed database gem constraints
8+
gem 'mysql2', '~> 0.5' # https://github.com/rails/rails/blob/8-0-stable/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb#L6
9+
gem 'pg', '~> 1.1' # https://github.com/rails/rails/blob/8-0-stable/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L3
10+
gem 'sqlite3', '>= 2.1' # https://github.com/rails/rails/blob/8-0-stable/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ source 'https://rubygems.org'
22

33
gemspec path: '../../../'
44

5-
gem 'activerecord', '~> 6.1.0'
5+
gem 'activerecord', '~> 8.1.0'
66

77
# Rails imposed database gem constraints
8-
gem 'mysql2', '~> 0.5' # https://github.com/rails/rails/blob/6-1-stable/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb#L6
9-
gem 'pg', '~> 1.1' # https://github.com/rails/rails/blob/6-1-stable/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L3
10-
gem 'sqlite3', '~> 1.4' # https://github.com/rails/rails/blob/6-1-stable/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
8+
gem 'mysql2', '~> 0.5' # https://github.com/rails/rails/blob/8-1-stable/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb#L6
9+
gem 'pg', '~> 1.1' # https://github.com/rails/rails/blob/8-1-stable/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L3
10+
gem 'sqlite3', '>= 2.1' # https://github.com/rails/rails/blob/8-1-stable/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14

spec/support/money.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
Money.locale_backend = :i18n
2+
Money.default_currency = Money::Currency.new('USD')

0 commit comments

Comments
 (0)