skip version checks on prerelease versions

Author: gtrrz-victor

cmd/entire/cli/versioncheck/versioncheck.go

@@ -223,11 +223,6 @@ func parseGitHubRelease(body []byte) (string, error) {
 // isOutdated compares current and latest versions using semantic versioning.
 // Returns true if current < latest.
 func isOutdated(current, latest string) bool {
-	// Strip git describe suffix (e.g., "v0.4.4-76-g230b49bf-dirty" → "v0.4.4").
-	// git describe appends "-N-gHASH" (and optionally "-dirty") to the tag,
-	// which semver misinterprets as a prerelease (sorting before the release).
-	current = stripGitDescribeSuffix(current)
-
 	// Ensure versions have "v" prefix for semver package
 	if !strings.HasPrefix(current, "v") {
 		current = "v" + current
@@ -236,56 +231,16 @@ func isOutdated(current, latest string) bool {
 		latest = "v" + latest
 	}
 
+	// Skip notification for prerelease versions (development builds).
+	// We don't publish prerelease versions, so these are development builds and shouldn't trigger update notifications.
+	if semver.Prerelease(current) != "" {
+		return false
+	}
+
 	// semver.Compare returns -1 if current < latest
 	return semver.Compare(current, latest) < 0
 }
 
-// stripGitDescribeSuffix removes the git describe suffix from a version string.
-// "v0.4.4-76-g230b49bf-dirty" → "v0.4.4"
-// "v0.4.4-76-g230b49bf" → "v0.4.4"
-// "v0.4.4" → "v0.4.4" (no change)
-func stripGitDescribeSuffix(version string) string {
-	// git describe format: <tag>-<N>-g<hash>[-dirty]
-	// The "-g" prefix on the hash is the distinguishing marker.
-	// Look for "-<number>-g<hex>" pattern.
-	v := version
-	if strings.HasSuffix(v, "-dirty") {
-		v = strings.TrimSuffix(v, "-dirty")
-	}
-	// Find the last "-g<hex>" segment
-	lastG := strings.LastIndex(v, "-g")
-	if lastG < 0 {
-		return version
-	}
-	// Verify the part after "-g" is hex characters (git hash)
-	hash := v[lastG+2:]
-	if len(hash) == 0 {
-		return version
-	}
-	for _, c := range hash {
-		if !((c >= '0' && c <= '9') || (c >= 'a' && c <= 'f') || (c >= 'A' && c <= 'F')) {
-			return version
-		}
-	}
-	// Now strip the "-<N>-g<hash>" part: find the dash before the commit count
-	prefix := v[:lastG]
-	lastDash := strings.LastIndex(prefix, "-")
-	if lastDash < 0 {
-		return version
-	}
-	// Verify the part between the dashes is a number (commit count)
-	count := prefix[lastDash+1:]
-	if len(count) == 0 {
-		return version
-	}
-	for _, c := range count {
-		if c < '0' || c > '9' {
-			return version
-		}
-	}
-	return prefix[:lastDash]
-}
-
 // updateCommand returns the appropriate update instruction based on how the binary was installed.
 func updateCommand() string {
 	execPath, err := os.Executable()

cmd/entire/cli/versioncheck/versioncheck_test.go

@@ -35,13 +35,13 @@ func TestIsOutdated(t *testing.T) {
 		{"1.0.0", "v1.0.1", true, "mixed v prefix reversed"},
 
 		// Pre-release versions (semver uses hyphen)
-		{"1.0.0-rc1", "1.0.0", true, "prerelease in current"},
+		{"1.0.0-rc1", "1.0.0", false, "prerelease in current"},
 		{"1.0.0", "1.0.1-rc1", true, "prerelease in latest is still newer"},
 
 		// Git describe format (should strip suffix before comparing)
 		{"v0.4.4-76-g230b49bf-dirty", "v0.4.4", false, "git describe dirty build is not outdated"},
 		{"v0.4.4-76-g230b49bf", "v0.4.4", false, "git describe build is not outdated"},
-		{"v0.4.4-76-g230b49bf-dirty", "v0.4.5", true, "git describe build outdated by newer release"},
+		{"v0.4.4-76-g230b49bf-dirty", "v0.4.5", false, "git describe build outdated by newer release"},
 		{"v0.4.4-1-gabcdef0", "v0.4.4", false, "git describe 1 commit ahead"},
 		{"v1.0.0-100-g1234567890ab-dirty", "v1.0.0", false, "git describe long hash dirty"},
 	}
@@ -56,33 +56,6 @@ func TestIsOutdated(t *testing.T) {
 	}
 }
 
-func TestStripGitDescribeSuffix(t *testing.T) {
-	tests := []struct {
-		input string
-		want  string
-	}{
-		{"v0.4.4-76-g230b49bf-dirty", "v0.4.4"},
-		{"v0.4.4-76-g230b49bf", "v0.4.4"},
-		{"v0.4.4-1-gabcdef0", "v0.4.4"},
-		{"v1.0.0-100-g1234567890ab-dirty", "v1.0.0"},
-		{"v0.4.4", "v0.4.4"},
-		{"1.0.0", "1.0.0"},
-		{"v1.0.0-rc1", "v1.0.0-rc1"},           // real prerelease, not git describe
-		{"v1.0.0-beta.1", "v1.0.0-beta.1"},     // real prerelease with dots
-		{"v1.0.0-dirty", "v1.0.0-dirty"},        // just dirty without commit info
-		{"v1.0.0-1-gXYZ", "v1.0.0-1-gXYZ"},     // non-hex hash, keep as-is
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.input, func(t *testing.T) {
-			got := stripGitDescribeSuffix(tt.input)
-			if got != tt.want {
-				t.Errorf("stripGitDescribeSuffix(%q) = %q, want %q", tt.input, got, tt.want)
-			}
-		})
-	}
-}
-
 func TestCacheReadWrite(t *testing.T) {
 	// Create a temporary directory for the test
 	tmpDir := t.TempDir()