From 136b22affa28a22345d5f4b364849237be46d5cd Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Thu, 11 Jun 2026 14:14:11 -0700 Subject: [PATCH] Require node v26 for GROWABLE_ARRAYBUFFERS feature Follow up #27103 --- .circleci/config.yml | 5 +++-- test/common.py | 8 +++----- tools/feature_matrix.py | 6 +----- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7e496f5becc1a..9a5626391a2db 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1034,8 +1034,6 @@ jobs: other.test_js_optimizer_verbose other.test_min_node_version other.test_node_emscripten_num_logical_cores - other.test_exceptions_stack_trace* - other.test_exceptions_rethrow_stack_trace* core2.test_pthread_create core2.test_i64_invoke_bigint core2.test_sse2 @@ -1060,6 +1058,9 @@ jobs: other.test_node_emscripten_num_logical_cores other.test_js_base64_api other.test_pthread_growth* + other.test_exceptions_stack_trace* + other.test_exceptions_rethrow_stack_trace* + core2.test_*exception*_wasm core2.test_hello_world core2.test_pthread_create core2.test_i64_invoke_bigint diff --git a/test/common.py b/test/common.py index 77a5ebec44c21..f442945c9113c 100644 --- a/test/common.py +++ b/test/common.py @@ -585,15 +585,14 @@ def require_wasm_legacy_eh(self): def require_wasm_eh(self): if 'EMTEST_SKIP_WASM_EH' in os.environ: - self.skipTest('test requires node v24 or d8 (and EMTEST_SKIP_WASM_EH is set)') + self.skipTest('test requires node v26 or d8 (and EMTEST_SKIP_WASM_EH is set)') self.set_setting('WASM_LEGACY_EXCEPTIONS', 0) if self.is_browser_test(): self.check_browser_feature('EMTEST_SKIP_WASM_EH', Feature.WASM_EXCEPTIONS, 'test requires Wasm EH') return - if self.try_require_node_version(22): - self.node_args.append('--experimental-wasm-exnref') + if self.try_require_node_version(26): return deno = get_deno() @@ -610,10 +609,9 @@ def require_wasm_eh(self): if v8: self.cflags.append('-sENVIRONMENT=shell') self.require_engine(v8) - self.v8_args.append('--experimental-wasm-exnref') return - self.fail('either d8, deno, bun or node v24 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip') + self.fail('either d8, deno, bun or node v26 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip') def require_jspi(self): if 'EMTEST_SKIP_JSPI' in os.environ: diff --git a/tools/feature_matrix.py b/tools/feature_matrix.py index 331c9a07424d9..9fcb899f6ec86 100644 --- a/tools/feature_matrix.py +++ b/tools/feature_matrix.py @@ -129,11 +129,7 @@ class Feature(IntEnum): 'chrome': 137, 'firefox': 131, 'safari': 180400, - # Supported with flag --experimental-wasm-exnref (TODO: Change this to - # unflagged version of Node.js 260000 that ships Wasm EH enabled, after - # Emscripten unit testing has migrated to Node.js 26, and Emsdk ships - # Node.js 26) - 'node': 220000, + 'node': 260000, }, # Growable SharedArrayBuffers improves memory growth feature in multithreaded # builds by avoiding need to poll resizes to ArrayBuffer views in Workers.