Skip to content

Commit 8393fe5

Browse files
committed
Revert "Merge pull request #49 from ember-cli/nvp/minimal-flag-non-default"
This reverts commit 87dd08b, reversing changes made to a4314a3.
1 parent 9a6987e commit 8393fe5

41 files changed

Lines changed: 986 additions & 1293 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
/node_modules/
2-
/my-app/

README.md

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -9,46 +9,3 @@ If you have an existing app that you would like to upgrade to use Vite consider
99
```
1010
pnpm dlx ember-cli@latest new my-app-name -b @ember/app-blueprint --pnpm
1111
```
12-
13-
## Options
14-
15-
### `--no-compat`
16-
17-
```
18-
pnpm dlx ember-cli@latest new my-app-name \
19-
--blueprint @ember/app-blueprint@alpha \
20-
--pnpm \
21-
--no-compat
22-
```
23-
24-
Does the following:
25-
- enables `type=module` in package.json (required for vite-ssr, and many ESM tools)
26-
- makes the build and boot _MUCH FASTER_
27-
(in large apps, this can have your app's boot be up to 1 minute faster)
28-
- removes `@embroider/compat`
29-
- removes support for:
30-
- hbs (both for component files, and testing)
31-
- content-for (in the HTML files)
32-
- v1 addons
33-
- node-land config/environment.js
34-
- removes `ember-cli`
35-
- ember-cli brings in a ton of old dependencies, so removing it makes installs much faster
36-
- downside though is that you no longer have scaffolding (`ember g`) -- however, you could use `pnpm dlx ember-cli g ...` (or `npx ember-cli g`)
37-
38-
### `--minimal`
39-
40-
```
41-
pnpm dlx ember-cli@latest new my-app-name \
42-
--blueprint @ember/app-blueprint@alpha \
43-
--pnpm \
44-
--minimal
45-
```
46-
47-
Does the following
48-
- everything listed under `--no-compat`
49-
- Removes all linting, formatting, and testing support
50-
- leaves you with a minimal app that you can use for demos, and PRing to other repositories that have multi-framework support (and probably use other testing tools for that multi-framework support)
51-
- different defaults:
52-
- warp-drive becomes _opt-in_ (pass `--warp-drive` if you want it -- normally requires `--no-warp-drive` to remove)
53-
- ember-welcome-page becomes _opt-in_ (normally requires `--no-welcome` to remove)
54-

conditional-files/minimal/app/app.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

conditional-files/minimal/app/templates/application.gts

Lines changed: 0 additions & 7 deletions
This file was deleted.

conditional-files/no-compat/_js_babel.config.mjs

Lines changed: 0 additions & 47 deletions
This file was deleted.

conditional-files/no-compat/_ts_babel.config.mjs

Lines changed: 0 additions & 55 deletions
This file was deleted.

conditional-files/no-compat/app/app.ts

Lines changed: 0 additions & 18 deletions
This file was deleted.

conditional-files/no-compat/app/config/environment.ts

Lines changed: 0 additions & 38 deletions
This file was deleted.

eslint.config.mjs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,10 @@ export default [
2626
eslintConfigPrettier,
2727
{
2828
ignores: [
29-
'my-app/**',
3029
'tests/fixtures/*',
31-
'files/vite.config.*',
3230
'files/ember-cli-build.js',
33-
'files/testem.cjs',
3431
'conditional-files/_js_*',
3532
'conditional-files/_ts_*',
36-
'conditional-files/no-compat/_js_*',
37-
'conditional-files/no-compat/_ts_*',
3833
],
3934
},
4035
];

files/app/templates/application.gts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { pageTitle } from 'ember-page-title';<% if (welcome) {%>
2-
import { WelcomePage } from 'ember-welcome-page';<% } %>
1+
import { pageTitle } from 'ember-page-title';
2+
<% if (welcome) {%>import { WelcomePage } from 'ember-welcome-page';<% } %>
33

44
<template>
55
{{pageTitle "<%= namespace %>"}}<% if (welcome) { %>

0 commit comments

Comments
 (0)