Fixed SpotBugs issues

Author: aurbroszniowski

build-logic/src/main/java/org/ehcache/build/conventions/CheckstyleConvention.java

@@ -19,5 +19,22 @@ public void apply(Project project) {
       properties.put("projectDir", project.getProjectDir());
       properties.put("rootDir", project.getRootDir());
     });
+
+    project.getConfigurations().named("checkstyle", config -> {
+      config.getResolutionStrategy().dependencySubstitution(subs -> {
+        subs.substitute(subs.module("org.codehaus.plexus:plexus-utils:3.1.1"))
+          .using(subs.module("org.codehaus.plexus:plexus-utils:3.3.0"))
+          .because("Checkstyle 10.18.1 pulls mismatched plexus-utils versions");
+        subs.substitute(subs.module("org.apache.commons:commons-lang3:3.7"))
+          .using(subs.module("org.apache.commons:commons-lang3:3.8.1"))
+          .because("Checkstyle transitives mix commons-lang3 versions");
+        subs.substitute(subs.module("org.apache.httpcomponents:httpcore:4.4.13"))
+          .using(subs.module("org.apache.httpcomponents:httpcore:4.4.14"))
+          .because("Align httpcore to latest bugfix release");
+        subs.substitute(subs.module("commons-codec:commons-codec:1.11"))
+          .using(subs.module("commons-codec:commons-codec:1.15"))
+          .because("Checkstyle transitive dependencies depend on different commons-codec versions");
+      });
+    });
   }
 }

build-logic/src/main/java/org/ehcache/build/conventions/SpotbugsConvention.java

@@ -18,6 +18,7 @@ public void apply(Project project) {
 
     spotbugs.getIgnoreFailures().set(false);
     spotbugs.getToolVersion().set("4.9.8");
+    spotbugs.getOmitVisitors().addAll("FindReturnRef", "ConstructorThrow");
 
     project.getPlugins().withType(JavaBasePlugin.class).configureEach(plugin -> {
 

clustered/ehcache-common-api/src/main/java/org/ehcache/clustered/common/internal/store/ValueWrapper.java

@@ -25,7 +25,6 @@
 /**
  * ValueWrapper
  */
-@SuppressFBWarnings("EI_EXPOSE_REP")
 public class ValueWrapper implements Serializable {
 
   private static final long serialVersionUID = -4794738044295644587L;

ehcache-impl/src/main/java/org/ehcache/config/builders/UserManagedCacheBuilder.java

@@ -121,7 +121,7 @@ public class UserManagedCacheBuilder<K, V, T extends UserManagedCache<K, V>> imp
   private boolean useValueSerializingCopier;
   private Serializer<K> keySerializer;
   private Serializer<V> valueSerializer;
-  private int dispatcherConcurrency = 4;
+  private volatile int dispatcherConcurrency = 4;
   private List<CacheEventListenerConfiguration<?>> eventListenerConfigurations = new ArrayList<>();
   private ExecutorService unOrderedExecutor;
   private ExecutorService orderedExecutor;

ehcache-impl/src/main/java/org/ehcache/impl/internal/store/tiering/TieredStore.java

@@ -222,10 +222,10 @@ private void swapCachingTiers() {
   }
 
   private void swapBackCachingTiers() {
-    if(!cachingTierRef.compareAndSet(noopCachingTier, realCachingTier)) {
-      throw new AssertionError("Something bad happened");
-    }
     synchronized (noopCachingTier) {
+      if(!cachingTierRef.compareAndSet(noopCachingTier, realCachingTier)) {
+        throw new AssertionError("Something bad happened");
+      }
       noopCachingTier.notify();
     }
   }

ehcache-impl/src/main/java/org/ehcache/impl/persistence/FileUtils.java

@@ -110,7 +110,6 @@ static boolean tryRecursiveDelete(File file) {
     }
   }
 
-  @SuppressFBWarnings("DM_GC")
   private static void gc() {
     System.gc();
     System.runFinalization();