Skip to content

Commit ad2937f

Browse files
committed
bug fixed for NewSQLVar()
1 parent 0bfa9cc commit ad2937f

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

sqlbuilder.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ func (sb *SQLBuilder) BuildUpdateSQL() *SQLBuilder {
368368
for _, set := range sb.sets {
369369
switch set.V.(type) {
370370
case SQLVar:
371-
setStr += fmt.Sprintf("%s=%s,", EscapeStr(set.K, sb.IsMysql()), EscapeStr((set.V.(SQLVar)).VarS, sb.IsMysql()))
371+
setStr += fmt.Sprintf("%s=%s,", EscapeStr(set.K, sb.IsMysql()), (set.V.(SQLVar)).VarS)
372372
case string:
373373
setStr += fmt.Sprintf("%s='%v',", EscapeStr(set.K, sb.IsMysql()), EscapeStr(set.V.(string), sb.IsMysql()))
374374
default:
@@ -406,7 +406,7 @@ func (sb *SQLBuilder) BuildInsertSQL() *SQLBuilder {
406406
for _, v := range sb.values[0] {
407407
switch v.(type) {
408408
case SQLVar:
409-
vals += fmt.Sprintf("%v,", EscapeStr(v.(SQLVar).VarS, sb.IsMysql()))
409+
vals += fmt.Sprintf("%s,", v.(SQLVar).VarS)
410410
case string:
411411
vals += fmt.Sprintf("'%v',", EscapeStr(v.(string), sb.IsMysql()))
412412
default:
@@ -443,7 +443,7 @@ func (sb *SQLBuilder) BuildBulkInsertSQL() *SQLBuilder {
443443
for _, v := range vs {
444444
switch v.(type) {
445445
case SQLVar:
446-
vals += fmt.Sprintf("%v,", EscapeStr(v.(SQLVar).VarS, sb.IsMysql()))
446+
vals += fmt.Sprintf("%s,", v.(SQLVar).VarS)
447447
case string:
448448
vals += fmt.Sprintf("'%v',", EscapeStr(v.(string), sb.IsMysql()))
449449
default:

sqlbuilder_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ func TestSQLBuilder_BuildedSQL(t *testing.T) {
6464
{
6565
name: "case 7 : Bulk INSERT",
6666
fn: func(sb *SQLBuilder) {
67-
sb.Fields("testDt", "Host", "User", "Select_priv", "testNil").Values(NewSQLVar("current_timestamp"), 1, "\"2", true, nil).Values(NewSQLVar("current_timestamp"), 2, "\"22", true, nil)
67+
sb.Fields("testDt", "Host", "User", "Select_priv", "testNil").Values(NewSQLVar("current_timestamp"), 1, "\"2", true, nil).Values(NewSQLVar("datetime('now','localtime')"), 2, "\"22", true, nil)
6868
sb.Values(NewSQLVar("current_timestamp"), 3, "\"32", false, nil).Into("user").BuildBulkInsertSQL()
6969
},
70-
wantSql: `INSERT INTO user (testDt,Host,User,Select_priv,testNil) VALUES (current_timestamp,1,'\"2',true,NULL),(current_timestamp,2,'\"22',true,NULL),(current_timestamp,3,'\"32',false,NULL)`,
70+
wantSql: `INSERT INTO user (testDt,Host,User,Select_priv,testNil) VALUES (current_timestamp,1,'\"2',true,NULL),(datetime('now','localtime'),2,'\"22',true,NULL),(current_timestamp,3,'\"32',false,NULL)`,
7171
},
7272
{
7373
name: "case 8 : Where",

0 commit comments

Comments
 (0)