Skip to content

feat: support custom proxy authorization header#6126

Open
Harshal96 wants to merge 2 commits into
eclipse-vertx:masterfrom
Harshal96:feat/issue-5129-proxy-handler
Open

feat: support custom proxy authorization header#6126
Harshal96 wants to merge 2 commits into
eclipse-vertx:masterfrom
Harshal96:feat/issue-5129-proxy-handler

Conversation

@Harshal96
Copy link
Copy Markdown

Fixes #5129.

  • Add ProxyOptions#setProxyAuthorization(...) for prebuilt proxy auth values such as Negotiate <token>.
  • Send the custom Proxy-Authorization value for plain HTTP proxy requests and HTTPS CONNECT tunneling.
  • Use Netty HttpProxyHandler outbound headers for CONNECT so non-Basic proxy schemes can be supplied by callers.
  • Include the proxy authorization value in endpoint keys to avoid sharing pooled connections across different proxy auth values.
  • Add proxy option, endpoint key, HTTP proxy, and HTTPS CONNECT coverage.

public void testHttpsProxyRequestCustomAuthorization() throws Exception {
String authorization = "Negotiate token";

server.close();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to close the server

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebClient through kerberos secured proxy is not working

2 participants