Search View: deletion of elements with millions of matches

[mehmet-karaman]

Hello,

during the task of #3735 I've observed a possible improvement regarding the navigateNext() when the "limit elements per level" is turned on (1000 elements).

Hints:

• the matches are already sorted, it should be checked if further sorting is necessary or can be removed.
• when "element per level" limit is turned on, it shouldn't be necessary to do calculations above that.

Example project:
Example.zip

Reproduction scenario:
Start file Search and search for "e", select the C.txt and remove it from the matches. It should freeze for a few minutes.

Snapshot of jvisualvm:
jvisualvm-snapshot.zip

Thank you in advance.

Best regards
Mehmet Karaman

[fedejeanne]

Hi @mehmet-karaman , would you like to provide a PR for this?

Or is this already being addressed in #3733 ?

[mehmet-karaman]

Hi @fedejeanne ,

no, its not done in #3733. The PR from #3733 is about to be merged. If I don't have any urgent tasks I would like to do this otherwise later. Anyway it can only be done after #3733 is merged, because there is the sorted matches collection which makes a huge performance improvement and this is necessary.

[fedejeanne]

Ok, thank you for the clarification 👍

I assigned the issue to you, just to signal that you would like to work on it. You can remove yourself after a while if you think you won't be able to work on it.

[mehmet-karaman]

Thank you