[BUG] - Linux regression in 3.2.12, dll override not being applied

[doogie544]

Describe the bug

When modding a game in Linux the prior version would apply the dll override winhttp (native, builtin) automatically, this is not happening with 3.2.12.

To Reproduce
Steps to reproduce the behavior:

1. Mod a game that has never been modded before or use protontrick/winetricks to remove the winhttp override and launch the modded game, the game will not launch modded as this override is required

If you use version 3.2.11the override is applied and the modded game launches, similarly if you manually add the winhttp dll override back manually it will launch with 3.2.12

Expected behavior

winhttp (native, builtin) should be applied automatically as it was previously and the modded games should just work

Additional context

I have verified this is the case multiple times with 2 games (lethal company and repo) and the results are 100% reproducible

[LostWarriorr]

I don't believe it was talked about here as much but EBKR has said that 3.2.12 will remove the automatic override and will tell the user to add one manually.
This is due to issues that have arrived from the automated process not working in certain situations I believe.

[doogie544]

I don't believe it was talked about here as much but EBKR has said that 3.2.12 will remove the automatic override and will tell the user to add one manually. This is due to issues that have arrived from the automated process not working in certain situations I believe.

That is kind of throwing the baby out with the bathwater as it works most of the time. That aside, it is not giving any type of notification (it was also not mentioned in the update notes)

For new linux users the override not happening just adds confusion and friction, a better solution might be to apply the override but also give a notification that if mods are not working to apply it manually.

In any case, I did not notice any type of a notification, unless it only happens when you add a new game, I was just testing on games I had already modded

[doogie544]

Ok so I just double checked and added a game to modman I had not had previously (ale and tale tavern, in fact I did a clean install of the game) and there was NO notification of any kind that there needed to be a dll override added

I am still inclined to believe that having it automated even if it doesn't work 100% is better than removing the automation completely. I have not seen any issues with it myself and despite being in multiple gaming centric discords I have not even seen it mentioned either, so I have to assume it only fails in specific and rare circumstances.

[ebkr]

I’ll re-add the automated application for now, but it’s odd that it didn’t ask to re-apply it.

I’ll get a release out with that fix ASAP

[doogie544]

I’ll re-add the automated application for now, but it’s odd that it didn’t ask to re-apply it.

I’ll get a release out with that fix ASAP

but it’s odd that it didn’t ask to re-apply it.

So about that. I tested it further but was unable to add a comment because it was ridiculously late by then and I had to get up so I can pretend to love my job in the morning.

I tried multiple times with the appimage version I have been using and couldn't get it to prompt to add the steam launch option.

When I try it again suddenly it's working. I have no idea why it didn't work and then suddenly decided to prompt.
The only thing I did in between was try the flatpak version which did prompt and once you added the launch option would work. Since it saves every thing in the flatpak user files I can't imagine how that would have affected the app image version or the configuration folders for that so I'm going to chalk it up to a gremlin I guess.

That does bring up a related issue however upon further testing.

When using the flatpak version of modman when you add the launch option the game launches just fine and the mods are applied.

However, when I was using the appimage if I applied the full launch option the game never launched. I had to drop the part about the mod man config and just use the dll override by itself.

I remember this happening when I first started using mod man but at the time I was also using the flatpak version of steam and so I just assumed it was related to the fact that steam was a flatpak and only use the dll override. However now I'm using the system version of steam and it still doesn't launch with the full launch option.

I suppose it is possible that it's related to my older configuration files because I didn't think to move the mod man config files so that they would be recreated and I'm not near my computer to be able to test it anytime soon.
I'm still leaning towards it being an issue with the second part of the launch option since there was no folder for ale and tale in the mod man folders at all because I had deleted all of those between tests.

I can check using completely new modman folders in .config tonight when I get home from work if you wish and can open a new issue about the launch options if you feel that's necessary, or I can include any requested information here.

I mentioned it here first because it's definitely relevant to the launch option prompt that was discussed in this report.

Just to clarify the prompted launch option when added works for the flat version of modman and if you try to remove the second part of the launch option it was not working. Conversely with the appimage version of modman adding the second part of the lunch option appears to break the game launch. (Because I was tired last night my brain wasn't working and I did not think to check a proton log to see if there was an error as to why the game was not launching or if it was just indefinitely hanging waiting for something to complete)

[ebkr]

@doogie544 So they're actually different launch arguments used between the Flatpak and the AppImage.

The reason you were prompted on the Flatpak switch was because it uses web_start_wrapper.sh instead of linux_wrapper.sh. The prompt doesn't happen because it checks your existing launch args, and if the second part is the same (in your case, linux_wrapper.sh was set) then it assumes you've launched before and that the automation was already applied

In theory, re-applying the AppImage arguments that you'll be re-prompted to use when you switch back will give you the correct commands and show the environment variable override too.

I have the fix merged for the automated part revert, I'm just holding out on a release to cover any other bug fixes that'll be done. There will be a release later today though.

[doogie544]

@ebkr

I didn't word that clearly enough I guess. Sorry for the confusion.

Just to clear up the confusion I did not try to reuse the launch option between the flat and the app image,

I used the copy function in modman to directly copy the launch option given and then pasted it into the steam launch option box. I also between tests of the two completely uninstalled the game so there was not even a residual prefix. Uninstalling was really Overkill, just deleting the prefix would have worked but it's not that large of a game and I have a fast internet connection so I was overdoing the test rather than manually deleting the prefix

With the app image using the wrapper part of the argument it would appear that it never got as far as launching anything since the console window that comes up during the loading of mods did not even show up.

I guess it's possible this is a me issue since I've been using modman for a while and I could be having old configs interfering with the wrapper part of the launch option working. As I said I was so tired last night I didn't think about completely removing all the configuration files for mod man and trying again completely clean to see if the complete launch option in the front work with the app image

[ebkr]

@doogie544 Can I verify that the latest release has solved it for you?

[doogie544]

@ebkr

Yes the winedll override is being applied automatically to the prefix again.