Pr comments first batch

Author: damskii9992

src/easyimaging/measurement/regions.py

@@ -197,6 +197,9 @@ def y_end(self, value: sc.Variable):
         self._y_end = value
 
     def _check_input_sequence(self, value: Sequence, name: str, typename: str, expected_type: any) -> None:
+        """
+        Check if the input value is a sequence of the expected type and length.
+        """
         if not isinstance(value, Sequence) or len(value) != 2:
             raise TypeError(f'{name} must be a tuple or a list of two {typename}, got a {type(value).__name__}.')
         if not (isinstance(value[0], expected_type) and isinstance(value[1], expected_type)):
@@ -206,12 +209,18 @@ def _check_input_sequence(self, value: Sequence, name: str, typename: str, expec
             )
 
     def _check_index(self, value: int, name: str) -> None:
+        """
+        Check if the input value is a valid index (non-negative integer).
+        """
         if not isinstance(value, int):
             raise TypeError(f'{name} indice must be an integer.')
         if value < 0:
             raise ValueError(f'{name} indice must be non-negative.')
 
     def _check_scalar(self, value: sc.Variable, name: str) -> None:
+        """
+        Check if the input value is a scipp scalar with a unit of length.
+        """
         if value.dims:
             raise ValueError(f'{name} must be a scipp scalar (0-dimensional Variable).')
         try:
@@ -221,6 +230,9 @@ def _check_scalar(self, value: sc.Variable, name: str) -> None:
             raise UnitError(f"{name} must be a scipp scalar with a unit of length (e.g., 'm').") from e
 
     def _single_coord_setter_check(self, value: sc.Variable, name: str) -> None:
+        """
+        Check if the input value is a scipp scalar and if physical coordinates are set.
+        """
         if not isinstance(value, sc.Variable):
             raise TypeError(f'{name} must be a scipp scalar.')
         if not self._has_physical_coords:

tests/unit_tests/measurement/test_measurement.py

@@ -1,3 +1,4 @@
+from copy import copy
 from pathlib import Path
 from typing import MutableSequence
 
@@ -466,7 +467,7 @@ def test_positions_setter_invalid(self, valid_data_array_no_xy_coords, coordinat
         with pytest.raises(ValueError, match=f'Cannot set {coordinate} before setting all physical coordinate positions.'):
             setattr(measurement, coordinate, sc.arange('x', 0, 10, 1, unit='m'))
 
-    # Just a single test, other test-cases is covered by from_tiff_stack tests as both uses _validate_provided_coord()
+    # Just a single test, other test-cases are covered by from_tiff_stack tests as both use _validate_provided_coord()
     @pytest.mark.parametrize('coordinate', ['x_positions', 'y_positions'], ids=['x_coordinate', 'y_coordinate'])
     def test_positions_setter_invalid_coordinate(self, valid_data_array, coordinate):
         # When
@@ -489,7 +490,7 @@ def test_set_physical_coord_positions_valid(self, valid_data_array_no_xy_coords)
         assert sc.identical(measurement._data_array.coords['y'], new_y_positions)
         assert measurement._has_physical_coords
 
-    # Just a single test for each, other test-cases is covered by from_tiff_stack tests as both uses _validate_provided_coord()
+    # Just a single test for each, other test-cases are covered by from_tiff_stack tests as both use _validate_provided_coord()
     @pytest.mark.parametrize(
         'coordinates, coordinate_wrong',
         [
@@ -587,12 +588,15 @@ def test_regions_of_interest(self, valid_data_array, valid_roi):
     def test_regions_of_interest_removal_by_index(self, valid_data_array, valid_roi):
         # When
         measurement = Measurement(data_array=valid_data_array)
+        extra_roi = copy(valid_roi)
         measurement.regions_of_interest.append(valid_roi)
+        measurement.regions_of_interest.append(extra_roi)  # Add a second ROI to ensure only the correct one is removed
         # Then
         del measurement.regions_of_interest[0]
         # Expect
-        assert len(measurement.regions_of_interest) == 0
+        assert len(measurement.regions_of_interest) == 1
         assert valid_roi not in measurement.regions_of_interest
+        assert extra_roi in measurement.regions_of_interest
 
     def test_regions_of_interest_removal_by_name(self, valid_data_array, valid_roi):
         # When