Skip to content

Commit aba180e

Browse files
committed
ruff check + format. Finally
1 parent 21625c5 commit aba180e

11 files changed

Lines changed: 153 additions & 153 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
from .py_backend import PyBackend
22

3-
__all__ = [PyBackend]
3+
__all__ = [PyBackend]

EasyReflectometryApp/Backends/Py/analysis.py

Lines changed: 28 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,9 @@ def prefitCheck(self) -> bool:
113113
if param['min'] >= param['max']:
114114
QtWidgets.QMessageBox.warning(
115115
None,
116-
"Invalid Parameter Bounds",
116+
'Invalid Parameter Bounds',
117117
f"Parameter '{param['name']}' has invalid bounds: "
118-
f"min ({param['min']}) must be less than max ({param['max']})."
118+
f'min ({param["min"]}) must be less than max ({param["max"]}).',
119119
)
120120
return False
121121

@@ -132,9 +132,8 @@ def prefitCheck(self) -> bool:
132132
# Show a warning in a message box
133133
QtWidgets.QMessageBox.warning(
134134
None,
135-
"Invalid Parameter Bounds",
136-
f"Parameters {joined} have infinite bounds, "
137-
"which is not allowed for differential evolution minimizer."
135+
'Invalid Parameter Bounds',
136+
f'Parameters {joined} have infinite bounds, which is not allowed for differential evolution minimizer.',
138137
)
139138

140139
return False
@@ -231,7 +230,7 @@ def removeExperiment(self, index: int) -> None:
231230
self.experimentsChanged.emit()
232231
self.externalExperimentChanged.emit()
233232
else:
234-
print(f"Experiment index {index} is out of range.")
233+
print(f'Experiment index {index} is out of range.')
235234

236235
########################
237236
## Multi-experiment selection support
@@ -294,7 +293,7 @@ def get_concatenated_experiment_data(self):
294293
all_ye.extend(data.ye if hasattr(data, 'ye') and data.ye.size > 0 else np.zeros_like(data.y))
295294
all_xe.extend(data.xe if hasattr(data, 'xe') and data.xe.size > 0 else np.zeros_like(data.x))
296295
except (IndexError, AttributeError) as e:
297-
print(f"Error accessing experiment {exp_idx}: {e}")
296+
print(f'Error accessing experiment {exp_idx}: {e}')
298297
continue
299298

300299
if not all_x:
@@ -306,16 +305,15 @@ def get_concatenated_experiment_data(self):
306305

307306
x_sorted, y_sorted, ye_sorted, xe_sorted = zip(*combined_data) if combined_data else ([], [], [], [])
308307

309-
exp_names = [self._experiments_logic.available()[i]
310-
for i in self._selected_experiment_indices if i < len(self._experiments_logic.available())]
311-
combined_name = f"Combined: {', '.join(exp_names)}"
308+
exp_names = [
309+
self._experiments_logic.available()[i]
310+
for i in self._selected_experiment_indices
311+
if i < len(self._experiments_logic.available())
312+
]
313+
combined_name = f'Combined: {", ".join(exp_names)}'
312314

313315
return DataSet1D(
314-
name=combined_name,
315-
x=np.array(x_sorted),
316-
y=np.array(y_sorted),
317-
ye=np.array(ye_sorted),
318-
xe=np.array(xe_sorted)
316+
name=combined_name, x=np.array(x_sorted), y=np.array(y_sorted), ye=np.array(ye_sorted), xe=np.array(xe_sorted)
319317
)
320318

321319
def get_individual_experiment_data_list(self):
@@ -340,25 +338,23 @@ def get_individual_experiment_data_list(self):
340338
'#e377c2', # Pink
341339
'#7f7f7f', # Gray
342340
'#bcbd22', # Olive
343-
'#17becf' # Cyan
341+
'#17becf', # Cyan
344342
]
345343

346344
for idx, exp_idx in enumerate(self._selected_experiment_indices):
347345
try:
348346
data = self._experiments_logic._project_lib.experimental_data_for_model_at_index(exp_idx)
349347
if data.x.size > 0: # Only include non-empty datasets
350-
exp_name = self._experiments_logic.available()[exp_idx] if \
351-
exp_idx < len(self._experiments_logic.available()) else f"Experiment {exp_idx + 1}"
348+
exp_name = (
349+
self._experiments_logic.available()[exp_idx]
350+
if exp_idx < len(self._experiments_logic.available())
351+
else f'Experiment {exp_idx + 1}'
352+
)
352353
color = color_palette[idx % len(color_palette)]
353354

354-
experiment_data_list.append({
355-
'data': data,
356-
'name': exp_name,
357-
'color': color,
358-
'index': exp_idx
359-
})
355+
experiment_data_list.append({'data': data, 'name': exp_name, 'color': color, 'index': exp_idx})
360356
except (IndexError, AttributeError) as e:
361-
print(f"Error accessing experiment {exp_idx}: {e}")
357+
print(f'Error accessing experiment {exp_idx}: {e}')
362358
continue
363359

364360
return experiment_data_list
@@ -373,16 +369,16 @@ def _refresh_plotting_system(self) -> None:
373369
try:
374370
if hasattr(self.parent(), '_plotting_1d'):
375371
plotting = self.parent()._plotting_1d
376-
print("📊 Refreshing plotting system...")
377-
print(f" Current selection: {self._selected_experiment_indices}")
372+
print('📊 Refreshing plotting system...')
373+
print(f' Current selection: {self._selected_experiment_indices}')
378374

379375
# Emit signals to refresh experiment data and ranges
380376
plotting.experimentDataChanged.emit()
381377
plotting.experimentChartRangesChanged.emit()
382378
plotting.refreshExperimentPage()
383379
plotting.refreshExperimentRanges()
384380
except Exception as e:
385-
print(f"❌ Error refreshing plotting system: {e}")
381+
print(f'❌ Error refreshing plotting system: {e}')
386382

387383
########################
388384
## Minimizers
@@ -431,14 +427,14 @@ def enabledParameters(self) -> list[dict[str]]:
431427
if self._chached_enabled_parameters is not None:
432428
return self._chached_enabled_parameters
433429
enabled_parameters = []
434-
#import time
435-
#t0 = time.time()
430+
# import time
431+
# t0 = time.time()
436432
for parameter in self._parameters_logic.parameters:
437433
if not parameter['enabled']:
438434
continue
439435
enabled_parameters.append(parameter)
440-
#t1 = time.time()
441-
#print(f"Enabled parameters computation time: {t1 - t0:.4f} seconds")
436+
# t1 = time.time()
437+
# print(f"Enabled parameters computation time: {t1 - t0:.4f} seconds")
442438
self._chached_enabled_parameters = enabled_parameters
443439
return enabled_parameters
444440

EasyReflectometryApp/Backends/Py/experiment.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,4 @@ def load(self, paths: str) -> None:
6363
self._project_logic.load_new_experiment(IO.generalizePath(path))
6464
self.experimentChanged.emit()
6565
self.externalExperimentChanged.emit()
66-
pass # debug anchor
66+
pass # debug anchor

EasyReflectometryApp/Backends/Py/logic/assemblies.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ def set_type_at_current_index(self, new_value: str) -> bool:
7272
new_assembly = Multilayer()
7373
new_assembly.layers[0].material = self._assemblies[self.index].layers.data[0].material
7474
elif new_value == 'Repeating Multi-layer':
75-
new_assembly = RepeatingMultilayer(repetitions=1,
76-
name = new_value)
75+
new_assembly = RepeatingMultilayer(repetitions=1, name=new_value)
7776
new_assembly.layers[0].material = self._assemblies[self.index].layers.data[0].material
7877
elif new_value == 'Surfactant Layer':
7978
index_air = self._project_lib.get_index_air()

EasyReflectometryApp/Backends/Py/logic/experiments.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ def set_model_on_experiment(self, new_value: int) -> None:
5757
model = models[new_value]
5858
exp.model = model
5959
except IndexError:
60-
print(f"Model index {new_value} is out of range for the current experiment.")
60+
print(f'Model index {new_value} is out of range for the current experiment.')
6161
else:
62-
print("No experiment or models available to set on the experiment.")
62+
print('No experiment or models available to set on the experiment.')
6363
pass
6464

6565
def remove_experiment(self, index: int) -> None:
@@ -70,11 +70,8 @@ def remove_experiment(self, index: int) -> None:
7070
del self._project_lib._experiments[index]
7171
# readjust the dictionary keys for continuity
7272
temp_experiments = self._project_lib._experiments.copy()
73-
self._project_lib._experiments = {
74-
i: exp for i, exp in enumerate(temp_experiments.values())
75-
}
73+
self._project_lib._experiments = {i: exp for i, exp in enumerate(temp_experiments.values())}
7674
if self._project_lib._current_experiment_index >= index:
77-
self._project_lib._current_experiment_index = \
78-
max(0, self._project_lib._current_experiment_index - 1)
75+
self._project_lib._current_experiment_index = max(0, self._project_lib._current_experiment_index - 1)
7976
else:
80-
print(f"Experiment index {index} is out of range.")
77+
print(f'Experiment index {index} is out of range.')

EasyReflectometryApp/Backends/Py/logic/helpers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
# SPDX-License-Identifier: BSD-3-Clause
33
# © 2025 Contributors to the EasyApp project <https://github.com/easyscience/EasyApp>
44

5-
class IO:
65

6+
class IO:
77
@staticmethod
88
def formatMsg(type, *args):
99
types = {'main': '*', 'sub': ' -'}
1010
mark = types[type]
11-
widths = [22,21,20,10]
11+
widths = [22, 21, 20, 10]
1212
widths[0] -= len(mark)
1313
msgs = []
1414
for idx, arg in enumerate(args):

EasyReflectometryApp/Backends/Py/logic/parameters.py

Lines changed: 40 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,21 @@ def as_status_string(self) -> str:
2323

2424
@property
2525
def parameters(self) -> list[dict[str, Any]]:
26-
return _from_parameters_to_list_of_dicts(
27-
self._project_lib.parameters, self._project_lib._models
28-
)
26+
return _from_parameters_to_list_of_dicts(self._project_lib.parameters, self._project_lib._models)
2927

3028
def constraint_context(self) -> list[dict[str, Any]]:
3129
parameter_snapshot = self.parameters
3230
context: list[dict[str, Any]] = []
3331
for parameter in parameter_snapshot:
34-
context.append({
35-
'alias': parameter['alias'],
36-
'display_name': parameter['display_name'],
37-
'group': parameter.get('group', ''),
38-
'independent': parameter['independent'],
39-
'object': parameter['object'],
40-
})
32+
context.append(
33+
{
34+
'alias': parameter['alias'],
35+
'display_name': parameter['display_name'],
36+
'group': parameter.get('group', ''),
37+
'independent': parameter['independent'],
38+
'object': parameter['object'],
39+
}
40+
)
4141
return context
4242

4343
def constraint_metadata(self) -> list[dict[str, Any]]:
@@ -47,12 +47,14 @@ def constraint_metadata(self) -> list[dict[str, Any]]:
4747
# Include ALL parameters (both independent and dependent) for constraint expressions
4848
# if not entry['independent']:
4949
# continue
50-
metadata.append({
51-
'alias': entry['alias'],
52-
'displayName': entry['display_name'],
53-
'group': entry.get('group', ''),
54-
'independent': entry['independent'],
55-
})
50+
metadata.append(
51+
{
52+
'alias': entry['alias'],
53+
'displayName': entry['display_name'],
54+
'group': entry.get('group', ''),
55+
'independent': entry['independent'],
56+
}
57+
)
5658
metadata.sort(key=lambda item: item['displayName'])
5759
return metadata
5860

@@ -147,7 +149,8 @@ def add_constraint(
147149

148150
if arithmetic_operator != '' and independent_idx > -1:
149151
dependent.make_dependent_on(
150-
dependency_expression='a' + arithmetic_operator + 'b', dependency_map={'a': independent, 'b': float(value)})
152+
dependency_expression='a' + arithmetic_operator + 'b', dependency_map={'a': independent, 'b': float(value)}
153+
)
151154
elif arithmetic_operator == '' and independent_idx == -1:
152155
relational_operator = relational_operator.replace('=', '==')
153156
relational_operator = relational_operator.replace('&lt', '>')
@@ -160,6 +163,7 @@ def add_constraint(
160163

161164
print(f'{dependent_idx}, {relational_operator}, {value}, {arithmetic_operator}, {independent_idx}')
162165

166+
163167
def _from_parameters_to_list_of_dicts(parameters: List[Parameter], models) -> list[dict[str, Any]]:
164168
"""Convert parameters to list of dictionaries with simplified logic.
165169
@@ -245,22 +249,24 @@ def _is_layer_parameter(param: Parameter) -> bool:
245249
prefixed_display_name = display_name
246250

247251
alias = _make_alias(prefixed_display_name or parameter.name)
248-
parameter_list.append({
249-
'name': prefixed_display_name,
250-
'display_name': prefixed_display_name,
251-
'group': group_name,
252-
'alias': alias,
253-
'unique_name': parameter.unique_name,
254-
'value': float(parameter.value),
255-
'error': float(parameter.variance),
256-
'max': float(parameter.max),
257-
'min': float(parameter.min),
258-
'units': parameter.unit,
259-
'fit': parameter.free,
260-
'independent': parameter.independent,
261-
'dependency': _get_dependency_expression(parameter, model_unique_name),
262-
'enabled': parameter.enabled if hasattr(parameter, 'enabled') else True,
263-
'object': parameter, # Direct reference to the Parameter object
264-
})
252+
parameter_list.append(
253+
{
254+
'name': prefixed_display_name,
255+
'display_name': prefixed_display_name,
256+
'group': group_name,
257+
'alias': alias,
258+
'unique_name': parameter.unique_name,
259+
'value': float(parameter.value),
260+
'error': float(parameter.variance),
261+
'max': float(parameter.max),
262+
'min': float(parameter.min),
263+
'units': parameter.unit,
264+
'fit': parameter.free,
265+
'independent': parameter.independent,
266+
'dependency': _get_dependency_expression(parameter, model_unique_name),
267+
'enabled': parameter.enabled if hasattr(parameter, 'enabled') else True,
268+
'object': parameter, # Direct reference to the Parameter object
269+
}
270+
)
265271

266272
return parameter_list

0 commit comments

Comments
 (0)