From 0481afe555489e135e485fdf747c26ed2eea0c19 Mon Sep 17 00:00:00 2001 From: Aaron Sky Date: Tue, 19 May 2026 18:58:27 -0400 Subject: [PATCH 1/2] Remove secrets from GitHub Actions Per internal discussions, we are removing secure strings from GitHub Actions to align with our internal secret management policies. This changes the CI to build-only mode for the tests. Given this repo is effectively frozen, we'll have to make do with the minimal verification case. --- .github/workflows/ci.yml | 42 +++---------------- .../xcschemes/TestSwiftyDropbox_iOS.xcscheme | 42 ------------------- .../TestSwiftyDropbox_macOS.xcscheme | 42 ------------------- 3 files changed, 5 insertions(+), 121 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 02bc4601..0b7209cc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,49 +16,17 @@ jobs: pod install --repo-update - name: Test iOS env: - FULL_DROPBOX_API_APP_KEY: ${{ secrets.FULL_DROPBOX_API_APP_KEY }} - FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN }} - FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN }} - TEAM_MEMBER_EMAIL: ${{ secrets.TEAM_MEMBER_EMAIL }} - EMAIL_TO_ADD_AS_TEAM_MEMBER: ${{ secrets.EMAIL_TO_ADD_AS_TEAM_MEMBER }} - ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }} - ACCOUNT_ID_2: ${{ secrets.ACCOUNT_ID_2 }} - ACCOUNT_ID_3: ${{ secrets.ACCOUNT_ID_3 }} - platform: ${{ 'iOS Simulator' }} - device: ${{ 'iPhone 16' }} + platform: 'iOS Simulator' + device: 'iPhone 16' run: | xcodebuild -workspace TestSwiftyDropbox/TestSwiftyDropbox.xcworkspace/ -scheme TestSwiftyDropbox_iOS -sdk iphonesimulator \ -destination "platform=$platform,name=$device" \ - FULL_DROPBOX_API_APP_KEY=$FULL_DROPBOX_API_APP_KEY \ - FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN \ - FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN \ - TEAM_MEMBER_EMAIL=$TEAM_MEMBER_EMAIL \ - EMAIL_TO_ADD_AS_TEAM_MEMBER=$EMAIL_TO_ADD_AS_TEAM_MEMBER \ - ACCOUNT_ID=$ACCOUNT_ID \ - ACCOUNT_ID_2=$ACCOUNT_ID_2 \ - ACCOUNT_ID_3=$ACCOUNT_ID_3 \ - test + build-without-testing - name: Test macOS env: - FULL_DROPBOX_API_APP_KEY: ${{ secrets.FULL_DROPBOX_API_APP_KEY }} - FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN }} - FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN: ${{ secrets.FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN }} - TEAM_MEMBER_EMAIL: ${{ secrets.TEAM_MEMBER_EMAIL }} - EMAIL_TO_ADD_AS_TEAM_MEMBER: ${{ secrets.EMAIL_TO_ADD_AS_TEAM_MEMBER }} - ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }} - ACCOUNT_ID_2: ${{ secrets.ACCOUNT_ID_2 }} - ACCOUNT_ID_3: ${{ secrets.ACCOUNT_ID_3 }} - platform: ${{ 'macOS' }} + platform: macOS run: | xcodebuild -workspace TestSwiftyDropbox/TestSwiftyDropbox.xcworkspace/ -scheme TestSwiftyDropbox_macOS \ -destination "platform=$platform,arch=x86_64" \ - FULL_DROPBOX_API_APP_KEY=$FULL_DROPBOX_API_APP_KEY \ - FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_TEAM_REFRESH_TOKEN \ - FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN=$FULL_DROPBOX_TESTER_USER_REFRESH_TOKEN \ - TEAM_MEMBER_EMAIL=$TEAM_MEMBER_EMAIL \ - EMAIL_TO_ADD_AS_TEAM_MEMBER=$EMAIL_TO_ADD_AS_TEAM_MEMBER \ - ACCOUNT_ID=$ACCOUNT_ID \ - ACCOUNT_ID_2=$ACCOUNT_ID_2 \ - ACCOUNT_ID_3=$ACCOUNT_ID_3 \ - test + build-without-testing diff --git a/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_iOS.xcscheme b/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_iOS.xcscheme index bc282335..9f107729 100644 --- a/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_iOS.xcscheme +++ b/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_iOS.xcscheme @@ -36,48 +36,6 @@ ReferencedContainer = "container:TestSwiftyDropbox.xcodeproj"> - - - - - - - - - - - - - - - - - - diff --git a/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_macOS.xcscheme b/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_macOS.xcscheme index a493c0a5..681c7cf4 100644 --- a/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_macOS.xcscheme +++ b/TestSwiftyDropbox/TestSwiftyDropbox.xcodeproj/xcshareddata/xcschemes/TestSwiftyDropbox_macOS.xcscheme @@ -36,48 +36,6 @@ ReferencedContainer = "container:TestSwiftyDropbox.xcodeproj"> - - - - - - - - - - - - - - - - - - From 4724a941efde843c7f2cf6ecfa855734774c5f00 Mon Sep 17 00:00:00 2001 From: Aaron Sky Date: Tue, 19 May 2026 19:00:05 -0400 Subject: [PATCH 2/2] Update ci.yml --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0b7209cc..f0ea4818 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,7 @@ jobs: run: | xcodebuild -workspace TestSwiftyDropbox/TestSwiftyDropbox.xcworkspace/ -scheme TestSwiftyDropbox_iOS -sdk iphonesimulator \ -destination "platform=$platform,name=$device" \ - build-without-testing + build-for-testing - name: Test macOS env: @@ -29,4 +29,4 @@ jobs: run: | xcodebuild -workspace TestSwiftyDropbox/TestSwiftyDropbox.xcworkspace/ -scheme TestSwiftyDropbox_macOS \ -destination "platform=$platform,arch=x86_64" \ - build-without-testing + build-for-testing