Skip to content

Commit 640e746

Browse files
authored
Switch a few more old->new kafka.protocol imports (#2771)
1 parent b7a13a8 commit 640e746

4 files changed

Lines changed: 6 additions & 7 deletions

File tree

kafka/admin/client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,8 @@
2323
CreateTopicsRequest, DeleteTopicsRequest, DescribeConfigsRequest, AlterConfigsRequest, CreatePartitionsRequest,
2424
ListGroupsRequest, DescribeGroupsRequest, DescribeAclsRequest, CreateAclsRequest, DeleteAclsRequest,
2525
DeleteGroupsRequest, DeleteRecordsRequest, DescribeLogDirsRequest, ElectLeadersRequest, ElectionType)
26-
from kafka.protocol.commit import OffsetFetchRequest
26+
from kafka.protocol.new.consumer import OffsetFetchRequest
2727
from kafka.protocol.new.metadata import MetadataRequest, FindCoordinatorRequest
28-
from kafka.protocol.types import Array
2928
from kafka.structs import TopicPartition, OffsetAndMetadata, MemberInformation, GroupInformation
3029
from kafka.version import __version__
3130

test/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def conn(mocker):
1717
"""Return a connection mocker fixture"""
1818
from kafka.conn import ConnectionStates
1919
from kafka.future import Future
20-
from kafka.protocol.metadata import MetadataResponse
20+
from kafka.protocol.new.metadata import MetadataResponse
2121
conn = mocker.patch('kafka.client_async.BrokerConnection')
2222
conn.return_value = conn
2323
conn.state = ConnectionStates.CONNECTED

test/integration/fixtures.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313

1414
from kafka import errors, KafkaAdminClient, KafkaClient, KafkaConsumer, KafkaProducer
1515
from kafka.errors import InvalidReplicationFactorError, KafkaTimeoutError
16-
from kafka.protocol.admin import CreateTopicsRequest
17-
from kafka.protocol.metadata import MetadataRequest
16+
from kafka.protocol.new.admin import CreateTopicsRequest
17+
from kafka.protocol.new.metadata import MetadataRequest
1818
from test.testutil import env_kafka_version, random_string
1919
from test.service import ExternalService, SpawnedService
2020

test/integration/test_sasl_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pytest
66

77
from kafka.admin import NewTopic
8-
from kafka.protocol.metadata import MetadataRequest_v1
8+
from kafka.protocol.new.metadata import MetadataRequest
99
from test.testutil import assert_message_count, env_kafka_version, random_string, special_to_underscore
1010

1111

@@ -69,7 +69,7 @@ def test_client(request, sasl_kafka):
6969
sasl_kafka.create_topics([topic_name], num_partitions=1)
7070

7171
client, = sasl_kafka.get_clients(1)
72-
request = MetadataRequest_v1(None)
72+
request = MetadataRequest(topics=None, version=1)
7373
timeout_at = time.time() + 1
7474
while not client.is_ready(0):
7575
client.maybe_connect(0)

0 commit comments

Comments
 (0)