Set default cli log level => CRITICAL (#2760)

Author: dpkp

kafka/cli/admin/__init__.py

@@ -22,7 +22,7 @@ def main_parser():
         '-c', '--extra-config', type=str, action='append',
         help='additional configuration properties for admin client')
     parser.add_argument(
-        '-l', '--log-level', type=str,
+        '-l', '--log-level', type=str, default='CRITICAL',
         help='logging level, passed to logging.basicConfig')
     parser.add_argument(
         '-f', '--format', type=str, default='raw',
@@ -74,11 +74,8 @@ def run_cli(args=None):
         elif config.format == 'json':
             print(json.dumps(result))
         return 0
-    except AttributeError:
-        parser.print_help()
-        return 2
     except Exception:
-        logger.exception('Error!')
+        logger.critical('Error!', exc_info=True)
         return 1
 
 

kafka/cli/consumer/__init__.py

@@ -23,7 +23,7 @@ def main_parser():
         '-c', '--extra-config', type=str, action='append',
         help='additional configuration properties for kafka consumer')
     parser.add_argument(
-        '-l', '--log-level', type=str,
+        '-l', '--log-level', type=str, default='CRITICAL',
         help='logging level, passed to logging.basicConfig')
     parser.add_argument(
         '-f', '--format', type=str, default='str',
@@ -77,11 +77,8 @@ def run_cli(args=None):
     except KeyboardInterrupt:
         logger.info('Bye!')
         return 0
-    except KafkaError as e:
-        logger.error(e)
-        return 1
     except Exception:
-        logger.exception('Error!')
+        logger.critical('Error!', exc_info=True)
         return 1
     finally:
         consumer.close()

kafka/cli/producer/__init__.py

@@ -20,7 +20,7 @@ def main_parser():
         '-c', '--extra-config', type=str, action='append',
         help='additional configuration properties for kafka producer')
     parser.add_argument(
-        '-l', '--log-level', type=str,
+        '-l', '--log-level', type=str, default='CRITICAL',
         help='logging level, passed to logging.basicConfig')
     parser.add_argument(
         '--encoding', type=str, default='utf-8',
@@ -78,7 +78,7 @@ def log_result(res_or_err):
         logger.info('Bye!')
         return 0
     except Exception:
-        logger.exception('Error!')
+        logger.critical('Error!', exc_info=True)
         return 1
     finally:
         producer.close()