JIT: Normalize switch so it gets collapse into range check#128524
Open
BoyBaykiller wants to merge 2 commits into
Open
JIT: Normalize switch so it gets collapse into range check#128524BoyBaykiller wants to merge 2 commits into
BoyBaykiller wants to merge 2 commits into
Conversation
…t will be collapsed to range check by later phase (Optimize pre-layout)
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
BoyBaykiller
commented
May 23, 2026
| { | ||
| switchValue = | ||
| gtNewOperNode(GT_SUB, switchValue->TypeGet(), switchValue, gtNewIconNode(minValue, switchValue->TypeGet())); | ||
| if (minValue != 0) |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, this identity check is needed as nothing after "recognize switch" phase optimizes out the SUB(x, 0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current switch normalization logic (inserting GT_SUB) is purely correctness driven to fit the jump table. Consider (with #128515):
Test1would be normalized by switch-recognition because it has numbers larger thanSWITCH_MAX_DISTANCEwhileTest2wouldn't. This difference would lead to one being collapsed into range-check while the other wouldn't:Here I am just adding an additional check to normalize the switch whenever the numbers form a continous range which fixes that.