From 22486d0ac40f7af5c9a38fbd55ead6f150f95302 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 25 Feb 2026 06:01:45 +0000 Subject: [PATCH 1/4] Initial plan From 568593c7e7d9e56c91fb6715dc462bda82d3cea6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 25 Feb 2026 06:08:54 +0000 Subject: [PATCH 2/4] Disable FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories on OSX with crossgen Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com> --- .../Common/tests/TestUtilities/System/PlatformDetection.cs | 1 + .../tests/FileSystemWatcher.SymbolicLink.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs index 6d3d4a65d05919..22916ad1eefe19 100644 --- a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs +++ b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs @@ -247,6 +247,7 @@ private static bool GetLinqExpressionsBuiltWithIsInterpretingOnly() public static bool IsSingleFile => !HasAssemblyFiles; public static bool IsReadyToRunCompiled => Environment.GetEnvironmentVariable("TEST_READY_TO_RUN_MODE") == "1"; + public static bool IsOSXAndReadyToRunCompiled => IsOSX && IsReadyToRunCompiled; private static volatile Tuple s_lazyNonZeroLowerBoundArraySupported; public static bool IsNonZeroLowerBoundArraySupported diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs index 20ef67a0a6ada6..750d02e7544c12 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs @@ -79,6 +79,7 @@ public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/124847", typeof(PlatformDetection), nameof(PlatformDetection.IsOSXAndReadyToRunCompiled))] [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories() { From 7dc15e576d598334e147f8ac6d661ad876fc049a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 25 Feb 2026 06:17:56 +0000 Subject: [PATCH 3/4] Use params ActiveIssueAttribute ctor instead of combined property Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com> --- .../Common/tests/TestUtilities/System/PlatformDetection.cs | 1 - .../tests/FileSystemWatcher.SymbolicLink.cs | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs index 22916ad1eefe19..6d3d4a65d05919 100644 --- a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs +++ b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs @@ -247,7 +247,6 @@ private static bool GetLinqExpressionsBuiltWithIsInterpretingOnly() public static bool IsSingleFile => !HasAssemblyFiles; public static bool IsReadyToRunCompiled => Environment.GetEnvironmentVariable("TEST_READY_TO_RUN_MODE") == "1"; - public static bool IsOSXAndReadyToRunCompiled => IsOSX && IsReadyToRunCompiled; private static volatile Tuple s_lazyNonZeroLowerBoundArraySupported; public static bool IsNonZeroLowerBoundArraySupported diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs index 750d02e7544c12..a48f8b0b5871eb 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs @@ -79,7 +79,7 @@ public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124847", typeof(PlatformDetection), nameof(PlatformDetection.IsOSXAndReadyToRunCompiled))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/124847", typeof(PlatformDetection), nameof(PlatformDetection.IsOSX), nameof(PlatformDetection.IsReadyToRunCompiled))] [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories() { From f0a8cb596e4fd4a4719262ebbbe4399566a80f50 Mon Sep 17 00:00:00 2001 From: Jackson Schuster <36744439+jtschuster@users.noreply.github.com> Date: Wed, 25 Feb 2026 09:33:22 -0800 Subject: [PATCH 4/4] Apply suggestion from @jtschuster --- .../tests/FileSystemWatcher.SymbolicLink.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs index a48f8b0b5871eb..9e7055aba1856f 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs @@ -79,8 +79,7 @@ public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124847", typeof(PlatformDetection), nameof(PlatformDetection.IsOSX), nameof(PlatformDetection.IsReadyToRunCompiled))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/124847")] public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories() { FileSystemWatcherTest.Execute(() =>