Skip to content

Commit 06d5e82

Browse files
svickakoeplinger
svick
and
akoeplinger
authored
Enclose keywords in quotes in logging generator messages, to improve translation quality (#124960)
Some of the Czech language translations in #124957 are quite bad. This PR updates the messages to enclose C# keywords (and similar) in single quotes, hoping this will improve translation quality. Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
1 parent b6a3e78 commit 06d5e82

14 files changed

Lines changed: 273 additions & 273 deletions

File tree

‎src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/Strings.resx‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@
136136
<value>Multiple logging methods are using event id {0} in class {1}</value>
137137
</data>
138138
<data name="LoggingMethodMustReturnVoidMessage" xml:space="preserve">
139-
<value>Logging methods must return void</value>
139+
<value>Logging methods must return 'void'</value>
140140
</data>
141141
<data name="MissingLoggerArgumentTitle" xml:space="preserve">
142142
<value>One of the arguments to a static logging method must implement the Microsoft.Extensions.Logging.ILogger interface</value>
@@ -147,13 +147,10 @@
147147
<comment>{Locked="Microsoft.Extensions.Logging.ILogger"}</comment>
148148
</data>
149149
<data name="LoggingMethodShouldBeStaticMessage" xml:space="preserve">
150-
<value>Logging methods must be static</value>
150+
<value>Logging methods must be 'static'</value>
151151
</data>
152152
<data name="LoggingMethodMustBePartialMessage" xml:space="preserve">
153-
<value>Logging methods must be partial</value>
154-
</data>
155-
<data name="LoggingMethodHasAllowsRefStructConstraintMessage" xml:space="preserve">
156-
<value>Logging methods cannot have type parameters with 'allows ref struct' constraints</value>
153+
<value>Logging methods must be 'partial'</value>
157154
</data>
158155
<data name="ShouldntMentionInTemplateMessage" xml:space="preserve">
159156
<value>Don't include a template for {0} in the logging message since it is implicitly taken care of</value>
@@ -162,7 +159,7 @@
162159
<value>Don't include exception parameters as templates in the logging message</value>
163160
</data>
164161
<data name="RedundantQualifierInMessageMessage" xml:space="preserve">
165-
<value>Remove redundant qualifier (Info:, Warning:, Error:, etc) from the logging message since it is implicit in the specified log level.</value>
162+
<value>Remove redundant qualifier ('Info:', 'Warning:', 'Error:', etc) from the logging message since it is implicit in the specified log level.</value>
166163
</data>
167164
<data name="RedundantQualifierInMessageTitle" xml:space="preserve">
168165
<value>Redundant qualifier in logging message</value>
@@ -217,10 +214,10 @@
217214
<value>Generating more than 6 arguments is not supported</value>
218215
</data>
219216
<data name="InvalidLoggingMethodParameterOutMessage" xml:space="preserve">
220-
<value>Argument '{0}' is using the unsupported out parameter modifier</value>
217+
<value>Argument '{0}' is using the unsupported 'out' parameter modifier</value>
221218
</data>
222219
<data name="InvalidLoggingMethodParameterOutTitle" xml:space="preserve">
223-
<value>Argument is using the unsupported out parameter modifier</value>
220+
<value>Argument is using the unsupported 'out' parameter modifier</value>
224221
</data>
225222
<data name="ShouldntReuseEventNamesMessage" xml:space="preserve">
226223
<value>Multiple logging methods are using event name {0} in class {1}</value>
@@ -245,16 +242,19 @@
245242
<value>Primary constructor parameter of type Microsoft.Extensions.Logging.ILogger is hidden by a field</value>
246243
<comment>{Locked="Microsoft.Extensions.Logging.ILogger"}</comment>
247244
</data>
245+
<data name="LoggingMethodHasAllowsRefStructConstraintMessage" xml:space="preserve">
246+
<value>Logging methods cannot have type parameters with 'allows ref struct' constraints</value>
247+
</data>
248248
<data name="InvalidLoggingMethodParameterParamsMessage" xml:space="preserve">
249-
<value>Argument '{0}' is using the unsupported params or scoped parameter modifier</value>
249+
<value>Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</value>
250250
</data>
251251
<data name="InvalidLoggingMethodParameterParamsTitle" xml:space="preserve">
252-
<value>Argument is using the unsupported params or scoped parameter modifier</value>
252+
<value>Argument is using the unsupported 'params' or 'scoped' parameter modifier</value>
253253
</data>
254254
<data name="InvalidLoggingMethodParameterRefStructMessage" xml:space="preserve">
255-
<value>Parameter '{0}' is a ref struct, which is not supported by the logging source generator</value>
255+
<value>Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</value>
256256
</data>
257257
<data name="InvalidLoggingMethodParameterRefStructTitle" xml:space="preserve">
258-
<value>Logging method parameter is a ref struct</value>
258+
<value>Logging method parameter is a 'ref struct'</value>
259259
</data>
260260
</root>

‎src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.cs.xlf‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@
3333
<note />
3434
</trans-unit>
3535
<trans-unit id="InvalidLoggingMethodParameterOutMessage">
36-
<source>Argument '{0}' is using the unsupported out parameter modifier</source>
37-
<target state="translated">Argument {0} používá nepodporovaný modifikátor výstupních parametrů.</target>
36+
<source>Argument '{0}' is using the unsupported 'out' parameter modifier</source>
37+
<target state="needs-review-translation">Argument {0} používá nepodporovaný modifikátor výstupních parametrů.</target>
3838
<note />
3939
</trans-unit>
4040
<trans-unit id="InvalidLoggingMethodParameterOutTitle">
41-
<source>Argument is using the unsupported out parameter modifier</source>
42-
<target state="translated">Argument používá nepodporovaný modifikátor výstupních parametrů</target>
41+
<source>Argument is using the unsupported 'out' parameter modifier</source>
42+
<target state="needs-review-translation">Argument používá nepodporovaný modifikátor výstupních parametrů</target>
4343
<note />
4444
</trans-unit>
4545
<trans-unit id="LoggingMethodHasBodyMessage">
@@ -53,18 +53,18 @@
5353
<note />
5454
</trans-unit>
5555
<trans-unit id="LoggingMethodMustBePartialMessage">
56-
<source>Logging methods must be partial</source>
57-
<target state="translated">Metody protokolování musí být částečné.</target>
56+
<source>Logging methods must be 'partial'</source>
57+
<target state="needs-review-translation">Metody protokolování musí být částečné.</target>
5858
<note />
5959
</trans-unit>
6060
<trans-unit id="LoggingMethodMustReturnVoidMessage">
61-
<source>Logging methods must return void</source>
62-
<target state="translated">Metody protokolování musí vracet void.</target>
61+
<source>Logging methods must return 'void'</source>
62+
<target state="needs-review-translation">Metody protokolování musí vracet void.</target>
6363
<note />
6464
</trans-unit>
6565
<trans-unit id="LoggingMethodShouldBeStaticMessage">
66-
<source>Logging methods must be static</source>
67-
<target state="translated">Metody protokolování musí být statické.</target>
66+
<source>Logging methods must be 'static'</source>
67+
<target state="needs-review-translation">Metody protokolování musí být statické.</target>
6868
<note />
6969
</trans-unit>
7070
<trans-unit id="LoggingUnsupportedLanguageVersionMessageFormat">
@@ -143,8 +143,8 @@
143143
<note>{Locked="Microsoft.Extensions.Logging.ILogger"}</note>
144144
</trans-unit>
145145
<trans-unit id="RedundantQualifierInMessageMessage">
146-
<source>Remove redundant qualifier (Info:, Warning:, Error:, etc) from the logging message since it is implicit in the specified log level.</source>
147-
<target state="translated">Odeberte redundantní kvalifikátor (Informace:, Upozornění:, Chyba: atd.) ze zprávy o protokolování, protože je na zadané úrovni protokolu implicitní.</target>
146+
<source>Remove redundant qualifier ('Info:', 'Warning:', 'Error:', etc) from the logging message since it is implicit in the specified log level.</source>
147+
<target state="needs-review-translation">Odeberte redundantní kvalifikátor (Informace:, Upozornění:, Chyba: atd.) ze zprávy o protokolování, protože je na zadané úrovni protokolu implicitní.</target>
148148
<note />
149149
</trans-unit>
150150
<trans-unit id="RedundantQualifierInMessageTitle">
@@ -203,23 +203,23 @@
203203
<note />
204204
</trans-unit>
205205
<trans-unit id="InvalidLoggingMethodParameterParamsMessage">
206-
<source>Argument '{0}' is using the unsupported params or scoped parameter modifier</source>
207-
<target state="translated">Argument {0} používá nepodporované parametry nebo modifikátor parametrů s vymezeným oborem</target>
206+
<source>Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</source>
207+
<target state="new">Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</target>
208208
<note />
209209
</trans-unit>
210210
<trans-unit id="InvalidLoggingMethodParameterParamsTitle">
211-
<source>Argument is using the unsupported params or scoped parameter modifier</source>
212-
<target state="translated">Argument používá nepodporované parametry nebo modifikátor parametrů s vymezeným oborem</target>
211+
<source>Argument is using the unsupported 'params' or 'scoped' parameter modifier</source>
212+
<target state="new">Argument is using the unsupported 'params' or 'scoped' parameter modifier</target>
213213
<note />
214214
</trans-unit>
215215
<trans-unit id="InvalidLoggingMethodParameterRefStructMessage">
216-
<source>Parameter '{0}' is a ref struct, which is not supported by the logging source generator</source>
217-
<target state="translated">Parametr {0} je ref stuct, což není podporováno generátorem zdroje protokolování</target>
216+
<source>Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</source>
217+
<target state="new">Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</target>
218218
<note />
219219
</trans-unit>
220220
<trans-unit id="InvalidLoggingMethodParameterRefStructTitle">
221-
<source>Logging method parameter is a ref struct</source>
222-
<target state="translated">Parametr metody protokolování je ref struct</target>
221+
<source>Logging method parameter is a 'ref struct'</source>
222+
<target state="new">Logging method parameter is a 'ref struct'</target>
223223
<note />
224224
</trans-unit>
225225
</body>

‎src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.de.xlf‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@
3333
<note />
3434
</trans-unit>
3535
<trans-unit id="InvalidLoggingMethodParameterOutMessage">
36-
<source>Argument '{0}' is using the unsupported out parameter modifier</source>
37-
<target state="translated">Das Argument „{0}“ verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
36+
<source>Argument '{0}' is using the unsupported 'out' parameter modifier</source>
37+
<target state="needs-review-translation">Das Argument „{0}“ verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
3838
<note />
3939
</trans-unit>
4040
<trans-unit id="InvalidLoggingMethodParameterOutTitle">
41-
<source>Argument is using the unsupported out parameter modifier</source>
42-
<target state="translated">Das Argument verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
41+
<source>Argument is using the unsupported 'out' parameter modifier</source>
42+
<target state="needs-review-translation">Das Argument verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
4343
<note />
4444
</trans-unit>
4545
<trans-unit id="LoggingMethodHasBodyMessage">
@@ -53,18 +53,18 @@
5353
<note />
5454
</trans-unit>
5555
<trans-unit id="LoggingMethodMustBePartialMessage">
56-
<source>Logging methods must be partial</source>
57-
<target state="translated">Protokollierungsmethoden müssen partiell sein.</target>
56+
<source>Logging methods must be 'partial'</source>
57+
<target state="needs-review-translation">Protokollierungsmethoden müssen partiell sein.</target>
5858
<note />
5959
</trans-unit>
6060
<trans-unit id="LoggingMethodMustReturnVoidMessage">
61-
<source>Logging methods must return void</source>
62-
<target state="translated">Protokollierungsmethoden müssen leer zurückgegeben werden.</target>
61+
<source>Logging methods must return 'void'</source>
62+
<target state="needs-review-translation">Protokollierungsmethoden müssen leer zurückgegeben werden.</target>
6363
<note />
6464
</trans-unit>
6565
<trans-unit id="LoggingMethodShouldBeStaticMessage">
66-
<source>Logging methods must be static</source>
67-
<target state="translated">Protokollierungsmethoden müssen statisch sein.</target>
66+
<source>Logging methods must be 'static'</source>
67+
<target state="needs-review-translation">Protokollierungsmethoden müssen statisch sein.</target>
6868
<note />
6969
</trans-unit>
7070
<trans-unit id="LoggingUnsupportedLanguageVersionMessageFormat">
@@ -143,8 +143,8 @@
143143
<note>{Locked="Microsoft.Extensions.Logging.ILogger"}</note>
144144
</trans-unit>
145145
<trans-unit id="RedundantQualifierInMessageMessage">
146-
<source>Remove redundant qualifier (Info:, Warning:, Error:, etc) from the logging message since it is implicit in the specified log level.</source>
147-
<target state="translated">Entfernen Sie den redundanten Qualifizierer (z. B. "Info:", "Warnung:" oder "Fehler:") aus der Protokollierungsmeldung, weil er auf der angegebenen Protokollebene implizit enthalten ist.</target>
146+
<source>Remove redundant qualifier ('Info:', 'Warning:', 'Error:', etc) from the logging message since it is implicit in the specified log level.</source>
147+
<target state="needs-review-translation">Entfernen Sie den redundanten Qualifizierer (z. B. "Info:", "Warnung:" oder "Fehler:") aus der Protokollierungsmeldung, weil er auf der angegebenen Protokollebene implizit enthalten ist.</target>
148148
<note />
149149
</trans-unit>
150150
<trans-unit id="RedundantQualifierInMessageTitle">
@@ -203,23 +203,23 @@
203203
<note />
204204
</trans-unit>
205205
<trans-unit id="InvalidLoggingMethodParameterParamsMessage">
206-
<source>Argument '{0}' is using the unsupported params or scoped parameter modifier</source>
207-
<target state="translated">Das Argument „{0}“ verwendet nicht unterstützte Parameter oder bereichsbezogene Parametermodifizierer.</target>
206+
<source>Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</source>
207+
<target state="new">Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</target>
208208
<note />
209209
</trans-unit>
210210
<trans-unit id="InvalidLoggingMethodParameterParamsTitle">
211-
<source>Argument is using the unsupported params or scoped parameter modifier</source>
212-
<target state="translated">Das Argument verwendet nicht unterstützte Parameter oder bereichsbezogene Parametermodifizierer.</target>
211+
<source>Argument is using the unsupported 'params' or 'scoped' parameter modifier</source>
212+
<target state="new">Argument is using the unsupported 'params' or 'scoped' parameter modifier</target>
213213
<note />
214214
</trans-unit>
215215
<trans-unit id="InvalidLoggingMethodParameterRefStructMessage">
216-
<source>Parameter '{0}' is a ref struct, which is not supported by the logging source generator</source>
217-
<target state="translated">Der Parameter „{0}“ ist eine Referenzstruktur, die vom Protokollierungsquellgenerator nicht unterstützt wird.</target>
216+
<source>Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</source>
217+
<target state="new">Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</target>
218218
<note />
219219
</trans-unit>
220220
<trans-unit id="InvalidLoggingMethodParameterRefStructTitle">
221-
<source>Logging method parameter is a ref struct</source>
222-
<target state="translated">Der Parameter der Protokollierungsmethode ist eine Referenzstruktur.</target>
221+
<source>Logging method parameter is a 'ref struct'</source>
222+
<target state="new">Logging method parameter is a 'ref struct'</target>
223223
<note />
224224
</trans-unit>
225225
</body>

0 commit comments

Comments
 (0)