From 9199af95acc88ec98bd49b13956d5ba07fb9534d Mon Sep 17 00:00:00 2001 From: Parker Bibus Date: Mon, 16 Mar 2026 13:34:06 -0700 Subject: [PATCH] Improve argument handling in ProcessHelper and use read-only store access in CertHelper - Add -- separator to sudo invocations in RawProcessHelper and ManagedProcessHelper to properly delimit the command from sudo options - Change certificate store open from ReadWrite to ReadOnly when only reading certificates in CertHelper Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/tools/CertHelper/Program.cs | 2 +- src/tools/ScenarioMeasurement/Util/ProcessHelper.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tools/CertHelper/Program.cs b/src/tools/CertHelper/Program.cs index 2e717a7a119..33bcaf844b4 100644 --- a/src/tools/CertHelper/Program.cs +++ b/src/tools/CertHelper/Program.cs @@ -55,7 +55,7 @@ static async Task Main(string[] args) Console.Error.WriteLine(ex.StackTrace); } - using (var store = new X509Store(StoreName.My, StoreLocation.CurrentUser, OpenFlags.ReadWrite)) + using (var store = new X509Store(StoreName.My, StoreLocation.CurrentUser, OpenFlags.ReadOnly)) { foreach(var cert in store.Certificates.Find(X509FindType.FindBySubjectName, "dotnetperf.microsoft.com", false)) { diff --git a/src/tools/ScenarioMeasurement/Util/ProcessHelper.cs b/src/tools/ScenarioMeasurement/Util/ProcessHelper.cs index 7ad7b2a75d1..17ca3ac0a81 100644 --- a/src/tools/ScenarioMeasurement/Util/ProcessHelper.cs +++ b/src/tools/ScenarioMeasurement/Util/ProcessHelper.cs @@ -74,7 +74,7 @@ public Process RunWithNoExit() if (!Util.IsWindows() && RootAccess) { psi.FileName = "sudo"; - psi.Arguments = Executable + " " + Arguments; + psi.Arguments = "-- " + Executable + " " + Arguments; } else { @@ -191,7 +191,7 @@ public ProcessResult Run() if (!Util.IsWindows() && RootAccess) { psi.FileName = "sudo"; - psi.Arguments = Executable + " " + Arguments; + psi.Arguments = "-- " + Executable + " " + Arguments; } else {