Skip to content

Commit 3bf8d2f

Browse files
committed
Apply even more feedback goodness
1 parent 22022a0 commit 3bf8d2f

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

  • docs/release-notes/.FSharp.Core
  • tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control

docs/release-notes/.FSharp.Core/11.0.100.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66

77
### Added
88

9-
* Add `Async.Await`, which mirrors `Async.AwaitTask` semantics, but elides egregious `AggregateException` wrapping. Also adds an SRTP overload accepting any task-like value that supports the `GetAwaiter` protocol. ([Language Suggestion #840](https://github.com/fsharp/fslang-suggestions/issues/840), [PR #19785](https://github.com/dotnet/fsharp/pull/19785))
9+
* Add `Async.Await`, which mirrors `Async.AwaitTask` semantics, but elides egregious `AggregateException` wrapping. Includes ValueTask support, and a SRTP-based overload accepting any task-like value that supports the `GetAwaiter` protocol. ([Language Suggestion #840](https://github.com/fsharp/fslang-suggestions/issues/840), [PR #19785](https://github.com/dotnet/fsharp/pull/19785))

tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ open FSharp.Core.UnitTests.LibraryTestFx
1010
open Xunit
1111
open System.Threading
1212
open System.Threading.Tasks
13-
open Xunit.Internal
1413

1514
// Cancels default token.
1615
[<Collection(nameof FSharp.Test.NotThreadSafeResourceCollection)>]
@@ -816,12 +815,16 @@ module AsyncAwaitStackTraceTests =
816815
// regardless of which Async.Await overload is used.
817816
let checkTrace totalCount (e: exn) =
818817
let trace = e.StackTrace
818+
// stacktrace should be relatively compact and not bloat the logs, so unconditionally print it to save time analyzing regressions
819+
printfn "EDI trace ===="
820+
printfn "%s" trace
821+
printfn "==== EDI trace"
819822
Assert.NotNull(trace)
820823
Assert.Contains("throwAtLevel1", trace)
821824
Assert.Contains("level1Task", trace)
822825
Assert.Contains("level2Task", trace)
823-
#if !NETFRAMEWORK472 // downlevel has interstitial layers we are not seeking to characterize at this point
824-
Assert.True((totalCount = trace.Split('\n').Length), trace)
826+
#if !NETFRAMEWORK // downlevel has interstitial layers we are not seeking to characterize at this point
827+
Assert.Equal(totalCount, trace.Split('\n').Length)
825828
#endif
826829

827830
// --- Tests per overload ---

0 commit comments

Comments
 (0)