testing timeout from samalba#77

Author: donhcd

dockerclient_test.go

@@ -3,9 +3,11 @@ package dockerclient
 import (
 	"bytes"
 	"fmt"
+	"net/url"
 	"reflect"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/docker/docker/pkg/stdcopy"
 )
@@ -28,6 +30,22 @@ func testDockerClient(t *testing.T) *DockerClient {
 	return client
 }
 
+func TestDockerClientTimeout(t *testing.T) {
+	client, err := NewDockerClientTimeout(testHTTPServer.URL, nil, 3*time.Second)
+	if err != nil {
+		t.Fatal("Cannot init the docker client")
+	}
+	hangingURL := fmt.Sprintf("%s/%s/hangFor", testHTTPServer.URL, APIVersion)
+	_, err = client.HTTPClient.PostForm(hangingURL, url.Values{"numSeconds": {"4"}})
+	if err == nil {
+		t.Fatal("Expected failure from POST request")
+	}
+	_, err = client.HTTPClient.PostForm(hangingURL, url.Values{"numSeconds": {"1"}})
+	if err != nil {
+		t.Fatalf("Got error from POST request: %q", err)
+	}
+}
+
 func TestInfo(t *testing.T) {
 	client := testDockerClient(t)
 	info, err := client.Info()

engine_mock_test.go

@@ -30,6 +30,9 @@ func init() {
 	r.HandleFunc(baseURL+"/containers/{id}/changes", handleContainerChanges).Methods("GET")
 	r.HandleFunc(baseURL+"/containers/{id}/kill", handleContainerKill).Methods("POST")
 	r.HandleFunc(baseURL+"/images/create", handleImagePull).Methods("POST")
+	// this is used to test timeout functionality
+	r.HandleFunc(baseURL+"/hangFor", handleHang).Methods("POST")
+
 	testHTTPServer = httptest.NewServer(handlerAccessLog(r))
 }
 
@@ -228,3 +231,17 @@ func handlerGetContainers(w http.ResponseWriter, r *http.Request) {
 	}
 	w.Write([]byte(body))
 }
+
+func handleHang(w http.ResponseWriter, r *http.Request) {
+	if err := r.ParseForm(); err != nil {
+		panic(err)
+	}
+	numSecondsString := r.FormValue("numSeconds")
+	numSeconds, err := strconv.Atoi(numSecondsString)
+	if err != nil {
+		panic(err)
+	}
+
+	time.Sleep(time.Duration(numSeconds) * time.Second)
+	fmt.Printf("done sleeping! %d", numSeconds)
+}