From 0c19994b51d30e7e5b6dba3b731d7cb80b878845 Mon Sep 17 00:00:00 2001 From: Dorin Geman Date: Tue, 13 Jan 2026 15:44:55 +0200 Subject: [PATCH 1/3] chore(ci): improve release workflow visibility Signed-off-by: Dorin Geman --- .github/workflows/release.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6aa0019d..cc7d049b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -40,6 +40,18 @@ jobs: test: runs-on: ubuntu-latest steps: + - name: Summary + run: | + echo "## Release Parameters" >> $GITHUB_STEP_SUMMARY + echo "| Parameter | Value |" >> $GITHUB_STEP_SUMMARY + echo "|-----------|-------|" >> $GITHUB_STEP_SUMMARY + echo "| Release Tag | \`${{ inputs.releaseTag }}\` |" >> $GITHUB_STEP_SUMMARY + echo "| Push Latest | \`${{ inputs.pushLatest }}\` |" >> $GITHUB_STEP_SUMMARY + echo "| llama-server Version | \`${{ inputs.llamaServerVersion }}\` |" >> $GITHUB_STEP_SUMMARY + echo "| vLLM Version | \`${{ inputs.vllmVersion }}\` |" >> $GITHUB_STEP_SUMMARY + echo "| SGLang Version | \`${{ inputs.sglangVersion }}\` |" >> $GITHUB_STEP_SUMMARY + echo "| Build MUSA/CANN | \`${{ inputs.buildMusaCann }}\` |" >> $GITHUB_STEP_SUMMARY + - name: Checkout code uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 From cd1e1322d2926b218694b6bb9aa56e335c968108 Mon Sep 17 00:00:00 2001 From: Dorin Geman Date: Tue, 13 Jan 2026 15:53:20 +0200 Subject: [PATCH 2/3] refactor(ci): simplify tag formatting with reusable function Signed-off-by: Dorin Geman --- .github/workflows/release.yml | 59 ++++++++++------------------------- 1 file changed, 17 insertions(+), 42 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cc7d049b..795d8cab 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -75,48 +75,23 @@ jobs: id: tags shell: bash run: | - echo "cpu<> "$GITHUB_OUTPUT" - echo "docker/model-runner:${{ inputs.releaseTag }}" >> "$GITHUB_OUTPUT" - if [ "${{ inputs.pushLatest }}" == "true" ]; then - echo "docker/model-runner:latest" >> "$GITHUB_OUTPUT" - fi - echo 'EOF' >> "$GITHUB_OUTPUT" - echo "cuda<> "$GITHUB_OUTPUT" - echo "docker/model-runner:${{ inputs.releaseTag }}-cuda" >> "$GITHUB_OUTPUT" - if [ "${{ inputs.pushLatest }}" == "true" ]; then - echo "docker/model-runner:latest-cuda" >> "$GITHUB_OUTPUT" - fi - echo 'EOF' >> "$GITHUB_OUTPUT" - echo "vllm-cuda<> "$GITHUB_OUTPUT" - echo "docker/model-runner:${{ inputs.releaseTag }}-vllm-cuda" >> "$GITHUB_OUTPUT" - if [ "${{ inputs.pushLatest }}" == "true" ]; then - echo "docker/model-runner:latest-vllm-cuda" >> "$GITHUB_OUTPUT" - fi - echo 'EOF' >> "$GITHUB_OUTPUT" - echo "sglang-cuda<> "$GITHUB_OUTPUT" - echo "docker/model-runner:${{ inputs.releaseTag }}-sglang-cuda" >> "$GITHUB_OUTPUT" - if [ "${{ inputs.pushLatest }}" == "true" ]; then - echo "docker/model-runner:latest-sglang-cuda" >> "$GITHUB_OUTPUT" - fi - echo 'EOF' >> "$GITHUB_OUTPUT" - echo "rocm<> "$GITHUB_OUTPUT" - echo "docker/model-runner:${{ inputs.releaseTag }}-rocm" >> "$GITHUB_OUTPUT" - if [ "${{ inputs.pushLatest }}" == "true" ]; then - echo "docker/model-runner:latest-rocm" >> "$GITHUB_OUTPUT" - fi - echo 'EOF' >> "$GITHUB_OUTPUT" - echo "musa<> "$GITHUB_OUTPUT" - echo "docker/model-runner:${{ inputs.releaseTag }}-musa" >> "$GITHUB_OUTPUT" - if [ "${{ inputs.pushLatest }}" == "true" ]; then - echo "docker/model-runner:latest-musa" >> "$GITHUB_OUTPUT" - fi - echo 'EOF' >> "$GITHUB_OUTPUT" - echo "cann<> "$GITHUB_OUTPUT" - echo "docker/model-runner:${{ inputs.releaseTag }}-cann" >> "$GITHUB_OUTPUT" - if [ "${{ inputs.pushLatest }}" == "true" ]; then - echo "docker/model-runner:latest-cann" >> "$GITHUB_OUTPUT" - fi - echo 'EOF' >> "$GITHUB_OUTPUT" + format_tags() { + local variant="$1" + local suffix="${variant:+-$variant}" # empty for cpu, "-variant" otherwise + echo "${variant:-cpu}<> "$GITHUB_OUTPUT" + echo "docker/model-runner:${{ inputs.releaseTag }}${suffix}" >> "$GITHUB_OUTPUT" + if [ "${{ inputs.pushLatest }}" == "true" ]; then + echo "docker/model-runner:latest${suffix}" >> "$GITHUB_OUTPUT" + fi + echo 'EOF' >> "$GITHUB_OUTPUT" + } + format_tags "" # cpu + format_tags "cuda" + format_tags "vllm-cuda" + format_tags "sglang-cuda" + format_tags "rocm" + format_tags "musa" + format_tags "cann" - name: Log in to DockerHub uses: docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef From f3543a7dac1598c577aa842420a46183a5a6e0b8 Mon Sep 17 00:00:00 2001 From: Dorin Geman Date: Tue, 13 Jan 2026 15:54:58 +0200 Subject: [PATCH 3/3] chore(ci): make releaseTag required to prevent accidental pushes Signed-off-by: Dorin Geman --- .github/workflows/release.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 795d8cab..19e370a6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,9 +11,8 @@ on: default: false releaseTag: description: "Release tag" - required: false + required: true type: string - default: "test" llamaServerVersion: description: "llama-server version" required: false