[HAL] Fix BCD conversion macro

- Evaluate macro parameter only once
- Remove the stdcall calling convention from private functions for PC-98

Author: disean

hal/halx86/include/halp.h

@@ -67,11 +67,21 @@ VOID
 #define HALP_LOW_STUB_SIZE_IN_PAGES 3
 #endif
 
-/* Conversion functions */
-#define BCD_INT(bcd)            \
-    (((bcd & 0xF0) >> 4) * 10 + (bcd & 0x0F))
-#define INT_BCD(int)            \
-    (UCHAR)(((int / 10) << 4) + (int % 10))
+FORCEINLINE
+UCHAR
+BCD_INT(
+    _In_ UCHAR Bcd)
+{
+    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
+}
+
+FORCEINLINE
+UCHAR
+INT_BCD(
+    _In_ CSHORT Int)
+{
+    return ((Int / 10) << 4) + (Int % 10);
+}
 
 typedef
 BOOLEAN

hal/halx86/pc98/cmos.c

@@ -33,26 +33,17 @@ static ULONG_PTR MappedNvram;
 
 /* PRIVATE FUNCTIONS *********************************************************/
 
-/* Avoid double calls */
-#undef BCD_INT
-static UCHAR
-BCD_INT(
-    _In_ UCHAR Bcd)
-{
-    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
-}
-
-static UCHAR
-NTAPI
+static
+UCHAR
 HalpReadNvram(
     _In_ UCHAR Register)
 {
     return READ_REGISTER_UCHAR((PUCHAR)(MappedNvram + Register));
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static VOID
-NTAPI
+static
+VOID
 HalpWriteNvram(
     _In_ UCHAR Register,
     _In_ UCHAR Value)
@@ -63,8 +54,8 @@ HalpWriteNvram(
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static UCHAR
-NTAPI
+static
+UCHAR
 HalpRtcReadByte(VOID)
 {
     UCHAR i;
@@ -86,8 +77,8 @@ HalpRtcReadByte(VOID)
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static VOID
-NTAPI
+static
+VOID
 HalpRtcWriteBit(
     _In_ UCHAR Bit)
 {
@@ -101,8 +92,8 @@ HalpRtcWriteBit(
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static VOID
-NTAPI
+static
+VOID
 HalpRtcWriteCommand(
     _In_ UCHAR Command)
 {