Skip to content

Commit ceacdfc

Browse files
Fivellclaude
andcommitted
Revert renew_date to String for consistency with other date-only fields
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 3074d7b commit ceacdfc

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -585,8 +585,8 @@ The SDK distinguishes between date-only and datetime fields:
585585
- `Proof.getCreatedAt()`, `Proof.getExpiresAt()`
586586
- `Order.getCreatedAt()`, `Identity.getCreatedAt()`, `Address.getCreatedAt()`, `VoiceInTrunk.getCreatedAt()`, `VoiceInTrunkGroup.getCreatedAt()`, `VoiceOutTrunk.getCreatedAt()`, `SharedCapacityGroup.getCreatedAt()`, `Export.getCreatedAt()`, `AddressVerification.getCreatedAt()`, `PermanentSupportingDocument.getCreatedAt()`
587587
- **Date-only fields** — deserialized as `LocalDate`:
588-
- `Identity.getBirthDate()`, `CapacityPool.getRenewDate()`
589-
- **Billing range fields** (`DidOrderItem.getBilledFrom()`, `DidOrderItem.getBilledTo()`) remain as `String`.
588+
- `Identity.getBirthDate()`
589+
- **Date-only fields kept as strings** (`CapacityPool.getRenewDate()`, `DidOrderItem.getBilledFrom()`, `DidOrderItem.getBilledTo()`) remain as `String`.
590590

591591
```java
592592
Did did = client.dids().find("uuid").getData();

src/main/java/com/didww/sdk/resource/CapacityPool.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.github.jasminb.jsonapi.annotations.Type;
66
import lombok.Getter;
77

8-
import java.time.LocalDate;
98
import java.util.List;
109

1110
@Type("capacity_pools")
@@ -17,7 +16,7 @@ public class CapacityPool extends BaseResource {
1716
private String name;
1817

1918
@JsonProperty(value = "renew_date", access = JsonProperty.Access.WRITE_ONLY)
20-
private LocalDate renewDate;
19+
private String renewDate;
2120

2221
@JsonProperty("total_channels_count")
2322
private Integer totalChannelsCount;

0 commit comments

Comments
 (0)