Skip to content

Commit 479fb54

Browse files
committed
added PHP 8 typehints
1 parent a37196c commit 479fb54

28 files changed

Lines changed: 71 additions & 104 deletions

src/Dibi/Bridges/Tracy/Panel.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class Panel implements Tracy\IBarPanel
3232
private array $events = [];
3333

3434

35-
public function __construct($explain = true, int $filter = null)
35+
public function __construct(bool $explain = true, int $filter = null)
3636
{
3737
$this->filter = $filter ?: Event::QUERY;
3838
$this->explain = $explain;

src/Dibi/Connection.php

Lines changed: 10 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,8 @@ final public function isConnected(): bool
186186
/**
187187
* Returns configuration variable. If no $key is passed, returns the entire array.
188188
* @see self::__construct
189-
* @return mixed
190189
*/
191-
final public function getConfig(string $key = null, $default = null)
190+
final public function getConfig(string $key = null, $default = null): mixed
192191
{
193192
return $key === null
194193
? $this->config
@@ -210,21 +209,19 @@ final public function getDriver(): Driver
210209

211210
/**
212211
* Generates (translates) and executes SQL query.
213-
* @param mixed ...$args
214212
* @throws Exception
215213
*/
216-
final public function query(...$args): Result
214+
final public function query(mixed ...$args): Result
217215
{
218216
return $this->nativeQuery($this->translate(...$args));
219217
}
220218

221219

222220
/**
223221
* Generates SQL query.
224-
* @param mixed ...$args
225222
* @throws Exception
226223
*/
227-
final public function translate(...$args): string
224+
final public function translate(mixed ...$args): string
228225
{
229226
if (!$this->driver) {
230227
$this->connect();
@@ -235,9 +232,8 @@ final public function translate(...$args): string
235232

236233
/**
237234
* Generates and prints SQL query.
238-
* @param mixed ...$args
239235
*/
240-
final public function test(...$args): bool
236+
final public function test(mixed ...$args): bool
241237
{
242238
try {
243239
Helpers::dump($this->translate(...$args));
@@ -256,10 +252,9 @@ final public function test(...$args): bool
256252

257253
/**
258254
* Generates (translates) and returns SQL query as DataSource.
259-
* @param mixed ...$args
260255
* @throws Exception
261256
*/
262-
final public function dataSource(...$args): DataSource
257+
final public function dataSource(mixed ...$args): DataSource
263258
{
264259
return new DataSource($this->translate(...$args), $this);
265260
}
@@ -413,10 +408,7 @@ public function rollback(string $savepoint = null): void
413408
}
414409

415410

416-
/**
417-
* @return mixed
418-
*/
419-
public function transaction(callable $callback)
411+
public function transaction(callable $callback): mixed
420412
{
421413
if ($this->transactionDepth === 0) {
422414
$this->begin();
@@ -520,45 +512,40 @@ public function substitute(string $value): string
520512

521513
/**
522514
* Executes SQL query and fetch result - shortcut for query() & fetch().
523-
* @param mixed ...$args
524515
* @throws Exception
525516
*/
526-
public function fetch(...$args): ?Row
517+
public function fetch(mixed ...$args): ?Row
527518
{
528519
return $this->query($args)->fetch();
529520
}
530521

531522

532523
/**
533524
* Executes SQL query and fetch results - shortcut for query() & fetchAll().
534-
* @param mixed ...$args
535525
* @return Row[]|array[]
536526
* @throws Exception
537527
*/
538-
public function fetchAll(...$args): array
528+
public function fetchAll(mixed ...$args): array
539529
{
540530
return $this->query($args)->fetchAll();
541531
}
542532

543533

544534
/**
545535
* Executes SQL query and fetch first column - shortcut for query() & fetchSingle().
546-
* @param mixed ...$args
547-
* @return mixed
548536
* @throws Exception
549537
*/
550-
public function fetchSingle(...$args)
538+
public function fetchSingle(mixed ...$args): mixed
551539
{
552540
return $this->query($args)->fetchSingle();
553541
}
554542

555543

556544
/**
557545
* Executes SQL query and fetch pairs - shortcut for query() & fetchPairs().
558-
* @param mixed ...$args
559546
* @throws Exception
560547
*/
561-
public function fetchPairs(...$args): array
548+
public function fetchPairs(mixed ...$args): array
562549
{
563550
return $this->query($args)->fetchPairs();
564551
}

src/Dibi/DataSource.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function __construct(string $sql, Connection $connection)
5555
* @param string|array $col column name or array of column names
5656
* @param string $as column alias
5757
*/
58-
public function select($col, string $as = null): self
58+
public function select(string|array $col, string $as = null): static
5959
{
6060
if (is_array($col)) {
6161
$this->cols = $col;
@@ -70,7 +70,7 @@ public function select($col, string $as = null): self
7070
/**
7171
* Adds conditions to query.
7272
*/
73-
public function where($cond): self
73+
public function where($cond): static
7474
{
7575
$this->conds[] = is_array($cond)
7676
? $cond // TODO: not consistent with select and orderBy
@@ -84,7 +84,7 @@ public function where($cond): self
8484
* Selects columns to order by.
8585
* @param string|array $row column name or array of column names
8686
*/
87-
public function orderBy($row, string $direction = 'ASC'): self
87+
public function orderBy(string|array $row, string $direction = 'ASC'): static
8888
{
8989
if (is_array($row)) {
9090
$this->sorting = $row;
@@ -99,7 +99,7 @@ public function orderBy($row, string $direction = 'ASC'): self
9999
/**
100100
* Limits number of rows.
101101
*/
102-
public function applyLimit(int $limit, int $offset = null): self
102+
public function applyLimit(int $limit, int $offset = null): static
103103
{
104104
$this->limit = $limit;
105105
$this->offset = $offset;
@@ -148,7 +148,7 @@ public function fetch(): ?Row
148148
* Like fetch(), but returns only first field.
149149
* @return mixed value on success, null if no next record
150150
*/
151-
public function fetchSingle()
151+
public function fetchSingle(): mixed
152152
{
153153
return $this->getResult()->fetchSingle();
154154
}

src/Dibi/DateTime.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@ class DateTime extends \DateTimeImmutable
1717
{
1818
use Strict;
1919

20-
/**
21-
* @param string|int $time
22-
*/
23-
public function __construct($time = 'now', \DateTimeZone $timezone = null)
20+
public function __construct(string|int $time = 'now', \DateTimeZone $timezone = null)
2421
{
2522
$timezone = $timezone ?: new \DateTimeZone(date_default_timezone_get());
2623
if (is_numeric($time)) {

src/Dibi/Drivers/DummyDriver.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function rollback(string $savepoint = null): void
5757
}
5858

5959

60-
public function getResource()
60+
public function getResource(): mixed
6161
{
6262
return null;
6363
}
@@ -171,8 +171,9 @@ public function free(): void
171171
}
172172

173173

174-
public function getResultResource()
174+
public function getResultResource(): mixed
175175
{
176+
return null;
176177
}
177178

178179

src/Dibi/Drivers/FirebirdDriver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ public function inTransaction(): bool
189189
* Returns the connection resource.
190190
* @return resource|null
191191
*/
192-
public function getResource()
192+
public function getResource(): mixed
193193
{
194194
return is_resource($this->connection) ? $this->connection : null;
195195
}

src/Dibi/Drivers/FirebirdResult.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function free(): void
102102
* Returns the result set resource.
103103
* @return resource|null
104104
*/
105-
public function getResultResource()
105+
public function getResultResource(): mixed
106106
{
107107
$this->autoFree = false;
108108
return is_resource($this->resultSet) ? $this->resultSet : null;

src/Dibi/Drivers/MySqliDriver.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,7 @@ public function query(string $sql): ?Dibi\ResultDriver
156156
}
157157

158158

159-
/**
160-
* @param int|string $code
161-
*/
162-
public static function createException(string $message, $code, string $sql): Dibi\DriverException
159+
public static function createException(string $message, int|string $code, string $sql): Dibi\DriverException
163160
{
164161
if (in_array($code, [1216, 1217, 1451, 1452, 1701], true)) {
165162
return new Dibi\ForeignKeyConstraintViolationException($message, $code, $sql);

src/Dibi/Drivers/NoDataResult.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function getResultColumns(): array
6060
}
6161

6262

63-
public function getResultResource()
63+
public function getResultResource(): mixed
6464
{
6565
return null;
6666
}

src/Dibi/Drivers/OdbcDriver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public function inTransaction(): bool
167167
* Returns the connection resource.
168168
* @return resource|null
169169
*/
170-
public function getResource()
170+
public function getResource(): mixed
171171
{
172172
return is_resource($this->connection) ? $this->connection : null;
173173
}

0 commit comments

Comments
 (0)