feat(hooks): enforce ecr-missing on strong completion claims

Add classifyEcrClosure for N6 ECR evidence, Stop gap ecr-missing, tests
on stop-gate and control-plane chains, and report-dev note that test green
is not ECR. Closes ECR completion-claim forced-closure fix implementation.

Author: rockyshi1993

changelogs/unreleased.md

@@ -5,6 +5,7 @@
 
 ## 当前未发布实现候选
 
+- **ECR 完成宣称强制闭环（ecr-missing）**：`classifyEcrClosure`；强完成/关需求无 ECR/DoD 证据 → Stop gap `ecr-missing`；`npm run test:ecr-closure` 挂 stop-gate 与 control-plane；report-dev 标明测试绿≠ECR。需求：`ECR与完成宣称强制闭环修复`。
 - **Agent 交付诚实门（delivery-honesty）**：`classifyDeliveryHonesty` → gap `stage-report-missing` / `progress-overclaim`；Stop 接线；PreTool 有 04 无 05 时禁控制面写；`npm run test:delivery-honesty` 挂 stop-gate 与 control-plane；进度模板 DeliveryHonestyMatrix。需求：`Agent交付诚实与过程产物强制修复`。
 - **维护者站点×完整功能清单对账门（docs-surface-inventory）**：新增 `scripts/lib/docs-surface-inventory.js` + `npm run test:docs-surface-inventory`；校验 Skills84/plugin 双向、workflows×8（含 other）、MCP15、Hooks5/runtime、prompts30、instructions15、website≥156、process-enforcement 文件与 script；挂入 `test:control-plane` 与 validation-manifest 节点 `docs-surface-inventory` / `process-enforcement-e2e`（fast/full）。public-text-surfaces 扩展 guide/index 与 host-parity-grok。intro 增加能力证据三列表。
 - **全宿主流程强制 + 产物路径准确（process-enforcement）**：新增 `scripts/lib/process-enforcement.js`（MutationCpGate 受保护路径 hard-deny、ArtifactPathGate、复审清单/过程包齐套判定）与 `host-enforcement-matrix.js`（五宿主策略真相源）；`lifecycle.cjs` PreTool 接线；`lifecycle-stop-gate.cjs` 追加 `review-checklist-missing` / `process-artifact-incomplete` / `progress-artifact-missing`；`npm run test:process-enforcement-e2e` 并入 `test:stop-gate` 与 `test:control-plane`。文档：`02-output-paths` ArtifactPathGate 行、README 流程强制条；配套 PI-REQ-ASSESS 需求模板评估字段。

hooks/_runtime/lifecycle-stop-gate.cjs

@@ -22,16 +22,19 @@ try {
 let classifyReviewChecklistCompletion
 let classifyProcessArtifactCompleteness
 let classifyDeliveryHonesty
+let classifyEcrClosure
 try {
   ;({
     classifyReviewChecklistCompletion,
     classifyProcessArtifactCompleteness,
-    classifyDeliveryHonesty
+    classifyDeliveryHonesty,
+    classifyEcrClosure
   } = require('../../scripts/lib/process-enforcement.js'))
 } catch {
   classifyReviewChecklistCompletion = () => ({ ok: true, code: null, gap: null })
   classifyProcessArtifactCompleteness = () => ({ ok: true, code: null, gap: null, missing: [] })
   classifyDeliveryHonesty = () => ({ ok: true, gaps: [], code: null, gap: null })
+  classifyEcrClosure = () => ({ ok: true, code: null, gap: null })
 }
 
 function extractLastAssistantMessage (payload) {
@@ -286,6 +289,18 @@ function evaluateStopCompletionGate (input = {}) {
     }
   }
 
+  // ECR / N6 execution-closure evidence (ecr-missing)
+  if (typeof classifyEcrClosure === 'function') {
+    const ecr = classifyEcrClosure({
+      text,
+      mode: modeL || mode,
+      workflow: wf || workflow
+    })
+    if (!ecr.ok && ecr.gap && !gaps.includes(ecr.gap)) {
+      gaps.push(ecr.gap)
+    }
+  }
+
   const uniqueGaps = [...new Set(gaps)]
   honesty.processGaps = uniqueGaps
 

package.json

@@ -88,7 +88,7 @@
     "test:package-release": "node scripts/run-validation.js --route package-release",
     "test:control-plane-module-contracts": "node scripts/test-control-plane-module-contracts.js",
     "test:closure-evidence": "node scripts/test-closure-evidence-controls.js",
-    "test:control-plane": "npm run test:probe-registry && npm run test:cli-command-registry && npm run test:cli-json-contract && npm run test:governance-status-summary && npm run test:always-on-governance && npm run test:intent-consistency && npm run test:local-probe && npm run test:context-read && npm run test:context-binding && npm run test:context-read-controls && npm run test:tenant-selection && npm run test:workflow-capabilities && npm run test:api-verification-contracts && npm run test:git-index-isolation && npm run test:control-plane-contracts && npm run test:markdown-structure && npm run test:control-plane-module-contracts && npm run test:consumer-evolution-controls && npm run test:residual-absorption-controls && npm run test:brand-visual-quality && npm run test:turn-liveness && npm run test:closure-evidence && npm run test:workflow-completion && npm run test:public-text-integrity && npm run test:external-review-claim && npm run test:candidate-review-bundle && npm run test:capability-surface-decision && npm run test:host-capability-routing && npm run test:requirement-parallel-orchestration && npm run test:evidence-freshness && npm run test:optimization-backlog-evidence && npm run test:discipline-execution && npm run test:skill-resolve && npm run test:process-enforcement-e2e && npm run test:docs-surface-inventory && npm run test:delivery-honesty",
+    "test:control-plane": "npm run test:probe-registry && npm run test:cli-command-registry && npm run test:cli-json-contract && npm run test:governance-status-summary && npm run test:always-on-governance && npm run test:intent-consistency && npm run test:local-probe && npm run test:context-read && npm run test:context-binding && npm run test:context-read-controls && npm run test:tenant-selection && npm run test:workflow-capabilities && npm run test:api-verification-contracts && npm run test:git-index-isolation && npm run test:control-plane-contracts && npm run test:markdown-structure && npm run test:control-plane-module-contracts && npm run test:consumer-evolution-controls && npm run test:residual-absorption-controls && npm run test:brand-visual-quality && npm run test:turn-liveness && npm run test:closure-evidence && npm run test:workflow-completion && npm run test:public-text-integrity && npm run test:external-review-claim && npm run test:candidate-review-bundle && npm run test:capability-surface-decision && npm run test:host-capability-routing && npm run test:requirement-parallel-orchestration && npm run test:evidence-freshness && npm run test:optimization-backlog-evidence && npm run test:discipline-execution && npm run test:skill-resolve && npm run test:process-enforcement-e2e && npm run test:docs-surface-inventory && npm run test:delivery-honesty && npm run test:ecr-closure",
     "test:tenant-selection": "node scripts/test-tenant-selection.js",
     "test:workflow-capabilities": "node scripts/test-workflow-capabilities.js",
     "test:api-verification-contracts": "node scripts/test-api-verification-contracts.js",
@@ -113,10 +113,11 @@
     "prepublishOnly": "npm run test:all:with-audit",
     "test:executable-absorption-gates": "node scripts/test-executable-absorption-gates.js",
     "test:skill-resolve": "node scripts/test-skill-resolve.js && node scripts/test-skill-resolution-hook-paths.js && node scripts/test-workspace-skill-auto-match.js",
-    "test:stop-gate": "node scripts/test-lifecycle-stop-gate.js && node scripts/test-r10-control-plane-honesty.js && node scripts/replay-stop-gate-hook-matrix.js && node scripts/test-process-enforcement-e2e.js && node scripts/test-delivery-honesty.js",
+    "test:stop-gate": "node scripts/test-lifecycle-stop-gate.js && node scripts/test-r10-control-plane-honesty.js && node scripts/replay-stop-gate-hook-matrix.js && node scripts/test-process-enforcement-e2e.js && node scripts/test-delivery-honesty.js && node scripts/test-ecr-closure.js",
     "test:process-enforcement-e2e": "node scripts/test-process-enforcement-e2e.js",
     "test:docs-surface-inventory": "node scripts/test-docs-surface-inventory.js",
     "test:delivery-honesty": "node scripts/test-delivery-honesty.js",
+    "test:ecr-closure": "node scripts/test-ecr-closure.js",
     "test:skill-automatch-accept": "node scripts/replay-skill-automatch-accept.cjs"
   },
   "keywords": [
@@ -233,6 +234,7 @@
     "scripts/test-process-enforcement-e2e.js",
     "scripts/test-docs-surface-inventory.js",
     "scripts/test-delivery-honesty.js",
+    "scripts/test-ecr-closure.js",
     "scripts/lib/docs-surface-inventory.js",
     "scripts/lib/process-enforcement.js",
     "scripts/lib/host-enforcement-matrix.js",

prompts/implementation-progress.prompt.md

@@ -49,6 +49,7 @@ applyTo: .devcodex/**/{requirements,bugs}/**; .devcodex/**/fix/**
 | progressHonest | 是（每行有证据）/ 否 |
 | checklistVisible | 03-复审清单 或 review-checklists 路径 |
 | validationEvidence | 命令 + exitCode |
+| ecrStatus | pending / done + ECR 报告路径（测试绿≠ECR） |
 
 ## 进度总览
 

prompts/report-dev.prompt.md

@@ -7,6 +7,7 @@ applyTo: .devcodex/**/reports/requirements/**
 
 > **路径**: 优先 `.devcodex/**/requirements/<需求>/reports/<agent>/YYYYMMDD/NN--<name>.md`；无任务上下文时回退到 `.devcodex/**/reports/requirements/<agent>/YYYYMMDD/NN--<name>.md`
 > **触发**: dev 工作流完成后，由 `report/SKILL.md` 驱动生成
+> ⚠️ **测试绿 ≠ ECR**：`npm test` / 探针 exit 0 不能代替 **N6 ECR 执行闭环复审**。强完成/关需求话术须含 ECR 段 + DoD 对账表，否则 Stop gap `ecr-missing`。
 > **共享基模**: `skills/report/report-schema.json` 的 baseFields + dev overlay；治理结果按 `gateGroup / result / evidence / skipReason` 记录
 > **字段约束**: 每条遗留问题/建议必须附五项验证（合理性 + 可实施性 + 收益 + 验证状态 + 影响范围），详见 [`17-compliance.instructions.md`](../instructions/17-compliance.instructions.md) §1 输出验证
 ---

scripts/lib/process-enforcement.js

@@ -21,7 +21,9 @@ const ERROR_CODES = Object.freeze({
   /** Completion claim without discoverable stage report path */
   STAGE_REPORT_MISSING: 'stage-report-missing',
   /** Over-claim progress without validation evidence rows */
-  PROGRESS_OVERCLAIM: 'progress-overclaim'
+  PROGRESS_OVERCLAIM: 'progress-overclaim',
+  /** Strong completion without ECR / execution-closure review evidence */
+  ECR_MISSING: 'ecr-missing'
 })
 
 /** Paths that use hard-deny for unconfirmed CP even under default safety-only (D1). */
@@ -300,6 +302,51 @@ function classifyDeliveryHonesty (input = {}) {
   return { ok: true, gaps: [], code: null, gap: null }
 }
 
+/**
+ * ECR / N6 execution-closure evidence for strong completion claims.
+ * @param {{ completionClaimed?: boolean, text?: string, mode?: string, workflow?: string }} input
+ */
+function classifyEcrClosure (input = {}) {
+  const text = String(input.text || '')
+  const mode = String(input.mode || '').toLowerCase()
+  const wf = String(input.workflow || mode || '').toLowerCase()
+  const strongClaim =
+    input.completionClaimed === true ||
+    /已完成|任务完成|all work is complete|宣告完成|可关闭需求|本需求.*闭环|DoD.*闭环|只差验收|需求已完成/i.test(
+      text
+    )
+
+  if (!strongClaim) return { ok: true, code: null, gap: null }
+  if (mode === 'chat' || wf === 'chat') return { ok: true, code: null, gap: null }
+  if (isDeliveryHonestyExempt(text)) return { ok: true, code: null, gap: null }
+
+  // Explicit N/A with whitelist skipReason
+  if (/ECR\s*[:：]\s*N\/A/i.test(text) && /skipReason\s*[=:：]\s*(chat|simple-task|simple_task|probe)/i.test(text)) {
+    return { ok: true, code: null, gap: null }
+  }
+
+  const hasEcrHeading = /ECR|执行闭环复审|Execution\s*Closure\s*Review/i.test(text)
+  const hasDodMatrix =
+    /DoD|ECR-[1-7]|对账|ECR\s*矩阵|闭环复审/i.test(text) && /\|/.test(text)
+  const hasEcrReportPath =
+    /reports[/\\][^\s)\]`]+ECR[^\s)\]`]*\.md|ECR[^\n]{0,40}\.md|阶段诚实状态报告|执行闭环/i.test(text)
+
+  if (hasEcrHeading && hasDodMatrix) return { ok: true, code: null, gap: null }
+  if (hasEcrReportPath && (hasEcrHeading || hasDodMatrix || /DoD\s*对账/i.test(text))) {
+    return { ok: true, code: null, gap: null }
+  }
+  // Path alone to a report named ECR is enough if strong claim already requires care
+  if (/reports[/\\][^\s)\]`]*ECR[^\s)\]`]*\.md/i.test(text)) {
+    return { ok: true, code: null, gap: null }
+  }
+
+  return {
+    ok: false,
+    code: ERROR_CODES.ECR_MISSING,
+    gap: ERROR_CODES.ECR_MISSING
+  }
+}
+
 /**
  * Requirement-dir review checklist discoverability (C).
  * @param {{ taskRoot?: string|null, fs?: { readdirSync?: Function }, text?: string }} input
@@ -336,6 +383,7 @@ module.exports = {
   classifyReviewChecklistCompletion,
   classifyProcessArtifactCompleteness,
   classifyDeliveryHonesty,
+  classifyEcrClosure,
   classifyReviewChecklistDiscoverability,
   simpleTaskForbidsPath,
   normalizePath,

scripts/replay-stop-gate-hook-matrix.js

@@ -63,6 +63,10 @@ const COMPLETE_BODY = [
   '`DevCodexVisibleEnvelopeV1 · completion-check · PASS · ' + 'c'.repeat(64) + '`',
   '',
   '阶段报告: reports/requirements/grok/20260723/01--stop-gate-replay.md',
+  '## ECR 执行闭环复审',
+  '| DoD | 结果 |',
+  '| D1 | ✅ |',
+  '| ECR-1 | ✅ |',
   '工作已完成并收口。'
 ].join('\n')
 

scripts/test-ecr-closure.js

@@ -0,0 +1,113 @@
+'use strict'
+
+/**
+ * T-ECR: ecr-missing classifier + stop-gate integration samples.
+ */
+
+const assert = require('assert')
+const {
+  classifyEcrClosure,
+  classifyDeliveryHonesty,
+  ERROR_CODES
+} = require('./lib/process-enforcement.js')
+const { evaluateStopCompletionGate } = require('../hooks/_runtime/lifecycle-stop-gate.cjs')
+
+// T-ECR-01
+{
+  const r = classifyEcrClosure({
+    mode: 'dev',
+    text: '控制面任务已完成 可关闭需求'
+  })
+  assert.strictEqual(r.ok, false)
+  assert.strictEqual(r.gap, ERROR_CODES.ECR_MISSING)
+}
+
+// T-ECR-02: green table without ECR
+{
+  const r = classifyEcrClosure({
+    mode: 'dev',
+    text: [
+      '任务完成 可关闭需求',
+      '| 权威 | npm run test:x | exitCode 0 |',
+      '全绿'
+    ].join('\n')
+  })
+  assert.strictEqual(r.ok, false)
+  assert.strictEqual(r.gap, ERROR_CODES.ECR_MISSING)
+}
+
+// T-ECR-03: ECR + DoD matrix
+{
+  const r = classifyEcrClosure({
+    mode: 'dev',
+    text: [
+      '任务已完成 可关闭需求',
+      'reports/requirements/grok/20260727/01--ECR-闭环报告.md',
+      '## ECR 执行闭环复审',
+      '| DoD | 结果 |',
+      '| D1 | ✅ |',
+      '| ECR-1 | ✅ |'
+    ].join('\n')
+  })
+  assert.strictEqual(r.ok, true, JSON.stringify(r))
+}
+
+// T-ECR-04: chat
+{
+  const r = classifyEcrClosure({
+    mode: 'chat',
+    text: '任务完成了 可关闭需求'
+  })
+  assert.strictEqual(r.ok, true)
+}
+
+// Golden negatives
+const bad = [
+  '需求已完成 可关闭需求',
+  'dev 已完成 宣告完成',
+  'DoD 闭环 只差验收',
+  '本需求闭环 已完成',
+  '控制面 任务完成 全绿',
+  'Fix 完成 可关闭需求',
+  '实施已完成 需求已完成',
+  'ECR 没写但 可关闭需求'
+]
+let hits = 0
+for (const t of bad) {
+  const r = classifyEcrClosure({ mode: 'dev', text: t })
+  if (!r.ok) hits++
+}
+assert.ok(hits >= 8, `hits=${hits}`)
+
+// Stop integration
+{
+  const r = evaluateStopCompletionGate({
+    mode: 'dev',
+    workflow: 'dev',
+    mutated: true,
+    reportTouched: true,
+    memoryTouched: true,
+    lastAssistantMessage: [
+      '### DevCodex · 入口检查',
+      'PC0 | ok',
+      '### DevCodex · 完成检查',
+      '| 类型 | 命令 | exitCode |',
+      '| 权威 | `npm run test:x` | exitCode 0 |',
+      'reports/x/01--stage.md',
+      '任务已完成 可关闭需求'
+    ].join('\n')
+  })
+  assert.strictEqual(r.decision, 'block')
+  assert.ok(r.gaps.includes('ecr-missing'), `gaps=${r.gaps.join(',')}`)
+}
+
+// Regression: delivery honesty still callable
+{
+  const r = classifyDeliveryHonesty({
+    mode: 'dev',
+    text: '控制面已完成 可关闭需求'
+  })
+  assert.strictEqual(r.ok, false)
+}
+
+console.log('test-ecr-closure: T-ECR samples passed')