Fix log trimmer

Author: dev-guy

lib/geo/log_trimmer.ex

@@ -65,7 +65,7 @@ defmodule Geo.LogTrimmer do
     }
 
     max_size_bytes = parse_size(@max_file_size)
-    Logger.info("LogTrimmer: Started for #{log_file}, Trimming every #{div(@trim_interval, 60_000)} minutes, Max file size: #{max_size_bytes} bytes (#{@max_file_size}), Trim to #{@max_log_lines} lines")
+    Logger.info("LogTrimmer: Started for #{log_file}, Trimming every #{div(@trim_interval, 60_000)} minutes, Maximum file size: #{max_size_bytes} bytes (#{@max_file_size}), Trimming to #{@max_log_lines} lines")
 
     {:ok, state}
   end
@@ -122,13 +122,18 @@ defmodule Geo.LogTrimmer do
         # Check file size first
         %{size: file_size} = File.stat!(log_file)
         max_size_bytes = parse_size(@max_file_size)
+        
+        Logger.debug("LogTrimmer: Checking #{log_file} - File size: #{file_size} bytes, Max size: #{max_size_bytes} bytes")
 
         if file_size <= max_size_bytes do
+          Logger.debug("LogTrimmer: File size (#{file_size} bytes) is under limit (#{max_size_bytes} bytes), skipping trim")
           {:ok, :no_trim_needed}
         else
           content = File.read!(log_file)
           lines = String.split(content, "\n")
           line_count = length(lines)
+          
+          Logger.debug("LogTrimmer: File has #{line_count} lines, max allowed: #{@max_log_lines}")
 
           if line_count > @max_log_lines do
             # Keep only the last @max_log_lines lines
@@ -141,12 +146,15 @@ defmodule Geo.LogTrimmer do
             File.rename!(temp_file, log_file)
 
             lines_removed = line_count - @max_log_lines
+            Logger.debug("LogTrimmer: Trimmed #{log_file} - Removed #{lines_removed} lines, kept #{@max_log_lines} lines")
             {:ok, :trimmed, lines_removed}
           else
+            Logger.debug("LogTrimmer: Line count (#{line_count}) is under limit (#{@max_log_lines}), no trim needed")
             {:ok, :no_trim_needed}
           end
         end
       else
+        Logger.debug("LogTrimmer: File #{log_file} does not exist")
         {:ok, :no_trim_needed}
       end
     rescue
@@ -157,15 +165,16 @@ defmodule Geo.LogTrimmer do
 
   defp parse_size(size_string) do
     # Parse strings like "5 MB", "10 GB", "500 KB", "2 G", "1024 K" into bytes
+    # Default to bytes when no unit is specified
     case Regex.run(~r/^(\d+(?:\.\d+)?)\s*(B|K|KB|M|MB|G|GB|T|TB)?$/i, size_string) do
+      [_, number_str] ->
+        # No unit specified, default to bytes
+        parse_number(number_str)
+
       [_, number_str, unit] ->
-        number = if String.contains?(number_str, ".") do
-          String.to_float(number_str)
-        else
-          String.to_integer(number_str)
-        end
+        number = parse_number(number_str)
 
-        multiplier = case String.upcase(unit || "B") do
+        multiplier = case String.upcase(unit) do
           "B" -> 1
           "K" -> 1_024
           "KB" -> 1_024
@@ -183,4 +192,12 @@ defmodule Geo.LogTrimmer do
         raise ArgumentError, "Invalid size format: #{size_string}"
     end
   end
+
+  defp parse_number(number_str) do
+    if String.contains?(number_str, ".") do
+      String.to_float(number_str)
+    else
+      String.to_integer(number_str)
+    end
+  end
 end