changed path for get_stream_url so label is applied with Playlist.Add#7
Open
jez500 wants to merge 2 commits intodersphere:masterfrom
Open
changed path for get_stream_url so label is applied with Playlist.Add#7jez500 wants to merge 2 commits intodersphere:masterfrom
jez500 wants to merge 2 commits intodersphere:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Awesome addon! works so well, only one little issue I had:
When you add a file path to the playlist with the jsonrpc to uses the last parameter in the url as the playlist item label. So when a radio station is added, the label ends up being the id.
eg
plugin://plugin.audio.radio_de/station/14971label =14971This patch adds an extra param to the path, the label, which gives the station a much more friendly name in the playlist.
eg
plugin://plugin.audio.radio_de/station/14971/SBS+PopAsialabel =SBS PopAsiaDidn't seem to break anything but I am definitely no python expert :)