Use Exception instead of BaseException

tkislan · tkislan · commit 0944850e7810 · 2026-01-14T13:05:32.000Z
diff --git a/deepnote_toolkit/sql/sql_execution.py b/deepnote_toolkit/sql/sql_execution.py
@@ -314,7 +314,7 @@ def _handle_federated_auth_params(sql_alchemy_dict: dict[str, Any]) -> None:
         federated_auth_params = model_validate_compat(
             IntegrationFederatedAuthParams, sql_alchemy_dict["federatedAuthParams"]
         )
-    except BaseException:
+    except Exception:
         logger.exception("Invalid federated auth params, try updating toolkit version")
         return
 

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ def _handle_federated_auth_params(sql_alchemy_dict: dict[str, Any]) -> None:`
`314`	`314`	`federated_auth_params = model_validate_compat(`
`315`	`315`	`IntegrationFederatedAuthParams, sql_alchemy_dict["federatedAuthParams"]`
`316`	`316`	`)`
`317`		`- except BaseException:`
	`317`	`+ except Exception:`
`318`	`318`	`logger.exception("Invalid federated auth params, try updating toolkit version")`
`319`	`319`	`return`
`320`	`320`