Remove unnecessary subqueries

These should not be necessary, and using subqueries without aliases in Postgres causes an error.

Author: courtneyholcomb

dbtsl/api/adbc/protocol.py

@@ -22,7 +22,9 @@ def _serialize_val(cls, val: Any) -> str:
             return str(val)
 
         if isinstance(val, list):
-            list_str = ",".join(cls._serialize_val(list_val) for list_val in val)  # pyright: ignore[reportUnknownVariableType]
+            list_str = ",".join(
+                cls._serialize_val(list_val) for list_val in val
+            )  # pyright: ignore[reportUnknownVariableType]
             return f"[{list_str}]"
 
         if isinstance(val, OrderByMetric):
@@ -83,10 +85,10 @@ def get_query_sql(cls, params: QueryParameters) -> str:
         strict_params_dict = {field: getattr(strict_params, field) for field in params_fields}
 
         serialized_params = cls._serialize_params_dict(strict_params_dict, params_fields)
-        return f"SELECT * FROM {{{{ semantic_layer.query({serialized_params}) }}}}"
+        return f"{{{{ semantic_layer.query({serialized_params}) }}}}"
 
     @classmethod
     def get_dimension_values_sql(cls, params: DimensionValuesQueryParameters) -> str:
         """Get the SQL that will be sent via Arrow Flight to the server based on dimension values query parameters."""
         serialized_params = cls._serialize_params_dict(params, list(DimensionValuesQueryParameters.__optional_keys__))
-        return f"SELECT * FROM {{{{ semantic_layer.dimension_values({serialized_params}) }}}}"
+        return f"{{{{ semantic_layer.dimension_values({serialized_params}) }}}}"

tests/api/adbc/test_protocol.py

@@ -83,8 +83,7 @@ def test_serialize_query_params_complete_query() -> None:
 def test_get_query_sql_simple_query() -> None:
     sql = ADBCProtocol.get_query_sql(params={"metrics": ["a", "b"], "order_by": ["-a"]})
     expected = (
-        'SELECT * FROM {{ semantic_layer.query(metrics=["a","b"],'
-        'order_by=[Metric("a").descending(True)],read_cache=True) }}'
+        '{{ semantic_layer.query(metrics=["a","b"],' 'order_by=[Metric("a").descending(True)],read_cache=True) }}'
     )
     assert sql == expected
 
@@ -100,13 +99,13 @@ def test_get_query_sql_group_by_param() -> None:
         }
     )
     expected = (
-        "SELECT * FROM {{ semantic_layer.query("
+        "{{ semantic_layer.query("
         'group_by=[Dimension("c").grain("day"),Entity("d").grain("week")],metrics=["a","b"],read_cache=True) }}'
     )
     assert sql == expected
 
 
 def test_get_query_sql_dimension_values_query() -> None:
     sql = ADBCProtocol.get_dimension_values_sql(params={"metrics": ["a", "b"]})
-    expected = 'SELECT * FROM {{ semantic_layer.dimension_values(metrics=["a","b"]) }}'
+    expected = '{{ semantic_layer.dimension_values(metrics=["a","b"]) }}'
     assert sql == expected