What ComputerName should Get-DbaPfDataCollectorSet return from a FCI?

[andreasjordan]

I'm currently running all our tests against a SQL Server Failover Cluster Instance "FCI01" build from the two windows servers SQL01 and SQL02.

The test for Get-DbaPfDataCollectorSet fails because when I run the command against "FCI01" the result shows the ComputerName "SQL01", because the code that is executed remotely uses $env:COMPUTERNAME to get the value.

Just to be sure: Is the correct behavior we expect? I think yes and would change the test. Or is there any other opinion?

[andreasjordan]

Solution would be to change

$computerName = ([DbaInstanceParameter]($TestConfig.instance1)).ComputerName

to

$computerName = Resolve-DbaComputerName -ComputerName $TestConfig.Instance1 -Property ComputerName