Skip to content

Commit f3d4d41

Browse files
ci: address review — narrow minted token + fix pin version comments
Second-round peco-review-bot findings on the coverage-fanout sender (the engineer-bot applied round 1 — base.ref guard + job permissions — directly on this branch; this adds the remaining two): - Narrow the minted App token with `permission-contents: write` (coverage_fanout only needs repository_dispatch → contents:write), matching the defense-in-depth the other dispatch jobs use — a leaked token can only fire dispatches. - Restore the version tag in two action-pin comments (`# pinned` → `# v7.1.0` github-script, `# v3.0.0` create-github-app-token) per repo convention. Co-authored-by: Isaac Signed-off-by: Eric Wang <e.wang@databricks.com>
1 parent 2d6f293 commit f3d4d41

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/trigger-integration-tests.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ jobs:
473473
steps:
474474
- name: Check if driver source changed
475475
id: changed
476-
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # pinned
476+
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
477477
with:
478478
script: |
479479
const files = await github.paginate(github.rest.pulls.listFiles, {
@@ -492,12 +492,13 @@ jobs:
492492
- name: Generate GitHub App token (databricks-driver-test)
493493
if: steps.changed.outputs.source == 'true'
494494
id: app-token
495-
uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # pinned
495+
uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0
496496
with:
497497
app-id: ${{ secrets.INTEGRATION_TEST_APP_ID }}
498498
private-key: ${{ secrets.INTEGRATION_TEST_PRIVATE_KEY }}
499499
owner: databricks
500500
repositories: databricks-driver-test
501+
permission-contents: write
501502

502503
- name: Dispatch coverage-fanout
503504
if: steps.changed.outputs.source == 'true'

0 commit comments

Comments
 (0)