ai: apply changes for #876 (2 review threads)

Addresses:
  - #3636302124 at src/databricks/sql/auth/oauth.py:208
  - #3636302135 at tests/unit/test_auth.py:240

Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>

Author: peco-engineer-bot[bot]

src/databricks/sql/auth/oauth.py

@@ -220,7 +220,13 @@ def _on_timeout():
                 # timeout. We do NOT fail fast merely on a falsy open_new return
                 # value: that is unreliable across platforms (it can be falsy
                 # even when a browser did open) and would break working
-                # interactive logins. See issue #458. Placed before the generic
+                # interactive logins. Note this fast-fail only covers the case
+                # where webbrowser.get() raises; the more common headless case
+                # (no browser registered, so open_new() returns False without
+                # raising) is NOT caught here and instead falls through to the
+                # bounded redirect-callback timeout below, which is the real
+                # safeguard against blocking forever. See issue #458. Placed
+                # before the generic
                 # ``except Exception`` so this RuntimeError propagates instead of
                 # being swallowed and retried against the remaining ports.
                 msg = (

tests/unit/test_auth.py

@@ -237,7 +237,10 @@ def test_get_tokens_does_not_hang_when_no_callback_received(
             client_id="mock-id",
             idp_endpoint=InHouseOAuthEndpointCollection(),
             http_client=MagicMock(),
-            redirect_callback_timeout_seconds=2,
+            # Sub-second so this real-wallclock wait stays negligible in the
+            # fast/mocked unit suite. The wait IS the timeout, so there is no
+            # setup racing against it that a shorter bound could make flaky.
+            redirect_callback_timeout_seconds=0.5,
         )
 
         # No callback is ever delivered to the redirect server. Run the flow in
@@ -325,7 +328,10 @@ def run_flow(port):
                 client_id="mock-id",
                 idp_endpoint=InHouseOAuthEndpointCollection(),
                 http_client=MagicMock(),
-                redirect_callback_timeout_seconds=2,
+                # Sub-second: bounds the stalled request-line read. Keeps the
+                # per-attempt wait negligible so even the rare TOCTOU retry loop
+                # stays fast in the mocked unit suite.
+                redirect_callback_timeout_seconds=0.5,
             )
 
             result = {}