Skip to content

Commit 834000b

Browse files
ai: apply changes for #868 (1 review thread)
Addresses: - #3599995835 at src/databricks/sql/auth/retry.py:300 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent b29eb9a commit 834000b

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/databricks/sql/auth/retry.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,6 @@ def sleep_for_retry(self, response: BaseHTTPResponse) -> bool:
297297
else:
298298
proposed_wait = self.get_backoff_time()
299299

300-
proposed_wait = min(proposed_wait, self.delay_max)
301300
self.check_proposed_wait(proposed_wait)
302301
logger.debug(f"Retrying after {proposed_wait} seconds")
303302
time.sleep(proposed_wait)

tests/unit/test_retry.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,15 @@ def test_sleep__short_retry_after_is_not_inflated(self, t_mock, retry_policy):
5555
t_mock.assert_called_with(2)
5656

5757
@patch("time.sleep")
58-
def test_sleep__large_retry_after_is_capped_at_delay_max(self, t_mock, retry_policy):
59-
# A large server Retry-After is clamped down to delay_max, which acts as
60-
# a ceiling on the wait. delay_max defaults to 30 in these fixtures.
58+
def test_sleep__large_retry_after_is_honored_as_is(self, t_mock, retry_policy):
59+
# A server-returned Retry-After is the source of truth and must be
60+
# honored as-is; delay_max does not cap it. delay_max defaults to 30 in
61+
# these fixtures, so 120 would be clamped if the ceiling still applied.
6162
retry_policy._retry_start_time = time.time()
6263
retry_policy.history = []
6364
retry_policy.sleep(HTTPResponse(status=503, headers={"Retry-After": "120"}))
6465

65-
t_mock.assert_called_with(retry_policy.delay_max)
66+
t_mock.assert_called_with(120)
6667

6768
@patch("time.sleep")
6869
def test_sleep__no_retry_after_header__multiple_retries(self, t_mock, retry_policy):

0 commit comments

Comments
 (0)