Skip to content

Commit 465695c

Browse files
ai: apply changes for #879 (1 review thread)
Addresses: - #3641977677 at .github/workflows/trigger-integration-tests.yml:494 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent 821d335 commit 465695c

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

.github/workflows/trigger-integration-tests.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,18 @@ jobs:
457457
# coverage-fanout-tracker.yml opens a tracking issue and runs the
458458
# language-agnostic fan-out (a spec authored from THIS PR's diff, conformed as
459459
# tests across every driver) as peco-engineer-bot.
460+
#
461+
# Fork-PR limitation: for a PR opened from an external fork, GitHub runs the
462+
# `pull_request` (closed/merged) event with NO repository secrets and a
463+
# read-only GITHUB_TOKEN. That means both the App-token generation step and
464+
# the "Signal dispatch failure" fallback (which uses github.token to comment)
465+
# cannot run for fork merges, so those merges are intentionally excluded from
466+
# the fan-out — no dispatch and, by design, no failure comment. Coverage for a
467+
# fork contribution is instead picked up by the next source-affecting merge
468+
# from a maintainer branch, or the fan-out can be dispatched manually against
469+
# databricks-driver-test. Wiring this off a `push`-to-`main` trigger (which
470+
# does have secret access) would restore fork coverage but is a larger change
471+
# and is deliberately out of scope here.
460472
# =============================================================================
461473
trigger-coverage-fanout:
462474
if: |

0 commit comments

Comments
 (0)