-
Notifications
You must be signed in to change notification settings - Fork 60
Expand file tree
/
Copy pathrows_test.go
More file actions
1508 lines (1312 loc) · 45.7 KB
/
rows_test.go
File metadata and controls
1508 lines (1312 loc) · 45.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package rows
import (
"context"
"database/sql/driver"
"encoding/json"
"errors"
"fmt"
"io"
"math"
"os"
"reflect"
"testing"
"time"
"github.com/databricks/databricks-sql-go/internal/cli_service"
"github.com/databricks/databricks-sql-go/internal/client"
"github.com/databricks/databricks-sql-go/internal/config"
"github.com/databricks/databricks-sql-go/internal/rows/rowscanner"
dbsqlrows "github.com/databricks/databricks-sql-go/rows"
"github.com/stretchr/testify/assert"
)
func TestRowsNextRowInPage(t *testing.T) {
t.Parallel()
var rowSet *rows
// nil rows instance
inPage, err := rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "nil rows instance should return false")
// default rows instance
rowSet = &rows{schema: &cli_service.TTableSchema{}, ctx: context.Background()}
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "default rows instance should return false")
fetchResults := &cli_service.TFetchResultsResp{}
// fetchResults has no TRowSet
err = rowSet.makeRowScanner(fetchResults)
assert.EqualError(t, err, "databricks: driver error: "+errRowsUnknowRowType)
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "fetch results with no TRowSet should return false")
tRowSet := &cli_service.TRowSet{}
// default TRowSet
fetchResults.Results = tRowSet
err = rowSet.makeRowScanner(fetchResults)
assert.EqualError(t, err, "databricks: driver error: "+errRowsUnknowRowType)
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "fetch results with default TRowSet should return false")
// Set up a result page starting with row 10 and containing 5 rows
tRowSet.StartRowOffset = 10
tColumn := &cli_service.TColumn{BoolVal: &cli_service.TBoolColumn{Values: []bool{true, false, true, false, true}}}
tRowSet.Columns = []*cli_service.TColumn{tColumn}
err = rowSet.makeRowScanner(fetchResults)
assert.Nil(t, err)
// next row number is prior to result page
rowSet.nextRowNumber = 0
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "next row before current page should return false")
rowSet.nextRowNumber = 9
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "next row before current page should return false")
// next row number is first row in page
rowSet.nextRowNumber = 10
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.True(t, inPage, "next row is first row in page should return true")
// next row is last row in page
rowSet.nextRowNumber = 14
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.True(t, inPage, "next row is first row in page should return true")
// next row is in page
rowSet.nextRowNumber = 12
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.True(t, inPage, "next row is in page should return true")
// next row immediately follows current page
rowSet.nextRowNumber = 15
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "next row immediately after current page should return false")
// next row after current page
rowSet.nextRowNumber = 100
inPage, err = rowSet.isNextRowInPage()
assert.Nil(t, err)
assert.False(t, inPage, "next row after current page should return false")
}
func TestRowsGetPageStartRowNum(t *testing.T) {
t.Parallel()
var sevenRows int64 = 7
rowSet := &rows{schema: &cli_service.TTableSchema{}}
err := rowSet.makeRowScanner(&cli_service.TFetchResultsResp{})
assert.EqualError(t, err, "databricks: driver error: "+errRowsUnknowRowType)
err = rowSet.makeRowScanner(&cli_service.TFetchResultsResp{Results: &cli_service.TRowSet{}})
assert.EqualError(t, err, "databricks: driver error: "+errRowsUnknowRowType)
err = rowSet.makeRowScanner(&cli_service.TFetchResultsResp{Results: &cli_service.TRowSet{StartRowOffset: 7, Columns: []*cli_service.TColumn{}}})
assert.Nil(t, err)
start := rowSet.RowScanner.Start()
assert.Equal(t, sevenRows, start, "rows with TRowSet should return TRowSet.StartRowOffset")
}
func TestRowsFetchMakeRowScanner(t *testing.T) {
t.Parallel()
var rowSet *rows
err := rowSet.fetchResultPage()
assert.EqualError(t, err, "databricks: driver error: "+errRowsNilRows)
rowSet = &rows{
nextRowNumber: -1,
client: &cli_service.TCLIServiceClient{},
schema: &cli_service.TTableSchema{},
}
err = rowSet.makeRowScanner(&cli_service.TFetchResultsResp{})
assert.EqualError(t, err, "databricks: driver error: "+errRowsUnknowRowType)
// default TRowSet
tRowSet := &cli_service.TRowSet{}
// Set up a result page starting with row 10 and containing 5 rows
tRowSet.StartRowOffset = 0
tColumn := &cli_service.TColumn{BoolVal: &cli_service.TBoolColumn{Values: []bool{true, false, true, false, true}}}
tRowSet.Columns = []*cli_service.TColumn{tColumn}
rowSet.nextRowNumber = 5
var noMoreRows = false
err = rowSet.makeRowScanner(&cli_service.TFetchResultsResp{Results: tRowSet, HasMoreRows: &noMoreRows})
assert.Nil(t, err)
}
func TestGetResultMetadataNoDirectResults(t *testing.T) {
t.Parallel()
var getMetadataCount, fetchResultsCount int
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet := &rows{client: client}
metadata, err := rowSet.getResultSetSchema()
assert.NotNil(t, metadata)
assert.Nil(t, err)
assert.Equal(t, 1, getMetadataCount)
// calling again should not call into client
metadata, err = rowSet.getResultSetSchema()
assert.NotNil(t, metadata)
assert.Nil(t, err)
assert.Equal(t, 1, getMetadataCount)
}
func TestGetResultMetadataWithDirectResults(t *testing.T) {
t.Parallel()
var getMetadataCount, fetchResultsCount int
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet := &rows{client: client}
// simulate direct results by setting initial result page and
// metadata
req := &cli_service.TFetchResultsReq{
Orientation: cli_service.TFetchOrientation_FETCH_NEXT,
}
firstPage, _ := client.FetchResults(context.Background(), req)
err := rowSet.makeRowScanner(firstPage)
assert.Nil(t, err)
assert.Equal(t, 1, getMetadataCount)
// fetch results has been called once
assert.Equal(t, 1, fetchResultsCount)
req2 := &cli_service.TGetResultSetMetadataReq{}
metadata, _ := client.GetResultSetMetadata(context.Background(), req2)
rowSet.schema = metadata.Schema
// fetch results has been called once
assert.Equal(t, 1, fetchResultsCount)
assert.Equal(t, 2, getMetadataCount)
// calling should not call into client again
schema, err := rowSet.getResultSetSchema()
assert.NotNil(t, schema)
assert.Nil(t, err)
assert.Equal(t, 2, getMetadataCount)
}
func TestRowsFetchResultPageNoDirectResults(t *testing.T) {
t.Parallel()
var getMetadataCount, fetchResultsCount int
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet := &rows{client: client}
resultPageIterator := rowscanner.NewResultPageIterator(
rowscanner.NewDelimiter(0, 0),
1000,
nil,
false,
client,
"connId",
"corrId",
rowSet.logger(),
)
rowSet.ResultPageIterator = resultPageIterator
var i64Zero int64
// next row number is zero so should fetch first result page
err := rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 1,
nextRowNumber: i64Zero,
offset: i64Zero,
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
// next row number is four, still in same result page
rowSet.nextRowNumber = 4
err = rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 1,
nextRowNumber: int64(4),
offset: i64Zero,
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
// next row number is six, should fetch next result page
rowSet.nextRowNumber = 6
err = rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 2,
nextRowNumber: int64(6),
offset: int64(5),
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
// next row number is two, can't fetch previous result page
rowSet.nextRowNumber = 2
err = rowSet.fetchResultPage()
assert.ErrorContains(t, err, errRowsOnlyForward)
// next row number is past end of next result page
rowSet.nextRowNumber = 15
err = rowSet.fetchResultPage()
assert.ErrorContains(t, err, errInvalidRowNumberState)
rowSet.nextRowNumber = 12
err = rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 3,
nextRowNumber: int64(12),
offset: int64(10),
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
rowSet.nextRowNumber = 15
err = rowSet.fetchResultPage()
errMsg := io.EOF.Error()
assert.EqualError(t, err, errMsg)
// Once we've hit an EOF state any call to fetchResultPage will return EOF
rowSet.nextRowNumber = -1
err = rowSet.fetchResultPage()
assert.EqualError(t, err, io.EOF.Error())
// jump back to last page
rowSet.nextRowNumber = 13
err = rowSet.fetchResultPage()
assert.EqualError(t, err, io.EOF.Error())
}
func TestRowsFetchResultPageWithDirectResults(t *testing.T) {
t.Parallel()
var getMetadataCount, fetchResultsCount int
var i64Zero int64
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet := &rows{client: client}
req := &cli_service.TFetchResultsReq{
Orientation: cli_service.TFetchOrientation_FETCH_NEXT,
}
firstPage, _ := client.FetchResults(context.Background(), req)
err1 := rowSet.makeRowScanner(firstPage)
assert.Nil(t, err1)
resultPageIterator := rowscanner.NewResultPageIterator(
rowscanner.NewDelimiter(rowSet.RowScanner.Start(), rowSet.RowScanner.Count()),
1000,
nil,
false,
client,
"connId",
"corrId",
rowSet.logger(),
)
rowSet.ResultPageIterator = resultPageIterator
// fetch results and get metadata have been called once
assert.Equal(t, 1, fetchResultsCount)
assert.Equal(t, 1, getMetadataCount)
// next row number is zero so should not fetch a result page again
err := rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 1,
nextRowNumber: i64Zero,
offset: i64Zero,
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
// next row number is four, still in same result page
rowSet.nextRowNumber = 4
err = rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 1,
nextRowNumber: int64(4),
offset: i64Zero,
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
// next row number is six, should fetch next result page
rowSet.nextRowNumber = 6
err = rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 2,
nextRowNumber: int64(6),
offset: int64(5),
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
// next row number is two, can't fetch previous result page
rowSet.nextRowNumber = 2
err = rowSet.fetchResultPage()
assert.ErrorContains(t, err, errRowsOnlyForward)
// next row number is past end of results, should fetch all result pages
// going forward and then return EOF
rowSet.nextRowNumber = 15
err = rowSet.fetchResultPage()
assert.ErrorContains(t, err, errInvalidRowNumberState)
rowSet.nextRowNumber = 10
err = rowSet.fetchResultPage()
rowTestPagingResult{
getMetadataCount: 1,
fetchResultsCount: 3,
nextRowNumber: int64(10),
offset: int64(10),
}.validatePaging(t, rowSet, err, fetchResultsCount, getMetadataCount)
rowSet.nextRowNumber = 15
err = rowSet.fetchResultPage()
errMsg := io.EOF.Error()
assert.ErrorContains(t, err, errMsg)
// jump back to last page
rowSet.nextRowNumber = 12
err = rowSet.fetchResultPage()
assert.ErrorContains(t, err, errMsg)
}
var rowTestColNames []string = []string{
"bool_col",
"tinyInt_col",
"smallInt_col",
"int_col",
"bigInt_col",
"float_col",
"double_col",
"string_col",
"timestamp_col",
"binary_col",
"array_col",
"map_col",
"struct_col",
"decimal_col",
"date_col",
"interval_ym_col",
"interval_dt_col",
}
func TestColumnsWithDirectResults(t *testing.T) {
var getMetadataCount, fetchResultsCount int
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
d, err := NewRows("", "", nil, client, nil, nil, nil)
assert.Nil(t, err)
rowSet := d.(*rows)
defer rowSet.Close()
req2 := &cli_service.TGetResultSetMetadataReq{}
metadata, _ := client.GetResultSetMetadata(context.Background(), req2)
rowSet.schema = metadata.Schema
// get metadata has been called once
assert.Equal(t, 1, getMetadataCount)
// getting column names should not call into client again
rowSet.client = client
colNames := rowSet.Columns()
assert.NotNil(t, colNames)
assert.Equal(t, 17, len(colNames))
assert.Equal(t, rowTestColNames, colNames)
}
func TestColumnsNoDirectResults(t *testing.T) {
var getMetadataCount, fetchResultsCount int
rowSet := &rows{}
colNames := rowSet.Columns()
assert.NotNil(t, colNames)
assert.Equal(t, 0, len(colNames))
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet.client = client
colNames = rowSet.Columns()
assert.NotNil(t, colNames)
assert.Equal(t, 17, len(colNames))
}
func TestNextNoDirectResults(t *testing.T) {
var getMetadataCount, fetchResultsCount int
var rowSet *rows
err := rowSet.Next(nil)
assert.EqualError(t, err, "databricks: driver error: "+errRowsNilRows)
rowSet = &rows{}
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet.client = client
resultPageIterator := rowscanner.NewResultPageIterator(
rowscanner.NewDelimiter(0, 0),
1000,
nil,
false,
client,
"connId",
"corrId",
rowSet.logger(),
)
rowSet.ResultPageIterator = resultPageIterator
colNames := rowSet.Columns()
row := make([]driver.Value, len(colNames))
err = rowSet.Next(row)
timestamp, _ := time.Parse(rowscanner.DateTimeFormats["TIMESTAMP"], "2021-07-01 05:43:28")
date, _ := time.Parse(rowscanner.DateTimeFormats["DATE"], "2021-07-01")
row0 := []driver.Value{
true,
driver.Value(nil),
int16(0),
int32(0),
int64(0),
float32(0),
float64(0),
"s0",
timestamp,
[]uint8{uint8(1), uint8(2), uint8(3)},
"[1, 2, 3]",
"{\"key1\": 1}",
"{\"string_field\": \"string_val\", \"array_field\": [1, 2]}",
"1.1",
date,
"100-0",
"-8 08:13:50.300000000",
}
assert.Nil(t, err)
assert.Equal(t, row0, row)
assert.Equal(t, int64(1), rowSet.nextRowNumber)
assert.Equal(t, 1, getMetadataCount)
assert.Equal(t, 1, fetchResultsCount)
}
func TestNextWithDirectResults(t *testing.T) {
var getMetadataCount, fetchResultsCount int
rowSet := &rows{}
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet.client = client
req := &cli_service.TFetchResultsReq{
Orientation: cli_service.TFetchOrientation_FETCH_NEXT,
}
firstPage, _ := client.FetchResults(context.Background(), req)
var err error = rowSet.makeRowScanner(firstPage)
assert.Nil(t, err)
assert.Equal(t, 1, fetchResultsCount)
assert.Equal(t, 1, getMetadataCount)
req2 := &cli_service.TGetResultSetMetadataReq{}
metadata, _ := client.GetResultSetMetadata(context.Background(), req2)
rowSet.schema = metadata.Schema
// get metadata has been called once
assert.Equal(t, 2, getMetadataCount)
colNames := rowSet.Columns()
row := make([]driver.Value, len(colNames))
err = rowSet.Next(row)
timestamp, _ := time.Parse(rowscanner.DateTimeFormats["TIMESTAMP"], "2021-07-01 05:43:28")
date, _ := time.Parse(rowscanner.DateTimeFormats["DATE"], "2021-07-01")
row0 := []driver.Value{
true,
driver.Value(nil),
int16(0),
int32(0),
int64(0),
float32(0),
float64(0),
"s0",
timestamp,
[]uint8{uint8(1), uint8(2), uint8(3)},
"[1, 2, 3]",
"{\"key1\": 1}",
"{\"string_field\": \"string_val\", \"array_field\": [1, 2]}",
"1.1",
date,
"100-0",
"-8 08:13:50.300000000",
}
assert.Nil(t, err)
assert.Equal(t, row0, row)
assert.Equal(t, int64(1), rowSet.nextRowNumber)
assert.Equal(t, 2, getMetadataCount)
assert.Equal(t, 1, fetchResultsCount)
}
func TestGetScanType(t *testing.T) {
var getMetadataCount, fetchResultsCount int
var rowSet *rows
cd, err := rowSet.getColumnMetadataByIndex(0)
assert.Nil(t, cd)
assert.EqualError(t, err, "databricks: driver error: "+errRowsNilRows)
rowSet = &rows{}
cd, err = rowSet.getColumnMetadataByIndex(0)
assert.Nil(t, cd)
assert.EqualError(t, err, "databricks: driver error: "+errRowsNoClient)
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet.client = client
schema, err := rowSet.getResultSetSchema()
assert.Nil(t, err)
cols := schema.Columns
expectedScanTypes := []reflect.Type{
scanTypeBoolean,
scanTypeInt8,
scanTypeInt16,
scanTypeInt32,
scanTypeInt64,
scanTypeFloat32,
scanTypeFloat64,
scanTypeString,
scanTypeDateTime,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeDateTime,
scanTypeString,
scanTypeString,
}
assert.Equal(t, len(expectedScanTypes), len(cols))
scanTypes := make([]reflect.Type, len(cols))
for i := range cols {
scanTypes[i] = rowSet.ColumnTypeScanType(i)
}
assert.Equal(t, expectedScanTypes, scanTypes)
}
func TestColumnTypeNullable(t *testing.T) {
var getMetadataCount, fetchResultsCount int
rowSet := &rows{}
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet.client = client
colNames := rowSet.Columns()
for i := range colNames {
nullable, ok := rowSet.ColumnTypeNullable(i)
assert.False(t, nullable)
assert.False(t, ok)
}
}
func TestColumnTypeLength(t *testing.T) {
var getMetadataCount, fetchResultsCount int
var rowSet *rows
l, b := rowSet.ColumnTypeLength(0)
assert.Zero(t, l)
assert.False(t, b)
rowSet = &rows{}
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet.client = client
colNames := rowSet.Columns()
for i := range colNames {
length, ok := rowSet.ColumnTypeLength(i)
cm, _ := rowSet.getColumnMetadataByIndex(i)
switch rowscanner.GetDBTypeID(cm) {
case cli_service.TTypeId_STRING_TYPE,
cli_service.TTypeId_VARCHAR_TYPE,
cli_service.TTypeId_BINARY_TYPE,
cli_service.TTypeId_ARRAY_TYPE,
cli_service.TTypeId_MAP_TYPE,
cli_service.TTypeId_STRUCT_TYPE:
assert.Equal(t, int64(math.MaxInt64), length)
assert.True(t, ok)
default:
assert.Equal(t, int64(0), length)
assert.False(t, ok)
}
}
}
func TestColumnTypeDatabaseTypeName(t *testing.T) {
var getMetadataCount, fetchResultsCount int
rowSet := &rows{}
client := getRowsTestSimpleClient(&getMetadataCount, &fetchResultsCount)
rowSet.client = client
schema, err := rowSet.getResultSetSchema()
assert.Nil(t, err)
cols := schema.Columns
expectedScanTypes := []reflect.Type{
scanTypeBoolean,
scanTypeInt8,
scanTypeInt16,
scanTypeInt32,
scanTypeInt64,
scanTypeFloat32,
scanTypeFloat64,
scanTypeString,
scanTypeDateTime,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeRawBytes,
scanTypeDateTime,
scanTypeString,
scanTypeString,
}
assert.Equal(t, len(expectedScanTypes), len(cols))
scanTypes := make([]reflect.Type, len(cols))
for i := range cols {
scanTypes[i] = rowSet.ColumnTypeScanType(i)
}
assert.Equal(t, expectedScanTypes, scanTypes)
}
func TestRowsCloseOptimization(t *testing.T) {
var closeCount int
client := &client.TestClient{
FnCloseOperation: func(ctx context.Context, req *cli_service.TCloseOperationReq) (_r *cli_service.TCloseOperationResp, _err error) {
closeCount++
return nil, nil
},
}
opHandle := &cli_service.TOperationHandle{OperationId: &cli_service.THandleIdentifier{GUID: []byte{'f', 'o'}}}
rowSet, _ := NewRows("", "", opHandle, client, nil, nil, nil)
// rowSet has no direct results calling Close should result in call to client to close operation
err := rowSet.Close()
assert.Nil(t, err, "rows.Close should not throw an error")
assert.Equal(t, 1, closeCount)
// rowSet has direct results, but operation was not closed so it should call client to close operation
directResults := &cli_service.TSparkDirectResults{
ResultSetMetadata: &cli_service.TGetResultSetMetadataResp{Schema: &cli_service.TTableSchema{}},
ResultSet: &cli_service.TFetchResultsResp{Results: &cli_service.TRowSet{Columns: []*cli_service.TColumn{}}},
}
closeCount = 0
rowSet, _ = NewRows("", "", opHandle, client, nil, directResults, nil)
err = rowSet.Close()
assert.Nil(t, err, "rows.Close should not throw an error")
assert.Equal(t, 1, closeCount)
// rowSet has direct results which include a close operation response. rowSet should be marked as closed
// and calling Close should not call into the client.
closeCount = 0
directResults = &cli_service.TSparkDirectResults{
CloseOperation: &cli_service.TCloseOperationResp{},
ResultSetMetadata: &cli_service.TGetResultSetMetadataResp{Schema: &cli_service.TTableSchema{}},
ResultSet: &cli_service.TFetchResultsResp{Results: &cli_service.TRowSet{Columns: []*cli_service.TColumn{}}},
}
rowSet, _ = NewRows("", "", opHandle, client, nil, directResults, nil)
err = rowSet.Close()
assert.Nil(t, err, "rows.Close should not throw an error")
assert.Equal(t, 0, closeCount)
}
type fetch struct {
direction cli_service.TFetchOrientation
resultStartRec int
}
func TestFetchResultsWithRetries(t *testing.T) {
t.Parallel()
// Simulate a scenario where network issues and retries cause unexpected jumps
// across multiple result pages.
fetches := []fetch{}
client := getRowsTestSimpleClient2(&fetches)
rowSet := &rows{client: client}
resultPageIterator := rowscanner.NewResultPageIterator(
rowscanner.NewDelimiter(0, 0),
1000,
nil,
false,
client,
"connId",
"corrId",
rowSet.logger(),
)
rowSet.ResultPageIterator = resultPageIterator
// next row number is zero so should fetch first result page
err := rowSet.fetchResultPage()
assert.Nil(t, err)
assert.Len(t, fetches, 1)
assert.Equal(t, fetches[0].direction, cli_service.TFetchOrientation_FETCH_NEXT)
// row number four is still in the first page so there should be no calls to fetch
rowSet.nextRowNumber = 4
err = rowSet.fetchResultPage()
assert.Nil(t, err)
assert.Len(t, fetches, 1)
rowSet.nextRowNumber = 5
err = rowSet.fetchResultPage()
assert.Nil(t, err)
assert.Len(t, fetches, 5)
}
func TestGetArrowBatches(t *testing.T) {
t.Run("with direct results", func(t *testing.T) {
executeStatementResp := cli_service.TExecuteStatementResp{}
loadTestData(t, "directResultsMultipleFetch/ExecuteStatement.json", &executeStatementResp)
fetchResp1 := cli_service.TFetchResultsResp{}
loadTestData(t, "directResultsMultipleFetch/FetchResults1.json", &fetchResp1)
fetchResp2 := cli_service.TFetchResultsResp{}
loadTestData(t, "directResultsMultipleFetch/FetchResults2.json", &fetchResp2)
client := getSimpleClient([]cli_service.TFetchResultsResp{fetchResp1, fetchResp2})
cfg := config.WithDefaults()
rows, err := NewRows("connId", "corrId", nil, client, cfg, executeStatementResp.DirectResults, nil)
assert.Nil(t, err)
rows2, ok := rows.(dbsqlrows.Rows)
assert.True(t, ok)
rs, err2 := rows2.GetArrowBatches(context.Background())
assert.Nil(t, err2)
hasNext := rs.HasNext()
assert.True(t, hasNext)
r, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, executeStatementResp.DirectResults.ResultSet.Results.ArrowBatches[0].RowCount, r.NumRows())
r.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r2, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, executeStatementResp.DirectResults.ResultSet.Results.ArrowBatches[1].RowCount, r2.NumRows())
r2.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r3, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp1.Results.ArrowBatches[0].RowCount, r3.NumRows())
r3.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r4, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp1.Results.ArrowBatches[1].RowCount, r4.NumRows())
r4.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r5, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp2.Results.ArrowBatches[0].RowCount, r5.NumRows())
r5.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r6, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp2.Results.ArrowBatches[1].RowCount, r6.NumRows())
r6.Release()
hasNext = rs.HasNext()
assert.False(t, hasNext)
r7, err2 := rs.Next()
assert.Nil(t, r7)
assert.ErrorContains(t, err2, io.EOF.Error())
})
t.Run("without direct results", func(t *testing.T) {
fetchResp1 := cli_service.TFetchResultsResp{}
loadTestData(t, "multipleFetch/FetchResults1.json", &fetchResp1)
fetchResp2 := cli_service.TFetchResultsResp{}
loadTestData(t, "multipleFetch/FetchResults2.json", &fetchResp2)
fetchResp3 := cli_service.TFetchResultsResp{}
loadTestData(t, "multipleFetch/FetchResults3.json", &fetchResp3)
client := getSimpleClient([]cli_service.TFetchResultsResp{fetchResp1, fetchResp2, fetchResp3})
cfg := config.WithDefaults()
rows, err := NewRows("connId", "corrId", nil, client, cfg, nil, nil)
assert.Nil(t, err)
rows2, ok := rows.(dbsqlrows.Rows)
assert.True(t, ok)
rs, err2 := rows2.GetArrowBatches(context.Background())
assert.Nil(t, err2)
hasNext := rs.HasNext()
assert.True(t, hasNext)
r, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp1.Results.ArrowBatches[0].RowCount, r.NumRows())
r.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r2, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp1.Results.ArrowBatches[1].RowCount, r2.NumRows())
r2.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r3, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp2.Results.ArrowBatches[0].RowCount, r3.NumRows())
r3.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r4, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp2.Results.ArrowBatches[1].RowCount, r4.NumRows())
r4.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r5, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp3.Results.ArrowBatches[0].RowCount, r5.NumRows())
r5.Release()
hasNext = rs.HasNext()
assert.True(t, hasNext)
r6, err2 := rs.Next()
assert.Nil(t, err2)
assert.Equal(t, fetchResp3.Results.ArrowBatches[1].RowCount, r6.NumRows())
r6.Release()
})
t.Run("with empty result set, no direct results", func(t *testing.T) {
fetchResp1 := cli_service.TFetchResultsResp{}
loadTestData(t, "zeroRows/zeroRowsFetchResult.json", &fetchResp1)
client := getSimpleClient([]cli_service.TFetchResultsResp{fetchResp1})
cfg := config.WithDefaults()
rows, err := NewRows("connId", "corrId", nil, client, cfg, nil, nil)
assert.Nil(t, err)
rows2, ok := rows.(dbsqlrows.Rows)
assert.True(t, ok)
rs, err2 := rows2.GetArrowBatches(context.Background())
assert.Nil(t, err2)
hasNext := rs.HasNext()
assert.False(t, hasNext)
r7, err2 := rs.Next()
assert.Nil(t, r7)
assert.ErrorContains(t, err2, io.EOF.Error())
})
t.Run("with empty result set, direct results", func(t *testing.T) {
executeStatementResp := cli_service.TExecuteStatementResp{}
loadTestData(t, "zeroRows/zeroRowsDirectResults.json", &executeStatementResp)
executeStatementResp.DirectResults.ResultSet.Results.ArrowBatches = []*cli_service.TSparkArrowBatch{}
client := getSimpleClient([]cli_service.TFetchResultsResp{})
cfg := config.WithDefaults()
rows, err := NewRows("connId", "corrId", nil, client, cfg, executeStatementResp.DirectResults, nil)
assert.Nil(t, err)
rows2, ok := rows.(dbsqlrows.Rows)
assert.True(t, ok)
rs, err2 := rows2.GetArrowBatches(context.Background())
assert.Nil(t, err2)
hasNext := rs.HasNext()
assert.False(t, hasNext)
r7, err2 := rs.Next()
assert.Nil(t, r7)
assert.ErrorContains(t, err2, io.EOF.Error())
})
}
type rowTestPagingResult struct {
getMetadataCount int
fetchResultsCount int
nextRowNumber int64
offset int64
errMessage *string
}
func (rt rowTestPagingResult) validatePaging(t *testing.T, rowSet *rows, err error, fetchResultsCount, getMetadataCount int) {
assert.Equal(t, rt.fetchResultsCount, fetchResultsCount)
assert.Equal(t, rt.getMetadataCount, getMetadataCount)
assert.Equal(t, rt.nextRowNumber, rowSet.nextRowNumber)
assert.Equal(t, rt.offset, rowSet.RowScanner.Start())
if rt.errMessage == nil {
assert.Nil(t, err)
} else {
assert.EqualError(t, err, *rt.errMessage)
}
}
// Build a simple test client
func getRowsTestSimpleClient(getMetadataCount, fetchResultsCount *int) cli_service.TCLIService {
// Metadata for the different types is based on the results returned when querying a table with
// all the different types which was created in a test shard.
metadata := &cli_service.TGetResultSetMetadataResp{
Status: &cli_service.TStatus{
StatusCode: cli_service.TStatusCode_SUCCESS_STATUS,
},
Schema: &cli_service.TTableSchema{
Columns: []*cli_service.TColumnDesc{