Skip to content

Commit b418b20

Browse files
Remove secrets from Claude Code workflow caller
The reusable Claude Code workflow in eng-dev-ecosystem now uses GitHub OIDC federation instead of static secrets, so callers no longer need to pass any credentials. Co-authored-by: Isaac
1 parent f2bc990 commit b418b20

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

.github/workflows/claude-code.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ jobs:
1515
review:
1616
if: github.event_name == 'pull_request'
1717
uses: databricks-eng/eng-dev-ecosystem/.github/workflows/claude-code.yml@main
18-
secrets:
19-
DATABRICKS_SP_CLIENT_ID: ${{ secrets.DATABRICKS_SP_CLIENT_ID }}
20-
DATABRICKS_SP_CLIENT_SECRET: ${{ secrets.DATABRICKS_SP_CLIENT_SECRET }}
2118
with:
2219
prompt: "Review this PR. Focus on correctness, error handling, and adherence to the project's Go conventions documented in CLAUDE.md."
2320
allowed_tools: |
@@ -32,9 +29,6 @@ jobs:
3229
(github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
3330
(github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude'))
3431
uses: databricks-eng/eng-dev-ecosystem/.github/workflows/claude-code.yml@main
35-
secrets:
36-
DATABRICKS_SP_CLIENT_ID: ${{ secrets.DATABRICKS_SP_CLIENT_ID }}
37-
DATABRICKS_SP_CLIENT_SECRET: ${{ secrets.DATABRICKS_SP_CLIENT_SECRET }}
3832
with:
3933
allowed_tools: |
4034
Bash(make lint)

0 commit comments

Comments
 (0)