Move artifacts clean up back to deploy phase (#2722)

## Changes
- Move artifacts clean up procedure to "bundle deploy". This reverts
change in behaviour introduced in 0.245.0
#2526

## Why
We don't expect major changes on the file system during "validate", it
should be as much as possible about reporting issues with the bundle
without taking action.

## Tests
Existing tests.

Author: denik

NEXT_CHANGELOG.md

@@ -11,5 +11,6 @@
 ### Bundles
 * Do not exit early when checking incompatible tasks for specified DBR ([#2692](https://github.com/databricks/cli/pull/2692))
 * Removed include/exclude flags support from bundle sync command ([#2718](https://github.com/databricks/cli/pull/2718))
+* Do not clean up Python artifacts dist and build folder in "bundle validate", do it in "bundle deploy". This reverts the behaviour introduced in 0.245.0 ([#2722](https://github.com/databricks/cli/pull/2722))
 
 ### API Changes

bundle/artifacts/build.go

@@ -39,6 +39,8 @@ func (m *build) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
 		})
 	}
 
+	cleanupPythonDistBuild(ctx, b)
+
 	for _, artifactName := range utils.SortedKeys(b.Config.Artifacts) {
 		a := b.Config.Artifacts[artifactName]
 

bundle/artifacts/cleanup.go

@@ -0,0 +1,38 @@
+package artifacts
+
+import (
+	"context"
+	"os"
+	"path/filepath"
+
+	"github.com/databricks/cli/bundle"
+	"github.com/databricks/cli/libs/log"
+	"github.com/databricks/cli/libs/python"
+	"github.com/databricks/cli/libs/utils"
+)
+
+func cleanupPythonDistBuild(ctx context.Context, b *bundle.Bundle) {
+	removeFolders := make(map[string]bool, len(b.Config.Artifacts))
+	cleanupWheelFolders := make(map[string]bool, len(b.Config.Artifacts))
+
+	for _, artifactName := range utils.SortedKeys(b.Config.Artifacts) {
+		artifact := b.Config.Artifacts[artifactName]
+		if artifact.Type == "whl" && artifact.BuildCommand != "" {
+			dir := artifact.Path
+			removeFolders[filepath.Join(dir, "dist")] = true
+			cleanupWheelFolders[dir] = true
+		}
+	}
+
+	for _, dir := range utils.SortedKeys(removeFolders) {
+		err := os.RemoveAll(dir)
+		if err != nil {
+			log.Infof(ctx, "Failed to remove %s: %s", dir, err)
+		}
+	}
+
+	for _, dir := range utils.SortedKeys(cleanupWheelFolders) {
+		log.Infof(ctx, "Cleaning up Python build artifacts in %s", dir)
+		python.CleanupWheelFolder(dir)
+	}
+}

bundle/artifacts/prepare.go

@@ -33,9 +33,6 @@ func (m *prepare) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics
 		return diag.FromErr(err)
 	}
 
-	removeFolders := make(map[string]bool, len(b.Config.Artifacts))
-	cleanupWheelFolders := make(map[string]bool, len(b.Config.Artifacts))
-
 	for _, artifactName := range utils.SortedKeys(b.Config.Artifacts) {
 		artifact := b.Config.Artifacts[artifactName]
 		b.Metrics.AddBoolValue(metrics.ArtifactBuildCommandIsSet, artifact.BuildCommand != "")
@@ -66,12 +63,6 @@ func (m *prepare) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics
 			artifact.Path = filepath.Join(dirPath, artifact.Path)
 		}
 
-		if artifact.Type == "whl" && artifact.BuildCommand != "" {
-			dir := artifact.Path
-			removeFolders[filepath.Join(dir, "dist")] = true
-			cleanupWheelFolders[dir] = true
-		}
-
 		if artifact.BuildCommand == "" && len(artifact.Files) == 0 {
 			diags = diags.Extend(diag.Errorf("misconfigured artifact: please specify 'build' or 'files' property"))
 		}
@@ -89,18 +80,6 @@ func (m *prepare) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics
 		return diags
 	}
 
-	for _, dir := range utils.SortedKeys(removeFolders) {
-		err := os.RemoveAll(dir)
-		if err != nil {
-			log.Infof(ctx, "Failed to remove %s: %s", dir, err)
-		}
-	}
-
-	for _, dir := range utils.SortedKeys(cleanupWheelFolders) {
-		log.Infof(ctx, "Cleaning up Python build artifacts in %s", dir)
-		python.CleanupWheelFolder(dir)
-	}
-
 	return diags
 }