Skip to content

Commit 98396b4

Browse files
authored
Run tests without coverage on CI (#2781)
## Why - We don't use coverage info at the moment but we would like to speed up CI runs on PRs. - Keep 'push' event unchanged, so that we validate that 'make cover' is still working, as it could get broken otherwise. Related: #2141
1 parent a9cdc71 commit 98396b4

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

.github/workflows/push.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,16 @@ jobs:
6767
make vendor
6868
pip3 install wheel==0.45.1
6969
70+
- name: Run tests without coverage
71+
# We run tests without coverage on PR because we don't make use of coverage information
72+
# and would like to run the tests as fast as possible. We run it on schedule as well, because that is what
73+
# populates the cache and cache may include test results.
74+
if: ${{ github.event_name == 'pull_request' || github.event_name == 'schedule' }}
75+
run: make test
76+
7077
- name: Run tests with coverage
78+
# Still run 'make cover' on push to main and merge checks to make sure it does not get broken.
79+
if: ${{ github.event_name != 'pull_request' && github.event_name != 'schedule' }}
7180
run: make cover
7281

7382
linters:

0 commit comments

Comments
 (0)