Skip to content

Commit 5666361

Browse files
authored
Fix acceptance tests for deploying and binding a dashboard (#2913)
## Changes <!-- Brief summary of your changes that is easy to understand --> 1. Change the golden files and the mocks to change the value of `pageType` field to the serialized dashboard output this is a follow-up change for #2860 ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> On May 20 2025 the Lakeview API changed the value of the `pageType` field to `PAGE_TYPE_CANVAS` in the serialized dashboard output (when not page type is specified) ## Tests <!-- How have you tested the changes? --> Existing acceptance tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
1 parent d35a648 commit 5666361

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

acceptance/bundle/deploy/dashboard/output.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Deployment complete!
1010
"lifecycle_state": "ACTIVE",
1111
"parent_path": "/Users/[USERNAME]",
1212
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard [UUID].lvdash.json",
13-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_UNSPECIFIED\"}]}"
13+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
1414
}
1515

1616
>>> [CLI] bundle destroy --auto-approve

acceptance/bundle/deploy/dashboard/test.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Response.Body = '''
3030
"lifecycle_state": "ACTIVE",
3131
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard 6260d50f-e8ff-4905-8f28-812345678903.lvdash.json",
3232
"parent_path": "/Users/tester@databricks.com",
33-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_UNSPECIFIED\"}]}"
33+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
3434
}
3535
'''
3636

acceptance/bundle/deployment/bind/dashboard/output.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Deployment complete!
1515
"lifecycle_state": "ACTIVE",
1616
"path": "/Users/[USERNAME]/test dashboard [UUID].lvdash.json",
1717
"parent_path": "/Users/[USERNAME]",
18-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\",\"pageType\":\"PAGE_TYPE_UNSPECIFIED\"}]}"
18+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
1919
}
2020

2121
>>> [CLI] bundle deployment unbind dashboard1
@@ -33,5 +33,5 @@ Destroy complete!
3333
"lifecycle_state": "ACTIVE",
3434
"path": "/Users/[USERNAME]/test dashboard [UUID].lvdash.json",
3535
"parent_path": "/Users/[USERNAME]",
36-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\",\"pageType\":\"PAGE_TYPE_UNSPECIFIED\"}]}"
36+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
3737
}

acceptance/bundle/deployment/bind/dashboard/test.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Response.Body = '''
3333
"lifecycle_state": "ACTIVE",
3434
"path": "/Users/[USERNAME]/test dashboard [UUID].lvdash.json",
3535
"parent_path": "/Users/tester@databricks.com",
36-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\",\"pageType\":\"PAGE_TYPE_UNSPECIFIED\"}]}"
36+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
3737
}
3838
'''
3939

0 commit comments

Comments
 (0)